From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752201AbdGMNRJ (ORCPT <rfc822;w@1wt.eu>);
        Thu, 13 Jul 2017 09:17:09 -0400
Received: from szxga01-in.huawei.com ([45.249.212.187]:9764 "EHLO
        szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751176AbdGMNRH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 13 Jul 2017 09:17:07 -0400
Subject: Re: [PATCH net 20/20] net/hinic: Add ethtool and stats
To: Andrew Lunn <andrew@lunn.ch>
CC: <davem@davemloft.net>, <linux-kernel@vger.kernel.org>,
        <netdev@vger.kernel.org>, <bc.y@huawei.com>,
        <victor.gissin@huawei.com>, <zhaochen6@huawei.com>,
        <tony.qu@huawei.com>
References: <cover.1499865197.git.aviad.krawczyk@huawei.com>
 <bd60f835144c37334a53df6a053b7efcc4c26c41.1499865198.git.aviad.krawczyk@huawei.com>
 <20170712154347.GH2557@lunn.ch>
From: "Aviad Krawczyk (A)" <aviad.krawczyk@huawei.com>
Message-ID: <a83d8d80-8a4f-1a65-ff4e-71bf4d0828d1@huawei.com>
Date: Thu, 13 Jul 2017 16:16:46 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170712154347.GH2557@lunn.ch>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.206.50.78]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
        refid=str=0001.0A020203.596772CB.026A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
        ip=0.0.0.0,
        so=2014-11-16 11:51:01,
        dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 625751f9522ef2f682fdcecf765b6ac4
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Andrew,

We will separate the patches when we will resubmit.

Aviad

On 7/12/2017 6:43 PM, Andrew Lunn wrote:
> On Wed, Jul 12, 2017 at 10:17:26PM +0800, Aviad Krawczyk wrote:
> 
> Hi Avaid
> 
>> +
>> +static void hinic_tx_timeout(struct net_device *netdev)
>> +{
>> +	struct hinic_dev *nic_dev = netdev_priv(netdev);
>> +
>> +	netif_err(nic_dev, drv, netdev, "Tx timeout\n");
>> +}
>> +
>> +#ifdef CONFIG_NET_POLL_CONTROLLER
>> +static void hinic_netpoll(struct net_device *netdev)
>> +{
>> +	struct hinic_dev *nic_dev = netdev_priv(netdev);
>> +	struct hinic_hwdev *hwdev = nic_dev->hwdev;
>> +	int i, num_qps = hinic_hwdev_num_qps(hwdev);
>> +
>> +	for (i = 0; i < num_qps; i++) {
>> +		struct hinic_txq *txq = &nic_dev->txqs[i];
>> +		struct hinic_rxq *rxq = &nic_dev->rxqs[i];
>> +
>> +		napi_schedule(&txq->napi);
>> +		napi_schedule(&rxq->napi);
>> +	}
>> +}
>> +#endif
> 
> This has nothing to do with ethtool support. Separate patch please.
> 
>      Andrew
> 
> .
>