From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030404AbcJ1QjM (ORCPT ); Fri, 28 Oct 2016 12:39:12 -0400 Received: from smtp.nue.novell.com ([195.135.221.5]:38622 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965636AbcJ1QjK (ORCPT ); Fri, 28 Oct 2016 12:39:10 -0400 Subject: Re: [PATCH] fpga: zynq-fpga: Delete not needed variable To: atull@opensource.altera.com, moritz.fischer@ettus.com References: <20161028112722.22837-1-mbrugger@suse.com> Cc: michal.simek@xilinx.com, soren.brinkmann@xilinx.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Matthias Brugger Message-ID: Date: Fri, 28 Oct 2016 18:38:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161028112722.22837-1-mbrugger@suse.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/10/16 13:27, Matthias Brugger wrote: > Variable count is never changed in the write path, > we don't need to save it for freeing the dma memory. > > Signed-off-by: Matthias Brugger This is obsolete, as Jason already has this in his patch [1]. Sorry for the noise. [1] http://www.spinics.net/lists/arm-kernel/msg538868.html > --- > drivers/fpga/zynq-fpga.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c > index c2fb412..ffc2823 100644 > --- a/drivers/fpga/zynq-fpga.c > +++ b/drivers/fpga/zynq-fpga.c > @@ -287,12 +287,10 @@ static int zynq_fpga_ops_write(struct fpga_manager *mgr, > struct zynq_fpga_priv *priv; > int err; > char *kbuf; > - size_t in_count; > dma_addr_t dma_addr; > u32 transfer_length; > u32 intr_status; > > - in_count = count; > priv = mgr->priv; > > kbuf = dma_alloc_coherent(priv->dev, count, &dma_addr, GFP_KERNEL); > @@ -338,7 +336,7 @@ static int zynq_fpga_ops_write(struct fpga_manager *mgr, > clk_disable(priv->clk); > > out_free: > - dma_free_coherent(priv->dev, in_count, kbuf, dma_addr); > + dma_free_coherent(priv->dev, count, kbuf, dma_addr); > > return err; > } >