From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757969AbcG0SsH (ORCPT ); Wed, 27 Jul 2016 14:48:07 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:9235 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754776AbcG0SsE (ORCPT ); Wed, 27 Jul 2016 14:48:04 -0400 Subject: Re: [GIT PULL] f2fs for 4.8 To: Linus Torvalds References: <20160727040800.GA69756@jaegeuk> <86e4eb4c-3cb8-8e0f-ebb4-48cdf4dea8e8@fb.com> CC: Jaegeuk Kim , Linux Kernel Mailing List , Linux FS Dev Mailing List , Linux F2FS Dev Mailing List From: Jens Axboe Message-ID: Date: Wed, 27 Jul 2016 12:47:46 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: DM2PR10CA0045.namprd10.prod.outlook.com (10.141.241.13) To BN6PR15MB1187.namprd15.prod.outlook.com (10.172.205.141) X-MS-Office365-Filtering-Correlation-Id: abe97759-8fc6-48a5-4ba6-08d3b64e8294 X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;2:qU3URYfvRYPL7J2Krp2MvpW+bmOf/2A4sK3ejkc8shU07E8NNxNF2KHsBf7U3KsGA/KHOaCp56dMlFJ8RGlo9fCBp8N2HNVMEDWYALYCyPlPiEt5oUWv9G5WZaKaIizn3nfZEjXDV07uiSfZ4pPCHaHlxFEoRPG38bPCrSsisJCfKtyFiKFCHTeqOgnk+T8J;3:T2jKgo/ixZD+RDD8PJ7GNup8TclEg1Vn8fKpemzhKN2UqWGZzGgUuPshxcDtMnu6DvvfZ+lRpPrGVZ3i9ssf3BI8t2pn/a/HQp9hVxPvITB/CYofeZ03XcD6hA6cz18M;25:cuf0T+kyreWFceoKGBNrkRicWRdDMAdpnqk0rBg6ndJMIV+VTXkOaAuzELOl631vjhcFqQx+wb5pYViKwTWCHdiH/IBJgKyd5jDDulZOffWg1Zm+ewg6fPmSvynxMvnBCjN7HlUynIkZ47vFI/OYZDgD39C3GFrRw9IzyzDJWY9jERelXGAXQjtpLmXyRKNlozFuzHAx/OTwRq+ihDSAV9FlqjayWo57upek47u+8BMUUnI5R7qykVolFDLYGqMSrnMmUIrum3c92hIws+JR2mZO6hgG9zwMiDVlG4EkFZp8XZgtDGAQ0jU71ZcPVny86JXaw7louDbYD1AKc5hMhWA6+/elBDSkFEQP09iL2XhfLMsV/vhn9LHSYYDAPuCy15G8N38Lm++j9D37Z491PsUaJ8oz6jo/WSYEHne3ygY=;31:SYQPN/fkjx02bm3wRknBdN3rn0389G7r6boLirL4gotxE/QX/nTSPTunR24UdtmAAC9cVEL9aJAke7GPfBahOUvj2hnQc6as8TfGoaQsgWGibwaRD4FK1c2CZohub5e/I+uc/2CmHcBjMxo7Lg6yr92jWLnyqC5U5GL3Q3CeCXSPMOnxwpqB+BEqggWOYLvQ82so2/7x9VjoEprh9nFQUw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1187; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;20:6cL6fBQX033sBX45xpDqu2IfnAICa8w+q/tX3SEw1QBBKV5T/FAopEZLACXThnfUHU14qkJjIGZ3V5m69Q+G3XqIhPU6m2BWsYPipmyIqKeS4VqRWrCCXn6blAcDVeElYzOJ77W54se2hR4QJZVHAv7Stpu+dl1CGPwQFEMYwNw=;4:77MqJDFxfWXqIXQKzVihk+rr1z4pjJhLUhQsyYc7Aznh9cW6mg8TDuDdplrkSkz4Ir2E9+N96eHzscsMpCABY34VoAXU3QpvNq/1mPOr001ZXTBI6KG/W3xnpSVnkFq60kfM6j1u5GTxvCIdM4oQ841gDcPZOLlln9jJmmQbXvUqDr/XDMHH3iLc61tFZaRcaQ6cPUzb/fx9sjWDMRaEUqOjbS7utNUhByV5to/0INhG2X0jeDy/KVjZo/mhbc4XkbMUWtj8bblupSWW0cZluxjBPL86CyVF/a2+XHntTyy0a8K1DnEZhEQv3Bxa/jpU/ExtI0ykxtTlk2GBkYx4/Go7/I06KioSwFFRPNYaKIySP0muoKuCvSua4aB65S+YOKZWJv1q9Q28qKLndYayE/11drl0ENamy+9Ar/W8+Cs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:BN6PR15MB1187;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1187; X-Forefront-PRVS: 0016DEFF96 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(377454003)(199003)(24454002)(189002)(106356001)(117156001)(42186005)(31686004)(36756003)(4001350100001)(110136002)(50466002)(65806001)(86362001)(31696002)(93886004)(189998001)(97736004)(33646002)(65956001)(47776003)(105586002)(66066001)(19580395003)(81156014)(81166006)(8676002)(76176999)(50986999)(230700001)(83506001)(101416001)(54356999)(7846002)(68736007)(2906002)(4326007)(3846002)(77096005)(7736002)(19580405001)(305945005)(2950100001)(586003)(92566002)(23676002)(6116002)(64126003)(65826006);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1187;H:[192.168.1.130];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjE1TUIxMTg3OzIzOkxpTGk4UGgzNk5acVRIMnZVb1NXb293QmE5?= =?utf-8?B?TzNnT3BPYXBEMFFEMGd3QmhTSkRxaDBRUlZLSXF3bFZRbmY3U1dodm80K2pL?= =?utf-8?B?bzVrRW9icVFCK1VMMFIyaDZyVlZVYmZhZ2J1TzJDRWJzQWU1cGFiblFzQ2hl?= =?utf-8?B?bnR0VnZCMTAzbXI3L3ZhdHNPenZkNXBFSjd4Z2g3dHViZzRrR3c5VUo0VG5z?= =?utf-8?B?Y0RKS01JWGNNalF5Q0NibEVabCszWWljcVhDR1ZBRGsrd1YwdWdkbEF0VDNK?= =?utf-8?B?RVJEWGhwWEkyY1lzLzdqY1E1L1VIeURZa2ZaMUtXRnJadUhxMVZhc29hQkVu?= =?utf-8?B?MDVqNlBkTkxYb3g1c0x0dzd1Sm1yRS9uVWE4d1hwLzlxaHdZMGpuOGczSmlU?= =?utf-8?B?WTZsYzNlS1hjKzBXOVlCS2hRRm56cGxGZ0tQWkRFZnd3dHU2RG1qS2F4MHhu?= =?utf-8?B?NWdGZCtDQXhKN2JzQUZUZGZ3U3dUMzBzRjBGV29SZ2kyRmh3SkdaZ0ZJK29R?= =?utf-8?B?MDFrQVNwQVNxQllWVGpnZER2dFYxRTVLb2tsa1A4dml2MkRHcm1MRGpQR05Q?= =?utf-8?B?Kzg5UVZ4QjcrVXp0eVRXVkhlNzhaTE5wZTJRQ0xFK0FVL1RVV3lDVlUzaVc3?= =?utf-8?B?OWZBbkpKQzViQ0U2Zzc2OHZtY0pGSkNObDlXRWpSOUhBTzZSM0lLdU11clN6?= =?utf-8?B?QTRyOTFKcS9zSVI0ZGdkN3dvOHcxb2VycW9VSzNJdXN3eGorQ3hzQlFJc09Z?= =?utf-8?B?d2FlcXR0QkhyQ1VwWmF6bU10T1k1RHdrNmlqNFlwQTJYTjd2YjdDZE9xREtZ?= =?utf-8?B?T242SnE1TVRlK2pkaVEwamFKeldZaGN4RjJna3E0ZXNmbUlnMFNpK0U2MG5W?= =?utf-8?B?YUtDdWZ6WGdZdGpvWlRMRlhiYmxRV0gyZmZGd3IyakVKWUplLy9SZjVPd1Mw?= =?utf-8?B?VUR2Vk83WXpQUS9zVVVMUFJlM2RCZFpaSjk3V1poUnNualB3cVk2WldNaDVX?= =?utf-8?B?V1NCa0hlVzFYbzl6MW9YNitKNURWVE15RzZFT0o5bDF0Q0ZzUGtOcEwxeVhx?= =?utf-8?B?L3hGNGRMTzFqTUo1UjJOYko4MzJDbFNseVgxbEk4a2lER05nVHVJRzhkVXk2?= =?utf-8?B?a0htTUZQU2xadXRielpiWEZUWW5XTDhRUG82eGI3ZUtJT1hHQmNnbW9oWXFC?= =?utf-8?B?RTByK0VqVjFLV2tneVpodjgzZUhzbndCUWFCL2JiTERRL2lJcGU4Tm93Z1FW?= =?utf-8?B?VkNDTjlZbVUwaTd6YjR5SitsVy9jVi81QkpqN25iWk9XZ1BockNtYnpKNVNJ?= =?utf-8?B?QVNpc2RQS3JPMDNGRUFiTkUzUjJCM0t1K3NtRm9KcmFGYmEwMmdFb3VTL0Fw?= =?utf-8?B?MHNPNEpxRWlYQThrTG5XdHBIK0Y2Q3R5ejBjSitWZDhOWitQQmdXMEcwaFRG?= =?utf-8?B?emxvQlFxTE9IcTROY3B2N0R0Z3hUaVM3NG80emhlcTMrWDhjSTZQOHhVVUNH?= =?utf-8?B?cEdHQzNTRzlUTzF4RnNEbTY3cS85RzhJSmlYS1ZoSzNja2dLYUFPRk45d0dn?= =?utf-8?B?YXlCVGY4OWNHY21rY2tkcXpnLzcwcjhEdCtPOTRwQkNDVkcySVI1V0Z2T29w?= =?utf-8?B?dFl1Yzc5YmNSRyt3dVJaSE9acEg3NUM2amVlK3N2ZFplZTJnalVJR291S25E?= =?utf-8?B?bndNTVFtRlZEYnJKbVZoZWlwQ1FNK1dadmZTSnBUaGZGbWtQZEVIVVdwV1ZV?= =?utf-8?Q?KjaTObyind5+xG1LGiqrWZ9lOm4IRgV+ciMjY=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;6:2Wi6zCufRkI7sEOzwypePydnzoTRR/ASBO/StMjxgkT8Sz5NQab4ko57IeamzhdlUD1NX9qqM0xG34L7N8oB4FnXM4rreuFo4SuOyhrchjg1ft2SmTLWywDIOGWvdBdww/GeUYCsCbHPWAn8i6xzEqx9GHvrhuKPP7R21Xp4IUxucc31LXsOD0Dv4aXvLmhpF7xVP5LbwnORxR/JJVAUpEbRArekUbXwS+J3vybo0ZDwaLUogq4gdDMtk55aNNvexltEyghWAdkXUBXHgYVgCy4kyKPGTqqWezk3H4ZKD5s=;5:7D9QeKNe0uHdegUvHUH5FLxQHCe828sPveSVScZlJZB682Nl/wbBg84PZPti6SC2lR5mOttiaOETXpFkb9iJcxXyBZbM5+fJnEPIn9j95XEU4FbwHBHOvWcGQhqHySzfaix4yHThPGeo+SA4bBaBCg==;24:wt2xahNo5OCB/vgQ7f3aN1pRPkdX8CwfNmH71zRcLKUxql7u36OfdX1cQAMzbaZSBYHJfpmPr8x6M0+O5Dcq2kFdz1e7rA9rjtY/V2w1oy0=;7:Hmv1oMiZJ8c+y08kVtVO947aBpnejmRoZ/pGEYb1+pe+ZwFhU1kGoUmJuKKvt0tp3WpOsn7D7UKa6L5Al5siL6SXQZV067W/vSlAkXoR3t0v5cK4HtWcMUqQl6OOdTmbOd9nHbIjDNFw+pLDcgmxmZQgGxYj+NCUagA10HsvLI9aJnrYu9hZ8vRPmC8hzNxvLa56FlJy+HYmqoZgCEQlVkxecWQ3cY7mOlEeodg5GqoZjs7/+Cmz3I7EMqKNvcay SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;20:U9oGPCHKB3lGSWytIqQrtaq2vN/KiD897J/8Q1EzILPe7ZIXJApr4KI7zlMmd4SF16QYevy7fUDYYnN0ep0JxvBHVR6YCa/8mBtJITWny0JvjkRAhZdOjOJnbEs9iPeFKYmo3rK/fOVp/OQ+n1nmkKQTkzeoKLTnhAr2W2wktiM= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2016 18:47:49.8098 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1187 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-07-27_11:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/27/2016 12:46 PM, Linus Torvalds wrote: > On Wed, Jul 27, 2016 at 11:29 AM, Jens Axboe wrote: >> >> Looks OK to me, though I think you could have dropped the ->bi_rw >> assignment in f2fs_submit_page_bio(): >> >> bio->bi_rw = fio->op_flags; >> bio_set_op_attrs(bio, fio->op, fio->op_flags); >> >> __submit_bio(fio->sbi, bio, fio->type); > > Ahh, yes. I'll add a patch to drop that line, unless you just want to > do it yourself (or Jaegeuk Kim wants to do it in the f2fs tree). I've got a few more things coming in this merge window, so I can just queue that up. > Jaegeuk, I'd still really want confirmation that it all actually > works. The extra line should be harmless, even if Jens is right that > it is ugly and wrong. It might be worth testing with that line > removed. Yes please, I don't have an easy way to test it either. -- Jens Axboe