From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753667AbdAaCqY (ORCPT <rfc822;w@1wt.eu>);
        Mon, 30 Jan 2017 21:46:24 -0500
Received: from mail-pf0-f196.google.com ([209.85.192.196]:33341 "EHLO
        mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752551AbdAaCqW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Jan 2017 21:46:22 -0500
Subject: Re: [PATCH] perf tools: Create for_each_event{_system, _file} macros
 for tracepoints iteration
To: Jiri Olsa <jolsa@redhat.com>
References: <1485765328-21787-1-git-send-email-treeze.taeung@gmail.com>
 <20170130090812.GD22029@krava>
 <bc0b5c66-0de0-e380-6925-7d4f4d9fccb7@gmail.com>
 <20170130123858.GA11068@krava>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Wang Nan <wangnan0@huawei.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Frederic Weisbecker <fweisbec@gmail.com>
From: Taeung Song <treeze.taeung@gmail.com>
Message-ID: <a84646ce-671e-9dfc-680c-38ceadba1f2d@gmail.com>
Date: Tue, 31 Jan 2017 11:37:41 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <20170130123858.GA11068@krava>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 01/30/2017 09:38 PM, Jiri Olsa wrote:
> On Mon, Jan 30, 2017 at 07:32:03PM +0900, Taeung Song wrote:
>
> SNIP
>
>>> looks almost the same as for_each_event_system macro,
>>> what's the difference other than 'ftrace' check?
>>
>> Little thing.
>> In parse-events.c for_each_event macro contains
>> tp_event_has_id() function But this function isn't used in
>> util/trace-event-info.c
>>
>>> also why's one 'file' and the other 'system'? looks
>>
>> Just, I follow the name of each function that use the macros..
>>
>>> like we coud have just one macro in here
>>>
>>
>> I understood. :)
>> How about this ?
>
>
> looks ok, but can't apply it.. it's probably mangled
>

I got it.
I'll resend this changed patch!

Thanks,
Taeung