mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hamza Mahfooz <hamza.mahfooz@amd.com>
To: Caio Novais <caionovais@usp.br>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: "Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Wesley Chalmers" <Wesley.Chalmers@amd.com>,
	"Lee, Alvin" <Alvin.Lee2@amd.com>, "Jun Lei" <Jun.Lei@amd.com>,
	"Qingqing Zhuo" <qingqing.zhuo@amd.com>,
	"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
	"Jiapeng Chong" <jiapeng.chong@linux.alibaba.com>,
	"Nicholas Kazlauskas" <Nicholas.Kazlauskas@amd.com>,
	"Gabe Teeger" <gabe.teeger@amd.com>,
	"Roman Li" <roman.li@amd.com>,
	"Maíra Canal" <mairacanal@riseup.net>,
	"Deepak R Varma" <drv@mailo.com>
Subject: Re: [PATCH 1/2] drm/amd/display: Remove unused variable 'scl_enable'
Date: Wed, 29 Mar 2023 12:06:18 -0400	[thread overview]
Message-ID: <a848b681-0c24-2676-2f20-03b11fd8dd77@amd.com> (raw)
In-Reply-To: <20230328220947.108188-2-caionovais@usp.br>

On 3/28/23 18:09, Caio Novais wrote:
> Compiling AMD GPU drivers displays a warning:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_rq_dlg_calc_314.c: In function ‘dml_rq_dlg_get_dlg_params’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_rq_dlg_calc_314.c:991:14: warning: variable ‘scl_enable’ set but not used [-Wunused-but-set-variable]
> 
> Get rid of it by removing the variable 'scl_enable'.
> 
> Signed-off-by: Caio Novais <caionovais@usp.br>

Applied, thanks!

> ---
>   .../gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
> index d1c2693a2e28..ea4eb66066c4 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_rq_dlg_calc_314.c
> @@ -988,7 +988,6 @@ static void dml_rq_dlg_get_dlg_params(
>   	double hratio_c;
>   	double vratio_l;
>   	double vratio_c;
> -	bool scl_enable;
>   
>   	unsigned int swath_width_ub_l;
>   	unsigned int dpte_groups_per_row_ub_l;
> @@ -1117,7 +1116,6 @@ static void dml_rq_dlg_get_dlg_params(
>   	hratio_c = scl->hscl_ratio_c;
>   	vratio_l = scl->vscl_ratio;
>   	vratio_c = scl->vscl_ratio_c;
> -	scl_enable = scl->scl_enable;
>   
>   	swath_width_ub_l = rq_dlg_param->rq_l.swath_width_ub;
>   	dpte_groups_per_row_ub_l = rq_dlg_param->rq_l.dpte_groups_per_row_ub;

-- 
Hamza


  reply	other threads:[~2023-03-29 16:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28 22:09 [PATCH 0/2] drm/amd/display: Remove a unused variable and add a function prototype Caio Novais
2023-03-28 22:09 ` [PATCH 1/2] drm/amd/display: Remove unused variable 'scl_enable' Caio Novais
2023-03-29 16:06   ` Hamza Mahfooz [this message]
2023-03-28 22:09 ` [PATCH 2/2] drm/amd/display: Add previous prototype to 'optc3_wait_drr_doublebuffer_pending_clear' Caio Novais
2023-03-29 16:07   ` Hamza Mahfooz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a848b681-0c24-2676-2f20-03b11fd8dd77@amd.com \
    --to=hamza.mahfooz@amd.com \
    --cc=Alvin.Lee2@amd.com \
    --cc=Jun.Lei@amd.com \
    --cc=Nicholas.Kazlauskas@amd.com \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=Wesley.Chalmers@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=aurabindo.pillai@amd.com \
    --cc=caionovais@usp.br \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=drv@mailo.com \
    --cc=gabe.teeger@amd.com \
    --cc=harry.wentland@amd.com \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mairacanal@riseup.net \
    --cc=qingqing.zhuo@amd.com \
    --cc=roman.li@amd.com \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®