mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel+linux-wireless@molgen.mpg.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: net/wireless/shipped-certs.c:2:1: error: expected expression at end of input
Date: Tue, 5 Dec 2017 11:36:25 +0100	[thread overview]
Message-ID: <a85cf78e-4e14-396a-6d53-2fdfa7d25df7@molgen.mpg.de> (raw)
In-Reply-To: <1512469867.26976.17.camel@sipsolutions.net>

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

Dear Johannes,


On 12/05/17 11:31, Johannes Berg wrote:

>>> Ah, here we go - you probably don't have "hexdump" installed on this
>>> system?
>>
>> Well, I didn’t, but got the error, that hexdump couldn’t be found. After
>> installing it, I got the error above, and sent the message.
> 
> Ah, ok.
> 
>> Removing the file `net/wireless/shipped-certs.c`, and building again,
>> fixed the problem. So I guess, the clean-up task(?) in the build script
>> has a problem.
> 
> Did you run "make clean"? I'm not even sure it'd delete the file
> though.

Yes, the target `deb-pkg` does that.

> I suppose if this target fails we shouldn't create the file, but I
> haven't quite figured out how to do that - let me try.

Thank you for looking into this.

>> I do not think, it’s necessary, as I got an error, that the executable
>> is not there. No idea, if it is documented somewhere though.
> 
> Fair enough. I do have a patch to use od/sed so perhaps I'll just throw
> that in anyway just to not require people to install hexdump.

Hmm, my gut says to use `hexdump`, which is clearer, and not some other 
`od/sed` which is probably hard to understand.


Kind regards,

Paul


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]

  reply	other threads:[~2017-12-05 10:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 10:01 Paul Menzel
2017-12-05 10:03 ` Johannes Berg
2017-12-05 10:15   ` Paul Menzel
2017-12-05 10:31     ` Johannes Berg
2017-12-05 10:36       ` Paul Menzel [this message]
2017-12-13  7:53   ` Damian Tometzki
2017-12-13  9:16     ` Paul Menzel
2017-12-13 11:00       ` Damian Tometzki
2017-12-13 11:07         ` Paul Menzel
2017-12-13 13:33           ` Damian Tometzki
2017-12-13 14:19           ` Damian Tometzki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a85cf78e-4e14-396a-6d53-2fdfa7d25df7@molgen.mpg.de \
    --to=pmenzel+linux-wireless@molgen.mpg.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®