From: Sukanto Ghosh <sukanto.cse.iitb@gmail.com>
To: trivial@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] removes unused variable from kernel/sysctl.h
Date: Thu, 16 Apr 2009 23:22:21 +0530 [thread overview]
Message-ID: <a85e78f50904161052s71dabbe9p17ac68b35331eae@mail.gmail.com> (raw)
This patch removes the unused variable 'val' from the
__do_proc_dointvec() function
in kernel/sysctl.h. The integer has been declared and used as 'val =
-val' and there is
no reference to it anywhere.
Although I am this doesn't affects the kernel binary because gcc
removes it, still it
might be confusing for people reading the code.
Signed-off-by: Sukanto Ghosh <sukanto.cse.iitb@gmail.com>
----
--- linux-2.6.29.1/kernel/sysctl.c.orig 2009-04-16 19:57:21.000000000 +0530
+++ linux-2.6.29.1/kernel/sysctl.c 2009-04-16 19:58:26.000000000 +0530
@@ -2198,7 +2198,7 @@ static int __do_proc_dointvec(void *tbl_
void *data)
{
#define TMPBUFLEN 21
- int *i, vleft, first=1, neg, val;
+ int *i, vleft, first=1, neg;
unsigned long lval;
size_t left, len;
@@ -2251,8 +2251,6 @@ static int __do_proc_dointvec(void *tbl_
len = p-buf;
if ((len < left) && *p && !isspace(*p))
break;
- if (neg)
- val = -val;
s += len;
left -= len;
next reply other threads:[~2009-04-16 17:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 17:52 Sukanto Ghosh [this message]
2009-04-16 19:06 ` Jaswinder Singh Rajput
2009-04-23 5:29 ` Sukanto Ghosh
2009-05-05 12:36 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a85e78f50904161052s71dabbe9p17ac68b35331eae@mail.gmail.com \
--to=sukanto.cse.iitb@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome