From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35F23C4167B for ; Tue, 28 Nov 2023 09:12:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234740AbjK1JMY (ORCPT ); Tue, 28 Nov 2023 04:12:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbjK1JMW (ORCPT ); Tue, 28 Nov 2023 04:12:22 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 672D7AB; Tue, 28 Nov 2023 01:12:28 -0800 (PST) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AS8xC52028057; Tue, 28 Nov 2023 09:12:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=AqfsZhfJIV0ah8Mcq2ahxjWlSq2ikPRbgAL9ct0yCb4=; b=BytLajBiDBIkAvT8ar4pqExWzyliSVFA3VGWJxDU4m9cU+4SbYWXcviucRqHk/riR+w/ jR+/9kGqB6jRDAoElZba5BzEeN+gGU4yWTQgI8WqW3hhN085W+pJMYwFznMl0UL77LUh woPZ/eMIe4IeKetBDYAa/Ze48iCGFmvfZwqiJNAYhlv/tQMr82k3EoxybJCzlYQYSIa6 +8A5s4rN9xGhEyJM/TR62PaTZUsRp/M6n3X3OwTTatpjzQe1Cq5BybMk46WjC14b1kD5 L5k9dlz02k3IfsSQNcCI65PD7ecEJzX7yFG75WBglE7q/9Y0uI/NLwxU2Zq9wjMVH9zG yg== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3umt4qjx6h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Nov 2023 09:12:06 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3AS9C5Dd016438 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Nov 2023 09:12:05 GMT Received: from [10.239.133.73] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 28 Nov 2023 01:12:03 -0800 Message-ID: Date: Tue, 28 Nov 2023 17:12:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] freezer,sched: do not restore saved_state of a thawed task To: Elliot Berman , "Rafael J. Wysocki" , Pavel Machek , Ingo Molnar , "Peter Zijlstra (Intel)" CC: , Pavan Kondeti , , , Abhijeet Dharmapurikar References: <20231120-freezer-state-multiple-thaws-v1-0-f2e1dd7ce5a2@quicinc.com> From: "Aiqun(Maria) Yu" In-Reply-To: <20231120-freezer-state-multiple-thaws-v1-0-f2e1dd7ce5a2@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: tb538e39X4vhm4jHaQHO2TqEhx3aRRHW X-Proofpoint-GUID: tb538e39X4vhm4jHaQHO2TqEhx3aRRHW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-28_08,2023-11-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 priorityscore=1501 malwarescore=0 bulkscore=0 mlxlogscore=831 mlxscore=0 phishscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311280071 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/21/2023 1:36 AM, Elliot Berman wrote: > This series applies couple fixes to commit 8f0eed4a78a8 ("freezer,sched: > Use saved_state to reduce some spurious wakeups") which was found while > testing with legacy cgroup freezer. My original testing was only with > system-wide freezer. We found that thaw_task could be called on a task > which was already frozen. Prior to commit 8f0eed4a78a8 ("freezer,sched: > Use saved_state to reduce some spurious wakeups"), this wasn't an issue > as kernel would try to wake up TASK_FROZEN, which wouldn't match the > thawed task state, and no harm done to task. After commit 8f0eed4a78a8 > ("freezer,sched: Use saved_state to reduce some spurious wakeups"), it > was possible to overwrite the state of thawed task. > > To: Rafael J. Wysocki > To: Pavel Machek > To: Ingo Molnar > To: Peter Zijlstra (Intel) > Cc: > Cc: Pavan Kondeti > Cc: Aiqun Yu (Maria) > Cc: > Cc: > Signed-off-by: Elliot Berman Shall we add Fixed tag and Cc: stable@vger.kernel.org ? Since it is fixing a stable user thread hung issue. > > Originally sent to only linux-arm-msm, resending to correct authors. > - Link to v1: https://lore.kernel.org/r/20231120-freezer-state-multiple-thaws-v1-0-a4c453f50745@quicinc.com > > --- > Elliot Berman (2): > freezer,sched: do not restore saved_state of a thawed task > freezer,sched: clean saved_state when restoring it during thaw > > kernel/freezer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > --- > base-commit: 6d7e4782bcf549221b4ccfffec2cf4d1a473f1a3 > change-id: 20231108-freezer-state-multiple-thaws-7a3a8d9dadb3 > > Best regards, -- Thx and BRs, Aiqun(Maria) Yu