From: Krzysztof Kozlowski <krzk@kernel.org>
To: Amit Sunil Dhamne <amitsd@google.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com,
dmitry.baryshkov@linaro.org, kyletso@google.com,
rdbabiera@google.com, badhri@google.com, linux@roeck-us.net,
xu.yang_2@nxp.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v1 2/3] dt-bindings: usb: maxim,max33359.yaml: add usage of sink bc12 time property
Date: Fri, 1 Nov 2024 08:09:52 +0100 [thread overview]
Message-ID: <a86c8317-16d6-4aa0-b8fd-5c83b1445212@kernel.org> (raw)
In-Reply-To: <r44xdvk53c45bhyvwhy6722vj7wttkhfesta3ty22kkt6nfrtu@vcooujz3ywlj>
On 01/11/2024 08:02, Krzysztof Kozlowski wrote:
> On Thu, Oct 31, 2024 at 04:59:53PM -0700, Amit Sunil Dhamne wrote:
>> Add usage of "sink-bc12-completion-time-ms" connector property to
>
> There is no such property. You cannot add it. You did not even
> test this patch before sending :/
>
Sorry, now I see that's the patch 2, not 1. Somehow I thought you
started with it and I got confused.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-01 7:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 23:59 [PATCH v1 0/3] Add new time property for battery charger type detection Amit Sunil Dhamne
2024-10-31 23:59 ` [PATCH v1 1/3] dt-bindings: connector: Add time property for Sink BC12 detection completion Amit Sunil Dhamne
2024-11-01 7:10 ` Krzysztof Kozlowski
2024-10-31 23:59 ` [PATCH v1 2/3] dt-bindings: usb: maxim,max33359.yaml: add usage of sink bc12 time property Amit Sunil Dhamne
2024-11-01 1:20 ` Rob Herring (Arm)
2024-11-01 7:02 ` Krzysztof Kozlowski
2024-11-01 7:09 ` Krzysztof Kozlowski [this message]
2024-11-01 7:59 ` Dmitry Baryshkov
2024-11-01 8:34 ` Krzysztof Kozlowski
2024-11-03 3:17 ` Amit Sunil Dhamne
2024-10-31 23:59 ` [PATCH v1 3/3] usb: typec: tcpm: Add support for sink-bc12-completion-time-ms DT property Amit Sunil Dhamne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a86c8317-16d6-4aa0-b8fd-5c83b1445212@kernel.org \
--to=krzk@kernel.org \
--cc=amitsd@google.com \
--cc=badhri@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzk+dt@kernel.org \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rdbabiera@google.com \
--cc=robh@kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome