From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B59D2737E6 for ; Tue, 1 Jul 2025 12:10:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751371848; cv=none; b=o4BGdxlSR1cNiofKvKx54RBr1TR5kAM35i23Z+PwEXIUxq6lu9Yd4oT3vm6XSDg8L+eWsOq6ADXxIAgzfRFGsakI5Pjnqu/gIYCO9efshr+BzRt3jEUEWIBETlR4nDdRCPdqr026wm0M+V57fFjlmAtLUjFS5DWqbUzNRrV8H60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751371848; c=relaxed/simple; bh=+ZTcoZDBgfv9tgwSo5krlJwewXP9Gn+CvJCEwKMyp+g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k3gChZVQE2H+n8luXwF2FZbX7fWB3iIqy9AgtkTJfAJb+koLFxjnGI1gI1Y42/j/MOQJx3dxAlxyLP8bmiMvOExygPERjfr5Z7Q5jZ3OXqZwam1MDE81QGYbBfwNzt80UKvKbagzj0WqrKo/AIFJ9sIOOMebKCmsX2T+gvRBF6w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pqFrBlPi; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pqFrBlPi" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5619klu4002460 for ; Tue, 1 Jul 2025 12:10:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= W7b4c8FAEbR26sZIDd9GjlRjW8NmHWg/e6iguo0YBys=; b=pqFrBlPioOJlzMoi 41hkI6RiQkIUPd+reYNaF+2l4dMszIj9gs2Gt8pJgqPc+zi5y91fr5yPE+9mBe91 eAXgI3Qu1pfXhhAG4agIrHGP5lgECx1KNf+6ehkvp2unibXmJuy0TlZH+VA+vDk3 FgyobEtGYdnPfj/lB6GnQ63SVyxkpn7GFZvlTSYsUCHkWk+M2nZOA+5JbaVjjhVc A+OZwhYMpIlketjKir7i+ys7L7+g3rjiFckVN7JG5AtOyE9YbFXYL5hCCgptF1QS l5X0ApCTpCSjh1SI1DAiEppqP6McnlghdXrP6QCm+InEwFY1yRzbGSLIP4BjV5Rg un0uDQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47j9pcrpj2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 01 Jul 2025 12:10:45 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4a5a9791fa9so13038681cf.1 for ; Tue, 01 Jul 2025 05:10:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751371844; x=1751976644; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W7b4c8FAEbR26sZIDd9GjlRjW8NmHWg/e6iguo0YBys=; b=feFvqAdF+oER4QlTid+I0Zgoadwaih0cf23lFF1SW/ntPEbrI0Lpv+F35ZgGfMprZ9 lC74OETHLzj9k/p84IEDkyHkk6HHYNAq9EFjzrogsSmFrFxXPM8zQnZpIori7P6MoH/y slW/LsOYAhp0Dh/Yz8EaH8+kBFw036gmWADRmJ4hqOH5EZCvMnBtPARI6a7OJApegNOV 3rs8/Q+A8AthhuEC0x9LSNfWKzV+Y+p6OOpPMvjDyYjAz0ZKzSIoF8lU1H98KjU33I8T bE8ol363R4hmlK+uTpwSI5UK9v1qz+sxJSk5CJqcE/2CJ5DtnZ6w7ujENId+6n8czZb5 2Npw== X-Forwarded-Encrypted: i=1; AJvYcCVOSz3wB/fC9q4/8VLOtBRnfmvzcCkY0bpgfSMLTo2OveaMuWJo1Ma4tOmb0U4jPF7Yt92GmjxXsWlHNvU=@vger.kernel.org X-Gm-Message-State: AOJu0YzzMdWitPuJhMqPkzjar1HbOi5owYpgX80p3Jg/VWsHy2ajrX60 CHvXoKmGagpAoEZnUnj3xc2LccsNIGqvI7vibbJqg2RSOqlNjn6RnS1w4TuUXplqPvk0AGA7dtS Lzitql36ECesxXb7zuV3IY5L7Rz5s/DaGr+fVqLPuIsaGq66VYc9vgIFc5AbR6AMeFsY= X-Gm-Gg: ASbGncsG19j84RxdojOzM6oVXv7JbmQDQ3+1OmAaJz9U5D2m9dRFtSnWhoWY4AZgFeM f8P/mOCTFgoPPGtC8Zqg8OuF454sZgDrxuIMOg7mJLSeKSUr6nu5ofoE8gZmfLq2b9Tmlsi2zTc dNKakPxfizD2V/1fPgCWjdoWdmD+TH0i+lALkGXCVXNrPzwrDVl9X3JsfIKGWB9EW+xnsM3iWDd MoEp4u5ZxmZOMk9Cqq3MCB3RsUeR24wfWw+kEAaH5yyHNoQeuCqNoPtq7S6u4d8xf2eIJkQEV8j dRLJ8B/sVmlYZVu0/tKvIviLGU3E1OHJX6a1/jAtrOUVUIfYlOwYU+Poq1K4ydYRDJAbkqXOcF1 IeZKz5W1v X-Received: by 2002:a05:620a:3710:b0:7c0:bc63:7b73 with SMTP id af79cd13be357-7d46774f6eamr146983185a.13.1751371844122; Tue, 01 Jul 2025 05:10:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGTxzbx67vZnwclq62QSQMEsaHBiUQUi2s3v5N3dbE7nNpEwja0y/5s43uax9D/Bfc+SnBykA== X-Received: by 2002:a05:620a:3710:b0:7c0:bc63:7b73 with SMTP id af79cd13be357-7d46774f6eamr146979885a.13.1751371843303; Tue, 01 Jul 2025 05:10:43 -0700 (PDT) Received: from [192.168.1.114] (83.9.29.190.neoplus.adsl.tpnet.pl. [83.9.29.190]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae353ca1619sm854280966b.149.2025.07.01.05.10.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 05:10:42 -0700 (PDT) Message-ID: Date: Tue, 1 Jul 2025 14:10:35 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/8] arm64: dts: qcom: ipq5424: Add NSS clock controller node To: Luo Jie , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Georgi Djakov , Philipp Zabel , Richard Cochran , Konrad Dybcio , Catalin Marinas , Will Deacon , Anusha Rao Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com, quic_suruchia@quicinc.com, quic_pavir@quicinc.com References: <20250627-qcom_ipq5424_nsscc-v2-0-8d392f65102a@quicinc.com> <20250627-qcom_ipq5424_nsscc-v2-7-8d392f65102a@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: bk6mHYs8Vz19UnDmzVFeuVcMdalSBccZ X-Proofpoint-ORIG-GUID: bk6mHYs8Vz19UnDmzVFeuVcMdalSBccZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzAxMDA3NiBTYWx0ZWRfX003ZPv9jMtOk 7mHoJX747NWFFdp+rx62mnEbtVeBYZ2L448SrmbBZ77rb5EWBa5Flg0S4l7beRlsPHhxVhuJowR Drv59WWf1OFtlvLlB4GDLmjfPeiuoql63jj/3jDJBiyf0WgyHg4ZvXAUek2H3ykAbuoqY1jDtu4 CFBiNEyW1Tme2xASsPUL1yOR+fbwoSKUbQQstfWtzkrwNmUPMC9stM7xKF2wGWXSzBARGrvWD9q QbpXEewF6jsfcz4ioFI0VdIB/CLMhPrOWMMLSnHULR+BI8yQhZfpZXaRG7p4IUtphFSDHDjViLx 2saKKaCYA6qdOYjE7WnkuZVN8u28NKRhY0T2FuMzuq5CcikBO8zU7BMsQQjaYVXmhc1WJJWHfzc oE4vbRCxDNQMV+iXgBOUJN6fpt7lVQRj/P4pm1QlkCPKJAe3UQvZ8KhZH2KFtS54SSYpQUpr X-Authority-Analysis: v=2.4 cv=QMFoRhLL c=1 sm=1 tr=0 ts=6863d045 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=fKQzr7EGRj+VoE0XNsDNvQ==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=ovtazKSSlfofSAFZHdsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-01_02,2025-06-27_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 bulkscore=0 spamscore=0 adultscore=0 mlxlogscore=992 mlxscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 clxscore=1015 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507010076 On 01-Jul-25 14:08, Luo Jie wrote: > > > On 6/28/2025 12:27 AM, Konrad Dybcio wrote: >> On 6/27/25 2:09 PM, Luo Jie wrote: >>> NSS clock controller provides the clocks and resets to the networking >>> hardware blocks on the IPQ5424, such as PPE (Packet Process Engine) and >>> UNIPHY (PCS) blocks. >>> >>> Signed-off-by: Luo Jie >>> --- >>>   arch/arm64/boot/dts/qcom/ipq5424.dtsi | 30 ++++++++++++++++++++++++++++++ >>>   1 file changed, 30 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qcom/ipq5424.dtsi >>> index 2eea8a078595..eb4aa778269c 100644 >>> --- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi >>> @@ -730,6 +730,36 @@ frame@f42d000 { >>>               }; >>>           }; >>>   +        clock-controller@39b00000 { >>> +            compatible = "qcom,ipq5424-nsscc"; >>> +            reg = <0 0x39b00000 0 0x800>; >> >> size = 0x100_000 >> >> with that: >> >> Reviewed-by: Konrad Dybcio >> >> Konrad > > I initially thought that a block size of 0x800 would be sufficient, as > it covers the maximum address range needed for the clock configurations. > However, the NSS clock controller block actually occupies an address > range of 0x80000. I will update this to 0x80000 in the next version. > Thank you for your feedback. 0x80_000 excludes the wrapper region. Please mark it as the entire 0x100_000 that it occupies, no matter if there's anything in there Konrad