From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A90433A987B for ; Tue, 23 Jun 2026 10:35:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782210958; cv=none; b=e2zyLvH7fP6s94Nmha7/FmD1bMeDB4UpOxCQ6UwYkOp+wTBghc+bKUe4wrIza+ZwFardK9hc4BeKSUdIwjQ89Omqf0+D7vKfzV4RZ+NhoV8yDRoDgXNxlz1ctUUI/vVa5h/Z1mhCHSJ7V9D7RItpCTR+M3GacaJ1fLjRuwLewcU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782210958; c=relaxed/simple; bh=Ypjsb7ffJ3S8Nz8NiWmWk48MTEZVL19ewMrVARd79ls=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lAl1EoLAj5SXQu0Fi0/VQY5kXV1bWnkR10oEvVYZInkLr4zWFb5saI9wIY21cPAitkFUCdooTBLthZid21BzDmS/LKhoEkug0y22wi5xUdpGr74rkrRSVfg0NBFVaDgiIq793+4zYxP+YTW8GpyvajGdjNaRDROgtF4D2k9O3zc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pM37HVtD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ff2SJ802; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pM37HVtD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ff2SJ802" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65N6cmiL3564124 for ; Tue, 23 Jun 2026 10:35:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SvcgX2Mx7MHm/zXyDT7p8L5HhhnE84M1CKNqnPq4tA4=; b=pM37HVtD4mBBcS42 4uJ76/x9uB/65PmcWZ9Q+lGRITQLzL+mX8OxlAIRQ2FvG4cOu3JVUiSWgiac5KCb e7UVkGwnO2nU2Y+rcqv2KqARDn2LYmeBIwxNTNNcx7s19Clglc0aj3r/Qq84JqX/ R48GbaR7KZ4qksyZJEaz4IJpzM+oeiDzW+zpx08/z/hix4v0cNJZ6hwEsvcTfAq+ gv+/j0xvOdDZh6eyYy+tMHxqWY6uCo6TbfxpSe/yQ4fpYczDKqvYYT93fjgLNkNx QNbU/o6fQfEDR7kKuAQ2a2k//jrnyS9nXxl6KldiXYmGqsjuSY02s5kDXQwCLQlK iZ+rPQ== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ey5n44bbu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 10:35:56 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8de97bd8459so4126396d6.0 for ; Tue, 23 Jun 2026 03:35:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782210956; x=1782815756; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SvcgX2Mx7MHm/zXyDT7p8L5HhhnE84M1CKNqnPq4tA4=; b=ff2SJ802yoHWHmF3CQ0TV9IiA+1TiwrBfhfPGEeqD+uJvFi/m0pHvBTm7NdUzqGz3J bfgroN6pEQVBY5+E3F8ZhhIj4QLw5GquK5gnmuyNCwnSbOTkm16jjNfb3yXkeK+B/ZLY hNlPn3XImhZlLfvclZDMRaG25emn180cQViPxQZeyDeyBULDoAz3OJL520IWINQHkmFf PuPNvp5PbFY/QIBBsBPVqbnpqcVWKcDaIBP6NJmTG6ZJpFoXPxoH2PEbEQ6mXcQIAcgD MCqSwWeGGoegRyBqZoutgzbXChWlBupRP7zoN2XJxRwEv41yIuYaJ7sdK+UQagfsX1mE Nhrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782210956; x=1782815756; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SvcgX2Mx7MHm/zXyDT7p8L5HhhnE84M1CKNqnPq4tA4=; b=ZBi0f2X/la+o1NhN1X8TAIlJjGc+HmOb49e6H+NGu2TdBxpWfm4y+hvnCXg6XjQLDV 4FxbMfXZH+zqJUDjpdo0lI/qOasQlddXm5lk47ZURnEwiGA0WRT5/fKvdhFk2HiLrogI J7G85S6wtCwNyp2eYZ/LBAjb0cYDJZvHLUNA6L0eGNsMElU5ARnZm9YqKgJVWG0N0TJk epG9OTZQIGm8xvTjHP5m1Bqu/5mp9GybBHMalCGtITOfauWk8CB1eN6Uu+Db6S/Hkw+G o2vNI5KL3q2wo3aTfYvaoXnk4XnHURj0NRmh68lwbOz9gyG99SUUfArsjKZgGlnBhWWZ 0zNA== X-Forwarded-Encrypted: i=1; AFNElJ+PydPswAf50PHAaRZPPW01aYn5Ft2cJKhbTqbVXGIZci26TXlAyDrS4+1LtCekHcAtcfn3qo2XX2ZlfNc=@vger.kernel.org X-Gm-Message-State: AOJu0YxVYRSsiVeawBOkcR5HZWftfaIOy+Ihk00vhLlxfw+khR0cLgEe iE7mo0SB6hp7eZeNXxN0xW0wijI/kB+KQDWdIjVq0HKY/7BKCOeR2UQBJ8oOgMB/4qt7APVt9Da SbhCdscvPfjhZn4O8KZUJ4IeyFeIeezAB/m3TkR3AjvfZPhRn7smPqGDC1IujyBe3BVU= X-Gm-Gg: AfdE7cljjTul4rBbc1MWwNPAkBvKMY5/ODfE0KqQaXeon66d4me3pzDsYFUibJJiHWG qBjScGezWEfiF/B17OQEMiq8MUhAcdusObnI9cBIydd5EMZUr1ZmfLQhF7veqwzJvsZ+saXBEGA ECstgVzSIPYFRMqVdqrdfYoCbOw2VKZxEnY7T3P7UvKMTdQIPbKax5KO8s/8ctUkRKglZ5yd7Ex IQds6lVCJr1h0YkgEPHmY/HFRcim77IgaiO9mxbygJZVzCqDwVzWdOsrI/jSevyqCJNiUmFf0E6 TjASNxcQDGw9lbQiIsfhcXR818wU1ZrvoU+tpU0Sx4GW+fFzCg8IfjOs6qS6wiPfI+MIpSjFrUr P+dEKkuXw/XiwJQTOuoWRg5V2bA8q1DX0ePs= X-Received: by 2002:a05:620a:2b86:b0:916:10f6:765e with SMTP id af79cd13be357-921864c4a67mr1410030185a.6.1782210955861; Tue, 23 Jun 2026 03:35:55 -0700 (PDT) X-Received: by 2002:a05:620a:2b86:b0:916:10f6:765e with SMTP id af79cd13be357-921864c4a67mr1410027685a.6.1782210955461; Tue, 23 Jun 2026 03:35:55 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c61610bacsm505609466b.58.2026.06.23.03.35.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 03:35:53 -0700 (PDT) Message-ID: Date: Tue, 23 Jun 2026 12:35:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/3] ASoC: codecs: lpass-wsa-macro: Switch to PM clock framework for runtime PM To: Ajay Kumar Nandam , broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, srini@kernel.org Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260623071708.2822269-2-ajay.nandam@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260623071708.2822269-2-ajay.nandam@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA4NiBTYWx0ZWRfX/wP3G0NcaRa6 4rfbqiSZ2BaIyztyCHS6TYT4aonCEsQGUwMpz1ivEodSOW1xZyUblfIpK9CbACljPe+ds6wXapm ngBP64z5+NxVVnpBz86sq6VgBESntRs= X-Authority-Analysis: v=2.4 cv=R8Uz39RX c=1 sm=1 tr=0 ts=6a3a618c cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=t2ZNzEmchGV416yE2bcA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-ORIG-GUID: IJS0EjzUDWPo9VCTFsMANahorIXC2zeg X-Proofpoint-GUID: IJS0EjzUDWPo9VCTFsMANahorIXC2zeg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA4NiBTYWx0ZWRfX7O5rGcVHLfSl qWykjXXxqbGJsSHiXxx5pCPUQP1yyMvgrR8fmTsUI08iBuYON+dmY42u2C2zbJ55FftZ+UKZFGV 0wXzA7JLcOF+dXn2hf+eRbkFINWe2/VEXc0IHr49KUlOHwCqEfaEpcJfIVqYsWuCmTGeSUHthXS 58z6FOcTXiNXMpuAd+hfbD+Icm6CNAMkQClM5nTOzyx7NWVJqUdgFMMVvfYnlI/GaVt23a4dFFt s4q5/qpMVHVqQnLLsl8JnFFA4S8n4j1CaXg5plQzW8Tco+XZ+MRS8aIIfcqCrfz9hnTvoAOQ+lv +jAzJAnhUqRsKVEVf8LF5FJz2qlnVlCEegASELyW1aECsJnrwnsH6814hEpIBuC77thFKngzrb6 TBuCYlJqIMXpSNWgpJwvU8kt4kW81w+CCcT5DSVDKtwGjsoazO+kO8AEobfUku8We/rd1INVuw4 tt+fT+JJPCCBRlvI4ww== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230086 On 6/23/26 9:17 AM, Ajay Kumar Nandam wrote: > Convert the LPASS WSA macro codec driver to runtime PM clock management by > using the PM clock framework. > > Replace manual macro/dcodec/mclk/npl/fsgen clock toggling with PM clock > helpers and runtime PM callbacks. Keep the SWR gate runtime PM reference > from SWR clock enable until disable so autosuspend does not gate clocks > while SWR is still prepared. > > Set autosuspend delay to 100 ms so PM-clock-managed votes are dropped soon > after idle while still avoiding suspend/resume churn on short gaps. > > Add a PM_CLK dependency to SND_SOC_LPASS_WSA_MACRO since this patch > introduces PM clock APIs. > > Tighten error unwind by checking pm_runtime_put_sync_suspend() in probe and > by restoring regcache state if pm_clk_resume()/regcache_sync() fails. > > Signed-off-by: Ajay Kumar Nandam > --- [...] > static void wsa_macro_remove(struct platform_device *pdev) > { > - struct wsa_macro *wsa = dev_get_drvdata(&pdev->dev); > - > - clk_disable_unprepare(wsa->macro); > - clk_disable_unprepare(wsa->dcodec); > - clk_disable_unprepare(wsa->mclk); > - clk_disable_unprepare(wsa->npl); > - clk_disable_unprepare(wsa->fsgen); > } Can we just drop the now-empty function? Konrad