From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFC3FC433F5 for ; Wed, 6 Apr 2022 02:40:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1849823AbiDFCkp (ORCPT ); Tue, 5 Apr 2022 22:40:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1575927AbiDEXJo (ORCPT ); Tue, 5 Apr 2022 19:09:44 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 951E6433A8 for ; Tue, 5 Apr 2022 14:40:26 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id 7so642914pfu.13 for ; Tue, 05 Apr 2022 14:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=4qdFCpqXJlibMLMmOh+khRtYiv84b92yeP1UHSU4/XM=; b=qdb9FXkcJDsuO06gq+eT+kXK0a+6EAevKNYutHs1sHo02PgFcBzm4NidfGlv0TeZsk lAye9LJRnRUsM5PPn8JATtm9hvlOa0GVJ+6X0B3a4M1SQ+KhgtmV+NPD8o5BiU0Orf3j 4x8lnnEDrhHCxeZLy8J8nnqdwGAZ1Gkpc0hmy4N0mYsU4HLnwMA1ZKyqDPJfYwIcElbM 7jroAQC1AOR23AO9iP5KKLawgM9QJu+OXGHVrm9JPAawThONQEos0sZ/bSgJyD3kNm2+ JAN8hpJfKhrgAT5E0JbW0/hLVcIaB2Mu3QKE/gd62QVsfLvdVtNS4rOMAv/4BGuwjsGH CiGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=4qdFCpqXJlibMLMmOh+khRtYiv84b92yeP1UHSU4/XM=; b=AoGroQiuiFNOrMH1qicMLItnv09QO7nFPlOURLNcXTiuzrJGAFhOuHeWX6GXUbR9V5 r+mKeLrdj5TUGigaEarHbFaz+dxfHUhNxBqJTwKktKoa04u6/PqxDt54+3oVGxT5OKvn 5f4odKsi8D6r7wtxNqfDh9QcSGXx6hSFicoFTR5GdvDamtuEc7Br/rF0+t06nd1dZ6iX GJ2V89zjKt0DL7o/WInwrnyeX6QLKJkorC4nuSNiB2kdg2HKcAsw8co88szHdNQ/LcFg 4xIt4gqGOjh2P0C9Od+5x1ntwdmREF2L6EfOQAwK5CklcjVhzET9msFDAXjxe2BIWbDW H2aw== X-Gm-Message-State: AOAM532zhcIeI678Rfwh8Vn5baACg/aGlj8S6WNk1DTzURsNY2HbH+lX BZ7KoYgXIrMkc11Kz9zf/DE6rw== X-Google-Smtp-Source: ABdhPJwPwjfefI2JSh8SzZZVYV7Z0sOVeowJ14ZyTTisOzE7+UVYFaPwlmA1EkEbrCCUemK24q4jjg== X-Received: by 2002:a05:6a00:810:b0:4fa:e71f:7e40 with SMTP id m16-20020a056a00081000b004fae71f7e40mr5528326pfk.15.1649194817775; Tue, 05 Apr 2022 14:40:17 -0700 (PDT) Received: from [2620:15c:29:204:be3e:5e1c:99cc:513f] ([2620:15c:29:204:be3e:5e1c:99cc:513f]) by smtp.gmail.com with ESMTPSA id m7-20020a625807000000b004fe0a89f24fsm8117856pfb.112.2022.04.05.14.40.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 14:40:17 -0700 (PDT) Date: Tue, 5 Apr 2022 14:40:16 -0700 (PDT) From: David Rientjes To: Vlastimil Babka cc: Christoph Lameter , Joonsoo Kim , Pekka Enberg , Roman Gushchin , Andrew Morton , linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, Oliver Glitta , Marco Elver , Mike Rapoport , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Imran Khan Subject: Re: [PATCH v3 4/6] mm/slub: distinguish and print stack traces in debugfs files In-Reply-To: <20220404164112.18372-5-vbabka@suse.cz> Message-ID: References: <20220404164112.18372-1-vbabka@suse.cz> <20220404164112.18372-5-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 4 Apr 2022, Vlastimil Babka wrote: > From: Oliver Glitta > > Aggregate objects in slub cache by unique stack trace in addition to > caller address when producing contents of debugfs files alloc_traces and > free_traces in debugfs. Also add the stack traces to the debugfs output. > This makes it much more useful to e.g. debug memory leaks. > > Signed-off-by: Oliver Glitta > Signed-off-by: Vlastimil Babka > Reviewed-and-tested-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > --- > mm/slub.c | 28 ++++++++++++++++++++++++++-- > 1 file changed, 26 insertions(+), 2 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 98c1450c23f0..f2e550e1adf0 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -5064,6 +5064,7 @@ EXPORT_SYMBOL(validate_slab_cache); > */ > > struct location { > + depot_stack_handle_t handle; > unsigned long count; > unsigned long addr; > long long sum_time; > @@ -5116,9 +5117,13 @@ static int add_location(struct loc_track *t, struct kmem_cache *s, > { > long start, end, pos; > struct location *l; > - unsigned long caddr; > + unsigned long caddr, chandle; > unsigned long age = jiffies - track->when; > + depot_stack_handle_t handle = 0; > > +#ifdef CONFIG_STACKDEPOT > + handle = READ_ONCE(track->handle); > +#endif > start = -1; > end = t->count; > > @@ -5133,7 +5138,8 @@ static int add_location(struct loc_track *t, struct kmem_cache *s, > break; > > caddr = t->loc[pos].addr; > - if (track->addr == caddr) { > + chandle = t->loc[pos].handle; > + if ((track->addr == caddr) && (handle == chandle)) { > > l = &t->loc[pos]; > l->count++; > @@ -5158,6 +5164,8 @@ static int add_location(struct loc_track *t, struct kmem_cache *s, > > if (track->addr < caddr) > end = pos; > + else if (track->addr == caddr && handle < chandle) > + end = pos; > else > start = pos; > } Does this need to properly handle the case where handle == NULL? > @@ -5180,6 +5188,7 @@ static int add_location(struct loc_track *t, struct kmem_cache *s, > l->max_time = age; > l->min_pid = track->pid; > l->max_pid = track->pid; > + l->handle = handle; > cpumask_clear(to_cpumask(l->cpus)); > cpumask_set_cpu(track->cpu, to_cpumask(l->cpus)); > nodes_clear(l->nodes); > @@ -6089,6 +6098,21 @@ static int slab_debugfs_show(struct seq_file *seq, void *v) > seq_printf(seq, " nodes=%*pbl", > nodemask_pr_args(&l->nodes)); > > +#ifdef CONFIG_STACKDEPOT > + { > + depot_stack_handle_t handle; > + unsigned long *entries; > + unsigned int nr_entries, j; > + > + handle = READ_ONCE(l->handle); > + if (handle) { > + nr_entries = stack_depot_fetch(handle, &entries); > + seq_puts(seq, "\n"); > + for (j = 0; j < nr_entries; j++) > + seq_printf(seq, " %pS\n", (void *)entries[j]); > + } > + } > +#endif > seq_puts(seq, "\n"); > } > > -- > 2.35.1 > >