From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F874C07E8B for ; Fri, 28 Jul 2023 08:53:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234909AbjG1Ix1 (ORCPT ); Fri, 28 Jul 2023 04:53:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235201AbjG1Iwu (ORCPT ); Fri, 28 Jul 2023 04:52:50 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EA6CC2728; Fri, 28 Jul 2023 01:51:03 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BC5852F4; Fri, 28 Jul 2023 01:51:46 -0700 (PDT) Received: from [10.57.0.116] (unknown [10.57.0.116]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A1BF53F67D; Fri, 28 Jul 2023 01:51:00 -0700 (PDT) Message-ID: Date: Fri, 28 Jul 2023 09:50:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v1 4/6] perf build: Disable fewer flex warnings Content-Language: en-US To: Ian Rogers References: <20230728064917.767761-1-irogers@google.com> <20230728064917.767761-5-irogers@google.com> Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Nathan Chancellor , Nick Desaulniers , Tom Rix , Kan Liang , Eduard Zingerman , Andrii Nakryiko , Gaosheng Cui , Rob Herring , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, llvm@lists.linux.dev From: James Clark In-Reply-To: <20230728064917.767761-5-irogers@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/07/2023 07:49, Ian Rogers wrote: > If flex is version 2.6.4, reduce the number of flex C warnings > disabled. Earlier flex versions have all C warnings disabled. Hi Ian, I get a build error with either this one or the bison warning change: $ make LLVM=1 -C tools/perf NO_BPF_SKEL=1 DEBUG=1 util/pmu-bison.c:855:9: error: variable 'perf_pmu_nerrs' set but not used [-Werror,-Wunused-but-set-variable] int yynerrs = 0; I tried a clean build which normally fixes these kind of bison errors. Let me know if you need any version info. James > > Signed-off-by: Ian Rogers > --- > tools/perf/util/Build | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/tools/perf/util/Build b/tools/perf/util/Build > index 96f4ea1d45c5..32239c4b0393 100644 > --- a/tools/perf/util/Build > +++ b/tools/perf/util/Build > @@ -279,13 +279,9 @@ $(OUTPUT)util/bpf-filter-bison.c $(OUTPUT)util/bpf-filter-bison.h: util/bpf-filt > $(Q)$(call echo-cmd,bison)$(BISON) -v $< -d $(PARSER_DEBUG_BISON) $(BISON_FILE_PREFIX_MAP) \ > -o $(OUTPUT)util/bpf-filter-bison.c -p perf_bpf_filter_ > > -FLEX_GE_26 := $(shell expr $(shell $(FLEX) --version | sed -e 's/flex \([0-9]\+\).\([0-9]\+\)/\1\2/g') \>\= 26) > -ifeq ($(FLEX_GE_26),1) > - flex_flags := -Wno-switch-enum -Wno-switch-default -Wno-unused-function -Wno-redundant-decls -Wno-sign-compare -Wno-unused-parameter -Wno-missing-prototypes -Wno-missing-declarations > - CC_HASNT_MISLEADING_INDENTATION := $(shell echo "int main(void) { return 0 }" | $(CC) -Werror -Wno-misleading-indentation -o /dev/null -xc - 2>&1 | grep -q -- -Wno-misleading-indentation ; echo $$?) > - ifeq ($(CC_HASNT_MISLEADING_INDENTATION), 1) > - flex_flags += -Wno-misleading-indentation > - endif > +FLEX_GE_264 := $(shell expr $(shell $(FLEX) --version | sed -e 's/flex \([0-9]\+\).\([0-9]\+\).\([0-9]\+\)/\1\2\3/g') \>\= 264) > +ifeq ($(FLEX_GE_264),1) > + flex_flags := -Wno-redundant-decls -Wno-switch-default -Wno-unused-function > else > flex_flags := -w > endif