From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 889F8C3DA7A for ; Mon, 2 Jan 2023 16:32:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236317AbjABQca (ORCPT ); Mon, 2 Jan 2023 11:32:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232596AbjABQc0 (ORCPT ); Mon, 2 Jan 2023 11:32:26 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A871F2641 for ; Mon, 2 Jan 2023 08:32:25 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id bt23so25555163lfb.5 for ; Mon, 02 Jan 2023 08:32:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OPOWYK4xS+6xhzOdhfTnsSnUcVxUYMBnV8hiXVR43SI=; b=WuNHynlhNUkJUcD6KxjstzrRlxBGV8jbuBJ/hrag17I5q4FZ19LDt1kUasU+Mf/ow1 JBdFdf/Q0EPoES9VCm0vib2w7JjQ6b0vOTXDcL9B89agvmmRsdc/EE+vKc/H2Lep6lT7 kvujpwUNElUfG8MRBS8uQJjwjOD3nhMAo9M0FcLNOllZ8+YQVMk5PaCE3nKmji6OVgcG IIz+6L5GswHwQziHEeMp6UDveSxrLnfs0llc1Zs1AvixoQrFZYbEhPSGKbxY3n135fNu jgyNdng/nhQCdHUrDtQKR65iViyWju50338n/pJMMU4qhyrO6wxw1rk0Q8wo/7AJuJQa yEkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OPOWYK4xS+6xhzOdhfTnsSnUcVxUYMBnV8hiXVR43SI=; b=pGWT+2h5oOWybQfxD5PY+s0cBei+6VpLaLTpnqAIic+v6jiNSxcicCrpX3f64LZLVf ACUaVogVeOn3YUypcoJjw6HCtXHvxWbA+LyzM1Iszzvs2a4wxgMnxXq5T5RqQzyiSZeK fp5Lf40e1MapnUZs9XBKuGaa0mMsJu7mVvfkjAF8dZ04UF+BrQ4bNqsrsGlfg/34Kist hGnzVHxqNcwuhShX/H60TxJF4E7X3+mQ2uMkS1QH/Dz/souwNNQT+UhYOPRpEKig/HeP frc5gdPYCCOCNePyHocdznpVddOPMFdRhrXAOMlDTaala/CpxwbTNmLsKKuPwGl0tK2+ SsnA== X-Gm-Message-State: AFqh2koYL5YEYWrtyzbN3i63/Kjx459GPI0PfpHBFa3784By2epbMcTl W1a0guU/ifcpPoZRi04/Pe0Xkg== X-Google-Smtp-Source: AMrXdXtWnVOJrl54acwW1/P+lvWqyeGREQQIrliL5JrxuI2mDuRvgOBvBPJG9vCCGvebf+wH1RlFEw== X-Received: by 2002:ac2:5fcf:0:b0:4b5:5f97:6a16 with SMTP id q15-20020ac25fcf000000b004b55f976a16mr11197018lfg.43.1672677144056; Mon, 02 Jan 2023 08:32:24 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id w12-20020a05651234cc00b0047f7722b73csm4481991lfr.142.2023.01.02.08.32.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Jan 2023 08:32:23 -0800 (PST) Message-ID: Date: Mon, 2 Jan 2023 17:32:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v4 13/13] dt-bindings: mediatek: mt8188: add mt8188-mt6359 document Content-Language: en-US To: Trevor Wu , broonie@kernel.org, lgirdwood@gmail.com, tiwai@suse.com, perex@perex.cz, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, p.zabel@pengutronix.de Cc: angelogioacchino.delregno@collabora.com, Project_Global_Chrome_Upstream_Group@mediatek.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20221230055443.16024-1-trevor.wu@mediatek.com> <20221230055443.16024-14-trevor.wu@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20221230055443.16024-14-trevor.wu@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/12/2022 06:54, Trevor Wu wrote: > Add document for mt8188 board with mt6359. Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). > > Signed-off-by: Trevor Wu > --- > .../sound/mediatek,mt8188-mt6359.yaml | 93 +++++++++++++++++++ > 1 file changed, 93 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > new file mode 100644 > index 000000000000..5754c1d460db > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > @@ -0,0 +1,93 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mediatek,mt8188-mt6359.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT8188 ASoC sound card > + > +maintainers: > + - Trevor Wu > + > +properties: > + compatible: > + const: mediatek,mt8188-mt6359-evb > + > + model: > + $ref: /schemas/types.yaml#/definitions/string > + description: User specified audio sound card name > + > + audio-routing: > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array > + description: > + A list of the connections between audio components. Each entry is a > + sink/source pair of strings. Valid names could be the input or output > + widgets of audio components, power supplies, MicBias of codec and the > + software switch. > + > + mediatek,platform: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of MT8188 ASoC platform. > + > +patternProperties: > + "^dai-link-[0-9]+$": > + type: object On this level: additionalProperties: false > + description: | > + Container for dai-link level properties and CODEC sub-nodes. > + > + properties: > + dai-link-name: Instead: link-name > + description: | > + This property corresponds to the name of the BE dai-link to which > + we are going to update parameters in this node. > + items: > + enum: > + - ADDA_BE > + - DPTX_BE > + - ETDM1_IN_BE > + - ETDM2_IN_BE > + - ETDM1_OUT_BE > + - ETDM2_OUT_BE > + - ETDM3_OUT_BE > + - PCM1_BE > + > + codec: > + description: Holds subnode which indicates codec dai. > + type: object > + additionalProperties: false > + properties: > + sound-dai: > + minItems: 1 > + maxItems: 2 required sound-dai > + > + required: > + - dai-link-name > + - codec > + > +additionalProperties: false > + > +required: > + - compatible > + - mediatek,platform > + Your example looks pretty straightforward. Maybe you can use simple-card.yaml? Best regards, Krzysztof