From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C6804734DF for ; Tue, 4 Aug 2026 16:19:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785860367; cv=none; b=brXt7c67lnFbqsIEfBGmqGGvPhGnVl2+y290eWNi1ZpnTyPXUW/JoDCLldwIOb2i80+NVxfmknkSbBW9IycD+wLlqwWnu/UQkKALFuiEpapeinU9/j5OlL9s9amcaHc2d2w9V1d+Dzo7IvoT8lwITy2eUEC7PwDvVgm+BPrgqeE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785860367; c=relaxed/simple; bh=s9KGN+Npj+/jt/XeT4APQ/Xfb0isvyz2svaPnFg8CME=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Kvi6lsyNmn13aQeOtyQ8wi9ibzHgBMyXyZDEDnPSnqhMcIAhxqHzctrLuNu+kROZlmJHveDQRwZxrX65GtcUyE74YvGJlQg4Qtdy6SQE4N6CfmJbax/DzW3r9yhm1sPGAC51DcEIyT6sk+Y252isMPRFq8xJ8VjecUeAFBnjZn8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AISk3eFR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eAbJ1JLy; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AISk3eFR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eAbJ1JLy" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 674G537J4072011 for ; Tue, 4 Aug 2026 16:19:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Cy9NLrazGLWbthP/NwNd2SO8Fs1LZZi9kIca2k/Uvg0=; b=AISk3eFRz2n+s20Z f5d+waNlYStCZrGEdORMPxB3wOghe9C48RLqHlrbjY7n1UtxXOkhWXnlbyVQ0hx/ Zf6tBJJgtek2KNVFKVS91pRW5bsm0WasosdRSaMlwHKKSzoXB81pwFyagc+/f0r/ k3+04yao7MULZMy1Zk/IG1yjxFEmjqrRTrqKuPVPj4ifUFKcMdRaWcJCmbnxCV0J jmeZQjqAkXTklWi2pL1NpR+mN6Mzxd1KEOhjjNw+/Q57fzKJQu+dNoIDmWKi7S8a KLDMmgWU+rEliU7OZLgPR7JECmxdpmMlJduro1oBzcnFIqEIhV8uthPCUg7UmAKB +5wgDQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fuk9u02gw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 04 Aug 2026 16:19:25 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cfa55c9430so357685ad.0 for ; Tue, 04 Aug 2026 09:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785860365; x=1786465165; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Cy9NLrazGLWbthP/NwNd2SO8Fs1LZZi9kIca2k/Uvg0=; b=eAbJ1JLy0ybrlMPEeM5bm/bfB4vnMT09ufOkOJ2vbr2ccERAoYJ1JIpKZG+C0BoG7j sfok088I0qDDlj+3K0FT5UQvpdSoJTccWyoTnAe+PHcC/eoR8GMNifSKfqoY0/PER0w6 x2lvKY3SchcXlqswtGk2cgq228R70iWf7puxdp/4rotFoHdolMRwHeEq0lwy8qPBgpJ7 izMWzC8ltKVumn3y1qRsQf9fFVSfzostuegrWcKoI0plG+rS2g3m0pG1Y/jEtftFePVZ RLUe/fXh2nCADWm9MpkiloGkY/OxlLtmHGj9TmFadp/7kMUJSjqqRxpmV7Yn2VSR5all 6xbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785860365; x=1786465165; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Cy9NLrazGLWbthP/NwNd2SO8Fs1LZZi9kIca2k/Uvg0=; b=MruhCtRpAhspPo/HsNfWIwA1WLtH0WYMjH0QmG1yrYPQKEJZSD/RNc9Ooj884WfgMO AyvNWT4gzvWtRBR8Yr3+mdtGZUQrtJOvgxz1ExRpS1xDEsQTdvnDRU3sNeyi0dZAT2f+ 4kg0r463IG9i2WpkuuEA65Cf7qCVUzWASXmGPGKfVyUZlOCcjaHGmMaTuCv5+QnIqBZZ Jmd5jY1f7RVo6yWbZSALSYugLsWFocPyGc3fXYIoNkZRZYHQEfk1LyVcj1DfZnR75oan 0WtQNPyFqjFLeLBCGi0LDVUgs45zVbQjtGblMgr6Hb9Sm9koPD7z+DbwtvHszLrTPBSe aGEA== X-Forwarded-Encrypted: i=1; AHgh+Row7APSjnVVA/f9+Fh1yOZZZdI6TJKeqUARMyeFJTSQt31jKBtub6d52ewSx9AtWj2sxOMMwXYMQ9f3fNg=@vger.kernel.org X-Gm-Message-State: AOJu0Yyyvjq9On+EtWHKl3gBh3g22UMQPf0SzIBc6vHKpU+Q1WwKwWcR MZEdRoNrLi1nMDAwSdJmEJpFtpNDgmFfaLXIveZ7hiYvkG9SXg/m+Yk67nrlUkI58r1wmIdUfq9 ab++o8cCxBr1VfpRrr3t4U8PcrYHGtGRSCMJSoUktSFPevfSpWxcFcQzwyR9hB/rSppo= X-Gm-Gg: AR+sD10sFyrSm00Zys1gw/wPNpQz0s3H0tUQJPJcLoG+/FSRDbpZBYeRI1DUF7bRt0/ GBK9j/I0SElpCenTlZdEjWupa3t77ZeudqugKqr54tsVN/aHKgTmyZ3RsYzwDv9lgJkk4YO0R6g At6213/P2tRE4cVs+yBUoiw/mH/c9/Fy3MGb543hxUPw2ZOO31xazIUbFFwZdVZGVW+DpCOnC8i QwQx6V1PEKvIugYewUN6K5tj7yehHUrKfAd9ikxesXjH4tvLU2Zw2TSBt+buX8KTVUNkug1CKJQ IogGnHopw0uWqU2+5Cf9p1RcqFOeHiS+1kByltNwNDrPYwF8rSKCSCFJE2xZttY6kZydUl3+gAl oduRYwOEL2Xl1j7P1kRZ3lq+kXO5nOUXimgiySA== X-Received: by 2002:a17:903:3d0d:b0:2cb:2b53:559f with SMTP id d9443c01a7336-2d0523be798mr164365655ad.35.1785860364559; Tue, 04 Aug 2026 09:19:24 -0700 (PDT) X-Received: by 2002:a17:903:3d0d:b0:2cb:2b53:559f with SMTP id d9443c01a7336-2d0523be798mr164364755ad.35.1785860364006; Tue, 04 Aug 2026 09:19:24 -0700 (PDT) Received: from [192.168.0.116] ([124.123.146.251]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315867a68fdsm10228148eec.25.2026.08.04.09.19.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 09:19:23 -0700 (PDT) Message-ID: Date: Tue, 4 Aug 2026 21:49:18 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: shikra: Add qcom,vmid to BAM-DMA node To: Bjorn Andersson Cc: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, chris.lew@oss.qualcomm.com, Deepak Kumar Singh References: <20260714-b4-qcom-shikra-dts-bam-dmux-vmid-ext-v1-1-5b19da8d7735@oss.qualcomm.com> Content-Language: en-US From: Vishnu Santhosh In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=NInlPU6g c=1 sm=1 tr=0 ts=6a72110d cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=K/78aEDNEn2Q/Yuv7mVN5Q==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=Df_5af0DindZ04If37sA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: 8EfFRFw-onGPDCU1zWpChZHgfxAE0two X-Proofpoint-Spam-Info: AW1haW4tMjYwODA0MDEzMSBTYWx0ZWRfXzg0CiBezEjYn q/x4ECaviQVJZDIVIafa6/vFSqKgjhICdHf8yE1nxwU/1ynsB0HcelX+a0uszPFSvufzP0lHfQn E+01T8tdVv5ZyYADJ+Bz+encVqMj0yU= X-Proofpoint-ORIG-GUID: 8EfFRFw-onGPDCU1zWpChZHgfxAE0two X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA0MDEzMSBTYWx0ZWRfX1JkxlI/cGSx/ VbFIOVQTHZZzZWIIsOnx0w7SednyVQmm+HiBePdl7w5ZGnyN9ChKSr7k1BzQsLILfSDZzvmoDtC tYoaNiI0Vlp4B6EUL9qzMC0FL6iBxp6Xaq34nBGhXcFBI3lEMQneItJHSE8D6CAHs0bE/dvD6CP CarVdzWtiRFvHkeRaeANq74YUtxCiaYNFuGVWNB157pFibfby1m/+5DdSbJ5LYF0ZN8aOIMSjSf SDxTsdSCS68cLhe6CkmZYYr0xMa+Ynr63flkTizXyZROEYkGdVPAv2suwgE7Vt0vXaSpidZjP0G k3GaIaf+FP0OYqagIGIXOugyOGlnDOuPMGKxU6vvyyLMcSrj3DDW0kNPrOGdSD5jVxlH4svzTgo moQXQTxOpTihtAORFpXXoJEVm2nX74tTT8KHaiFvRGdmJ70T3KbK/gOe2Nif1b31KJuW9aq9sYV QvSKLGIONUkqauZGBMw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-04_03,2026-08-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 suspectscore=0 clxscore=1015 adultscore=0 malwarescore=0 spamscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608040131 On 31-07-2026 02:49 am, Bjorn Andersson wrote: > On Tue, Jul 14, 2026 at 02:01:53PM +0530, Vishnu Santhosh wrote: >> On the Qualcomm Shikra SoC the mDSP (VMID 43 / QCOM_SCM_VMID_NAV) is >> the AXI master for BAM descriptor FIFO accesses. The XPU enforces >> per-region access control; without an SCM assignment granting NAV >> access, the first DMA transfer triggers an XPU violation. >> > I'm a bit puzzled about your plan here. > > You posted this on July 14th, that's 3 days after I asked you to rebase > patch [1]. This patch literally says that [1] is broken and untested. The XPU violation itself wasn't visible against the base bam-dmux enablement alone. It only showed up once the access-control policy was enabled, which happened to land close to when [1] was posted upstream. That's why this series followed so soon after. >> Add qcom,vmid = to the bam_dmux_dma controller >> node so bam_dma SCM-assigns each channel descriptor FIFO at >> allocation. BAM-DMUX itself is a singleton and no longer needs a DT >> property for its destination VMID: the driver now selects >> QCOM_SCM_VMID_NAV internally via the qcom,shikra-bam-dmux compatible's >> match data. >> >> Co-developed-by: Deepak Kumar Singh >> Signed-off-by: Deepak Kumar Singh >> Signed-off-by: Vishnu Santhosh >> --- >> This depends on three separate series: >> >> - "arm64: dts: qcom: shikra: Add BAM-DMUX support" [1], which adds >> the bam_dmux and bam_dmux_dma nodes this series modifies. >> - "arm64: dts: qcom: Extend Shikra device tree with CDSP, LPAICP, >> MPSS remoteproc PAS and peripherals" [2], which is still under >> review and adds the "remoteproc_mpss" node that [1] attaches >> bam_dmux to. >> - "dt-bindings: dma: qcom,bam-dma: Add optional qcom,vmid property" [3] >> and "dt-bindings: net: qcom,bam-dmux: Add qcom,shikra-bam-dmux >> compatible" [4], which introduce the qcom,shikra-bam-dma and >> qcom,shikra-bam-dmux compatibles this series relies on for the >> qcom,vmid property to validate under dt-schema. >> >> [1] https://lore.kernel.org/all/20260711-qcom-shikra-dts-bam-dmux-v2-1-d5b33ee32138@oss.qualcomm.com/ > Changes was requested on July 11th > >> [2] https://lore.kernel.org/all/20260714-shikra-dt-m1-v6-0-bee265d3499b@oss.qualcomm.com/ > Changes was requested on July 13th > >> [3] https://lore.kernel.org/all/20260714-qcom-bam-dma-vmid-ext-v1-0-cef87c57b7dc@oss.qualcomm.com/ >> [4] https://lore.kernel.org/all/20260714-qcom-bam-dmux-vmid-ext-v1-0-3f29da7cca76@oss.qualcomm.com/ > Might be wrong on the timezones, but I think you had change requests in > your inbox by the time you posted this series. > > > What do you want me to do with this patch? Understood the mistake. I should have waited for [1]'s dependencies to land, then folded this vmid change into [1] itself. I will do that and post these changes as [1]'s next revision. Please drop this patch. > >> --- >> arch/arm64/boot/dts/qcom/shikra.dtsi | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi >> index 246ea74d1fb1e293f0428d342301886dc52cb179..cb824da1757921edf0befe5480bf489ee1d8c727 100644 >> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi >> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi >> @@ -5,6 +5,7 @@ >> >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -1888,7 +1889,7 @@ glink-edge { >> }; >> >> bam_dmux: bam-dmux { >> - compatible = "qcom,bam-dmux"; >> + compatible = "qcom,shikra-bam-dmux", "qcom,bam-dmux"; >> >> interrupts-extended = <&modem_smsm 1 IRQ_TYPE_EDGE_BOTH>, >> <&modem_smsm 11 IRQ_TYPE_EDGE_BOTH>; >> @@ -2030,7 +2031,7 @@ glink-edge { >> }; >> >> bam_dmux_dma: dma-controller@6044000 { >> - compatible = "qcom,bam-v1.7.0"; >> + compatible = "qcom,shikra-bam-dma", "qcom,bam-v1.7.0"; >> reg = <0x0 0x06044000 0x0 0x19000>; >> interrupts = ; >> #dma-cells = <1>; >> @@ -2039,6 +2040,7 @@ bam_dmux_dma: dma-controller@6044000 { >> num-channels = <6>; >> qcom,num-ees = <1>; >> qcom,powered-remotely; >> + qcom,vmid = ; >> }; >> >> sram@c11e000 { >> >> --- >> base-commit: 3b029c035b34bbc693405ddf759f0e9b920c27f1 >> change-id: 20260714-b4-qcom-shikra-dts-bam-dmux-vmid-ext-1b4f793e035c >> prerequisite-change-id: 20260525-shikra-dt-m1-082dec382e7f:v6 >> prerequisite-patch-id: 48ecd66c06c4fad81f91283c26ec57d95bbde29d >> prerequisite-patch-id: 7d92e5a301d09616840e54dc9e4a81f30a64383c >> prerequisite-patch-id: be1a16f53e23dd5ab90210a056c9da3559c6186d >> prerequisite-patch-id: 3eff04500c55100c763aeac1f1f8c5768d500500 >> prerequisite-patch-id: ab22c5fdb2fa65b78ffef76bbe4459c8d5ffe7b2 >> prerequisite-patch-id: cb24efedb648271ef5c60ace96e2366d89254e8f >> prerequisite-patch-id: 8be7df0395c5847a988c7e814c7db878b5932b11 >> prerequisite-patch-id: 0510992d022cef7317b6efee6765ac78c0225356 >> prerequisite-patch-id: de4327fcbe81f92a337f429b74e8220969a5b79f >> prerequisite-patch-id: e13435365cba0b6ecfcea6d9e5ab72838fba23a7 >> prerequisite-patch-id: 90f78668eb969c16ed8c2485d75a60a183fc4b8e >> prerequisite-change-id: 20260603-qcom-shikra-dts-bam-dmux-7fdcbb6fb662:v2 >> prerequisite-patch-id: 59bb0a7828e41f546f734f127d81da83c0adcda9 >> prerequisite-patch-id: 197da6bcb15cadc47869dba88c8020987b25c335 >> prerequisite-patch-id: 8ec9c1eb03f052ae232ed54117abed38672c23f6 >> prerequisite-patch-id: 350db4f4bcdfc0fad9ed57cd5b1723f85ad44f5d >> prerequisite-patch-id: b5d7f75df02fde56181f576a936baf09d0a72276 >> prerequisite-patch-id: 3ce52e07ae57139c2e2b71a29ed7d7250f6fcc87 >> prerequisite-patch-id: 3a689e8dda5fd2755b689d94d095806b3f2e6eed >> prerequisite-patch-id: ac83151a889855498d36288ddd36216d451340c8 >> prerequisite-patch-id: 2357cac636e019eaf14d6a493a1c72bca56fe405 >> prerequisite-patch-id: 2885f299e711582da312ca9d13983d296a3dd5dc >> prerequisite-patch-id: 91af5f3c01e766a53ce8de69aa21847a2d6bbbf8 >> prerequisite-patch-id: 48ecd66c06c4fad81f91283c26ec57d95bbde29d >> prerequisite-patch-id: 7d92e5a301d09616840e54dc9e4a81f30a64383c >> prerequisite-patch-id: be1a16f53e23dd5ab90210a056c9da3559c6186d >> prerequisite-patch-id: 3eff04500c55100c763aeac1f1f8c5768d500500 >> prerequisite-patch-id: ab22c5fdb2fa65b78ffef76bbe4459c8d5ffe7b2 >> prerequisite-patch-id: cb24efedb648271ef5c60ace96e2366d89254e8f >> prerequisite-patch-id: 8be7df0395c5847a988c7e814c7db878b5932b11 >> prerequisite-patch-id: 0510992d022cef7317b6efee6765ac78c0225356 >> prerequisite-patch-id: de4327fcbe81f92a337f429b74e8220969a5b79f >> prerequisite-patch-id: 968bffc36646412f8289b917f37e762a4297bcc8 >> prerequisite-patch-id: 35944403bd4480caad12657342da15ea71c6afbd >> prerequisite-patch-id: 65b485474126f4a2ab3f69a0b8e146b3b04c2c1a >> prerequisite-change-id: 20260714-qcom-bam-dma-vmid-ext-8a3bd3c5c00e:v1 >> prerequisite-patch-id: b61d337d6c8fc4b20bff5a057b3f3335d89c57c3 >> prerequisite-patch-id: 91d3d344ec3e35ef7a3cec0a2ef90fefaf10a039 >> prerequisite-patch-id: 9e23abde2db60a3ad3a00d060bfb91f68c0aa798 >> prerequisite-patch-id: 4fa3350725e5b9d442247756d2b51d03f99b86bc > So this patch has almost been tested upstream, only 38 patches delta? > > Regards, > Bjorn Understood. That's a lot of unlanded prerequisites to stack a patch on. I'll be mindful next time. Thanks, Vishnu > >> Best regards, >> -- >> Vishnu Santhosh >>