From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F8A52D97A3 for ; Wed, 30 Jul 2025 14:28:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753885723; cv=none; b=dv/jSNlj07V4s6/YNOTOAP3XRd0R7OOkizObd9ZpItce1i1BZKJbM0jBMWRt61nrG5PL+BzhyRyheUOf3EMBXS/lpbd0i1kTPbFc8myAkXPLNuHDuWRbe8FXm1JVrdC8svV/c8D+vZCnYYwVof4yKM87zhxgset757C7dnWwJoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753885723; c=relaxed/simple; bh=STW90s3KQt7qz/SZuFNEPaZC4WtWeH2+//zEppDSySQ=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=UXRx3cZws5Ro+3cea8x+coeF7aV0Qsdhb+41JtG5zlhfyPKEmo2BOVIHg8MBxjKEcYJS9iiKc/r1rdSJmWcWoTxYkyqFpoH7oWaNws0gocnMGTomOCLIgEMjnXfBSvGa9Kj0NoJyWtycW20MFtyv8neCecF6FBVMnUDD3AOrmJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=G38OmcXE; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="G38OmcXE" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-451d3f72391so62721165e9.3 for ; Wed, 30 Jul 2025 07:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1753885720; x=1754490520; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=VYfKKkomyIJnTe7xVnvfHYaX8X0anbFk9RY4Fhlx8c8=; b=G38OmcXE8kN1awNd7uUHzT7pzMkYCd442ONg1KcWs8nGX8kG4GZev42dwoZEBUZ9+E Djt0cCT4rfpfJgFLPSdF570rFQlJRmSTMImxEUzys5i5NP3heD/zfXjj/sOwg2CzaPsl qdYuSyL484cHYl8hz3hHs3n52A9E7N1iIPLZaeq2AAZMEbIV6D4L4IdLd6N1bMCTOqwh Rkc99kssrngqfmIQnuExS4t5XpE6yKdVeYQxFBXSGHBZlI5GSECpYWipfhGRlZ5Y0ayp mGxgzCGAOJUrWkkrT0o4snzYHedARDsxdIGT5vjJHRnUAqML33YKY7R1JApgv8GBJbk+ 12mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753885720; x=1754490520; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VYfKKkomyIJnTe7xVnvfHYaX8X0anbFk9RY4Fhlx8c8=; b=lH/FG+CXnN0uWrq4FEOjKbDcAerMM3LDU0lqfNCvqxkrx6R1rAEM3Flk5VT5tTNKa3 0Z4Irc+OExPgBdtGmVdSvDHe9nKAI1yg5OWooHQs0LkuA8oufmiIRN10ixaaz2M4UgoL p+oBOL/QaIP1DmDF/H0owqKanQExRAIkNgVSQrXKMqSC3kw72IFhrk5dGVjVCdTiWrYU 6XTpOjkTNltj0Wxc6uPsVYtAwtK9JGMOsDVbftP335an4TPF4kfI0+Yt5dKJunleyfWy 7Bw/xaLuFjMUWuH/zfJRTuCTvQORvR7QaM2bcyq7031NxHpyy6S62ChV/JkxbRPP7c4J I9yA== X-Forwarded-Encrypted: i=1; AJvYcCUSerHXuueW6MQzMtiVwPWvsEEfHurWRc6OEH6jBc6OqKDmqGcDnJc/UPDt5fnBANkk6xCsfH9P4odyehA=@vger.kernel.org X-Gm-Message-State: AOJu0YwN5rSdONwoRcWi0JVJe8L7HqOJQrXkg9Ch4M3Zperm8T3Xyrht at82pfh6ybyZBDHlfhcIzF71MpvnFPSKI2GrvJxvPe75llLP6m2GQP7icg0mHHA45f9Qak+ofY+ Os41J X-Gm-Gg: ASbGncuhu+hAEik4e882MD3quO0G/jikGHwkU1Pv6b5oS0RKRIUqUv4opMrSCBXuTSk QIHqn7nfaxvnWEvIxlPi3t8YBmR7zc0nvDGHlYL2DTAEln8p/Vq4i1MuQ9SqKQSh/rEy+Yo3uU8 dv1GUu1bSc8wmVjRMC10NZFiyKWaQjOaw0wXq9h3+ZrOeyJkRMJezFU6ci3lR/wULF1k8J+LLIA tkvUg9lVZPWpD9noFI33YAz4yyXZlhO6e1w1Lpp6w+9J8kLs0e8m9/CN0TpEQ5WN/j/J5JAgB+F JdBtWIhRifG6+hRcEgGi/ygn/NSiQoyyfMZNql1SuOKXNKRxClN6sc3AJexRoGE8ofDS7EcnJEM K33vqdWOn/03wS1YdWm/3PTuCe7iw1Zfp1kHqATT6UQwWOmhVPhyPWkrQjLAZi1oHk2R3/cKQnV 1WbyOFMVY+Iw== X-Google-Smtp-Source: AGHT+IFkiongaw+716eYscwAn2hud6KDZWIRmXrEPYkuiIscgZfHi99ALGqutk4bxdBQdOBbpGHfUQ== X-Received: by 2002:a5d:584c:0:b0:3b7:6828:5f78 with SMTP id ffacd0b85a97d-3b794fe4f79mr2697229f8f.4.1753885720284; Wed, 30 Jul 2025 07:28:40 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:5cc9:639a:a021:88ef? ([2a01:e0a:3d9:2080:5cc9:639a:a021:88ef]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-458953755d1sm28427255e9.11.2025.07.30.07.28.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Jul 2025 07:28:39 -0700 (PDT) Message-ID: Date: Wed, 30 Jul 2025 16:28:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH] arm64: dts: qcom: sm8650: Add ACD levels for GPU To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250729-topic-sm8650-upstream-gpu-acd-level-v1-1-258090038a41@linaro.org> <63da4872-2365-40eb-9b2e-d3393ddd9b68@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <63da4872-2365-40eb-9b2e-d3393ddd9b68@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30/07/2025 12:00, Konrad Dybcio wrote: > On 7/29/25 4:40 PM, Neil Armstrong wrote: >> Update GPU node to include acd level values. >> >> Signed-off-by: Neil Armstrong >> --- >> arch/arm64/boot/dts/qcom/sm8650.dtsi | 14 +++++++++++++- >> 1 file changed, 13 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi >> index 495ea9bfd008500dd2c9f46ceca94cf5f972beca..4cd933219ce008bd1c603c87778e210b6332e29c 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi >> @@ -4127,72 +4127,84 @@ zap-shader { >> >> /* Speedbin needs more work on A740+, keep only lower freqs */ >> gpu_opp_table: opp-table { >> - compatible = "operating-points-v2"; >> + compatible = "operating-points-v2-adreno", >> + "operating-points-v2"; >> >> opp-231000000 { >> opp-hz = /bits/ 64 <231000000>; >> opp-level = ; >> opp-peak-kBps = <2136718>; >> + qcom,opp-acd-level = <0xc82f5ffd>; >> }; >> >> opp-310000000 { >> opp-hz = /bits/ 64 <310000000>; >> opp-level = ; >> opp-peak-kBps = <2136718>; >> + qcom,opp-acd-level = <0xc82c5ffd>; >> }; > > https://git.codelinaro.org/clo/la/platform/vendor/qcom/opensource/graphics-devicetree/-/blob/gfx-devicetree-oss.lnx.1.0.r1-rel/gpu/pineapple-v2-gpu-pwrlevels.dtsi?ref_type=heads > > doesn't set ACD for D1/D2 > >> >> opp-366000000 { >> opp-hz = /bits/ 64 <366000000>; >> opp-level = ; >> opp-peak-kBps = <6074218>; >> + qcom,opp-acd-level = <0xc02e5ffd>; > > And other values differ too > > What release did you grab these from? A much more recent non-public release with different gpu-pwrlevels for different SKU codes, all sets ACDs for D1/D2, and the ACD values are: #define ACD_LEVEL_TURBO_L1 0x882a5ffd #define ACD_LEVEL_TURBO 0x882a5ffd #define ACD_LEVEL_NOM_L1 0x882a5ffd #define ACD_LEVEL_NOM 0x882a5ffd #define ACD_LEVEL_SVS_L2 0x882a5ffd #define ACD_LEVEL_SVS_L1 0x882a5ffd #define ACD_LEVEL_SVS_L0 0x882a5ffd #define ACD_LEVEL_SVS 0x882c5ffd #define ACD_LEVEL_LOW_SVS_L1 0xc02a5ffd #define ACD_LEVEL_LOW_SVS 0xc02d5ffd #define ACD_LEVEL_LOW_SVS_D0 0xc02e5ffd #define ACD_LEVEL_LOW_SVS_D1 0xc82c5ffd #define ACD_LEVEL_LOW_SVS_D2 0xc82f5ffd Neil > > Konrad