mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@nbd.name>
To: Shiji Yang <yangshiji66@outlook.com>, linux-wireless@vger.kernel.org
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
	Ryder Lee <ryder.lee@mediatek.com>,
	Shayne Chen <shayne.chen@mediatek.com>,
	Sean Wang <sean.wang@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/2] wifi: mt76: connac: correct rate power limit logic
Date: Sat, 21 Nov 2026 09:14:08 +0100	[thread overview]
Message-ID: <a89222e1-8795-4c89-907d-38ebeb49e2a9@nbd.name> (raw)
In-Reply-To: <OSCPR01MB150191A858729F9D98B404F6ABC782@OSCPR01MB15019.jpnprd01.prod.outlook.com>

On 20.11.26 05:40, Shiji Yang wrote:
> When mac80211 sets the power to 0, it does not make sense to change
> the tx power to the maximum value. The original purpose should be to
> limit the tx power to not exceed the hardware limit.
> 
> Fixes: 8225816d2974 ("mt76: mt7921: limit txpower according to userlevel power")
> Cc: stable@vger.kernel.org
> Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
I think in some cases (e.g. on mt792x), hw->conf.power_level is always 
0, so this might cause regressions there.

- Felix

      reply	other threads:[~2026-11-21  8:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  4:40 [PATCH 1/2] wifi: mt76: connac: remove useless tx_power calculation Shiji Yang
2026-11-20  4:40 ` [PATCH 2/2] wifi: mt76: connac: correct rate power limit logic Shiji Yang
2026-11-21  8:14   ` Felix Fietkau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a89222e1-8795-4c89-907d-38ebeb49e2a9@nbd.name \
    --to=nbd@nbd.name \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=ryder.lee@mediatek.com \
    --cc=sean.wang@mediatek.com \
    --cc=shayne.chen@mediatek.com \
    --cc=stable@vger.kernel.org \
    --cc=yangshiji66@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®