From: "Andy Yan" <andyshrk@163.com>
To: "Daniel Stone" <daniel@fooishbar.org>
Cc: "Konstantin Shabanov" <mail@etehtsea.me>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Andy Yan" <andy.yan@rock-chips.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Dan Callaghan" <djc@djc.id.au>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re:Re: [PATCH v4] drm/rockchip: Disable AFBC for res >2560 on rk3399
Date: Fri, 18 Apr 2025 17:50:55 +0800 (CST) [thread overview]
Message-ID: <a893834.9206.196484ef2ab.Coremail.andyshrk@163.com> (raw)
In-Reply-To: <CAPj87rNDsyBfy=P=0SzTm7u6Na6BpeZSpEt1mRPhLCd6rHXzTA@mail.gmail.com>
Hi
At 2025-04-18 17:43:19, "Daniel Stone" <daniel@fooishbar.org> wrote:
>Hi Andy,
>
>On Fri, 18 Apr 2025 at 01:16, Andy Yan <andyshrk@163.com> wrote:
>> I prefer the V1 version PATCH[0]. This is because we do not deal with hardware-related
>> differences at this level. It involves a VOP-related restriction and we always handle
>> limitiation like this within the VOP driver .
>
>As said in the review for v1, this is not enough for generic userspace.
>
>If drmModeAddFB2WithModifiers() fails, userspace knows that the buffer
>can never work in that configuration, and it should fall back. If
>drmModeAtomicCommit(DRM_MODE_ATOMIC_TEST_ONLY) fails, userspace does
>not know that the buffer can _never_ work, because the failure may be
>transient or due to a combination of things.
>
>Returning the more localised error saves userspace a lot of work and
>enables a more optimal system.
Okay, fine, ACK.
>
>Cheers,
>Daniel
next prev parent reply other threads:[~2025-04-18 9:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250402125320.21836-1-mail@etehtsea.me>
2025-04-14 9:53 ` [PATCH v2] (drm/rockchip) Reject AFBC for resolutions >2560x1600 Konstantin Shabanov
2025-04-14 10:16 ` Andy Yan
2025-04-17 4:20 ` [PATCH v3] drm/rockchip: Disable AFBC for res >2560 on rk3399 Konstantin Shabanov
2025-04-17 6:57 ` [PATCH v4] " Konstantin Shabanov
2025-04-18 0:16 ` Andy Yan
2025-04-18 9:43 ` [PATCH " Daniel Stone
2025-04-18 9:50 ` Andy Yan [this message]
2025-04-24 11:31 ` Konstantin Shabanov
2025-05-21 16:05 ` [PATCH v5] drm/rockchip: Reject " Konstantin Shabanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a893834.9206.196484ef2ab.Coremail.andyshrk@163.com \
--to=andyshrk@163.com \
--cc=airlied@gmail.com \
--cc=andy.yan@rock-chips.com \
--cc=daniel@fooishbar.org \
--cc=djc@djc.id.au \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mail@etehtsea.me \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®