From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3D65C47080 for ; Tue, 1 Jun 2021 14:18:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7190613B1 for ; Tue, 1 Jun 2021 14:18:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234187AbhFAOUP (ORCPT ); Tue, 1 Jun 2021 10:20:15 -0400 Received: from m12-16.163.com ([220.181.12.16]:50664 "EHLO m12-16.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233797AbhFAOUM (ORCPT ); Tue, 1 Jun 2021 10:20:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Subject:From:Message-ID:Date:MIME-Version; bh=y7aHk AUo+jSHYQrkZ0j0+dywE+8/NT/eFr5f0mbX19w=; b=I8pMx1xQwT5AeQ0FtD3fX Xk8tuAwfhe5FqAwOKuXnk1j8oFPpc57VMiuQ1XfsyqfxaTcKTo3aVnjVldZ3zINo 3tjmynJIkuwSYmvqZETMj4EXV67ww+R0JdA/4rLSCv0ilDXMPNXrml98YxWVPrBB D4BLE2TbrDQxkaaFR57C1o= Received: from [192.168.31.187] (unknown [36.170.33.212]) by smtp12 (Coremail) with SMTP id EMCowAB3DEZGQbZgPyF6ug--.19144S2; Tue, 01 Jun 2021 22:16:40 +0800 (CST) Subject: Re: [PATCH] sched/debug:fix stale comments of sched_debug To: Andy Shevchenko , Peter Zijlstra Cc: Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Andrew Morton , Masahiro Yamada , Nick Desaulniers , Vitor Massaru Iha , Sedat Dilek , Wei Yang , linux-kernel@vger.kernel.org, Hailong Liu References: <20210530025145.13527-1-liuhailongg6@163.com> <48a36f92-e8cf-d62b-e4d5-bf6911bcbbcf@163.com> From: Hailong Liu Message-ID: Date: Tue, 1 Jun 2021 22:16:38 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CM-TRANSID: EMCowAB3DEZGQbZgPyF6ug--.19144S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7tF4DtryfurW7WF18KrW8Crg_yoW8WrWxpa s5Xa1qkFnrJryxKrn2yryxGrySqr9a9ry5Xr98WrWUZr98tr1SqFZ7KF429a4kuFWrAF10 vayrWFnxur1kA37anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jROJOUUUUU= X-Originating-IP: [36.170.33.212] X-CM-SenderInfo: xolxxtxlor0wjjw6il2tof0z/1tbi8AikYFuocBD3HQAAsF Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/1/21 8:58 PM, Andy Shevchenko wrote: > On Tue, Jun 01, 2021 at 09:56:51AM +0200, Peter Zijlstra wrote: >> On Mon, May 31, 2021 at 07:05:22PM +0300, Andy Shevchenko wrote: >>>>>> --- a/lib/Kconfig.debug >>>>>> +++ b/lib/Kconfig.debug >>>>>> @@ -1166,7 +1166,7 @@ config SCHED_DEBUG >>>>>> depends on DEBUG_KERNEL && PROC_FS >>>>> >>>>> Are the dependencies correct? >>>> >>>> Based on your suggestion, I checked and it turned out that PROC_FS is not >>>> the correct dependency, but DEBUG_FS. >>> >>> I guess you missed something. >>> >>>> Shoud I change it to DEBUG_FS? >>> >>> Please, double check. >> >> Thing is that proc_sched_show_task() still wants PROC_FS, i've not yet >> found a suitable debugfs based location for that. >> >> And DEBUG_FS doesn't need a dependency; it has complete DEBUG_FS=n >> wrappers and will build fine. Arguably selecting SCHED_DEBUG without >> DEBUG_FS is daft, but it should work. > > Yep, my point here is that we have several files (in procfs and debugfs) which > are enabled by the same option. Changing help text as it's done in the patch > seems a half baked solution, i.e. it needs more, like describing what the files > are visible in different configurations. > Big thanks to Andy and Peter for the views and suggestions. Personally, neither DEBUG_FS nor RPOC_FS are the building dependencies of SCHED_DEBUG. However, The visibility of the files(in procfs and debugfs) depends on both. So, can I make a compromise and add both PROC_FS and DEBUG_FS as dependencies in Kconfig; at the same time, add more descriptions of the two situations in the help text?