From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 524EE220687 for ; Fri, 12 Dec 2025 03:09:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765508971; cv=none; b=IxSv8O0mKDP1MFEc3raudPtC/pyNfQIRXskjHVYIRwTOAcVVbgPRdObkLynYDowTdXb+MpSCgQ285+fR3FjeYzbo4/7/hOrIbQ5WMVNZrIMbHmKBPDfSoo39BZ74PZVjDYhQRvWp5zydFPxZIOK/b7dquM3QaY6to/pI/XWW82A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765508971; c=relaxed/simple; bh=UAbscXjOybijOBktK8hVQyuCMBEp+JYujeegAo6+F68=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ArGkUw9TgjVjO/ULGuNSehxf//VENQ6Ylc4LAJTwPfWP+fbCKjpEc0I4pVOY0V5f5kVi6lWJMzDxB86T4dgAB24SKKytjnlj+8fVg5aiJ3Fui2/JU539iJyHFxavqJyuie8OE9v/ZiwstX7AJjs4+O1RwbA1BP14C5hcPpyZl0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=T7HinfJS; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="T7HinfJS" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-47775fb6cb4so5996145e9.0 for ; Thu, 11 Dec 2025 19:09:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1765508967; x=1766113767; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=jj5zYw7P0oX9QS/0hCFZBTR+6K2TxqVH9H1iHyzA2KE=; b=T7HinfJS9APkRSj1lDe20KhRUoVVDkiZL/MtIG5nHuapwR5Wji+u64jR+S9GQ68oQ3 5n2RLd3/iSC2SdD2px6CI6kf4ql4H7CZ4lUiLyHfR16xx7rCbHvfni2+NG+RckdmzKVC 2+Xm0AjyIoe6Xalys4TGVUuLC0DRwebDLFyGrjBPb34thOxhCDKOoUn1EdrkpZ/DUDW3 QBfwIJx2x0sfvs3zMWIabpK6fAgjb0hhE+VbKZAKUwYj1hOL5M0yBAESpBE1qPLBsZrh q+8JL/l/30IsGtyLLKSKtZmg5tYvf/VoLib3Bu7U6y6N7ZLpqUAVsrG8W2FX5Q81Fdfg 5uaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765508967; x=1766113767; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jj5zYw7P0oX9QS/0hCFZBTR+6K2TxqVH9H1iHyzA2KE=; b=QwuQfFyUKtMpVrpROfZU99cjE2EfXTHxLjKQtxng2T70/aXybjAqBmyuuctiBfkckG JIYrre7irGXGIyla75b5MQWyLuVtZ984P/C/nnPzMjDTSgFArLZgli6EqHyZGj6p/gYx wQuUl/4BRFpC8U8jqsL8Wdo6Cy6l4U6o/Zpx1LVBm3h/Ys0os3pCnHWcu51zA7tcI/GP oq5/LAlIrNS85gr5+VFLJ19f5WbrGBn1FatrzuLMxkJRemxlx3jW91wfE++w8WS7K0e+ YdPEkcwCxiPHDww+u6XSa6oO1lnUjfCVwZ8D/Ys2+n4GjGqxCgt5m/kqe7oIAMD7afuC yuxw== X-Forwarded-Encrypted: i=1; AJvYcCVsfejUjPrKddaXr9TjRGnRGgGRIXZD9RMK+IvU0Wc+/vGh3W8MjRGW/sacZi4ctz86kdDIbV5U+It7u7I=@vger.kernel.org X-Gm-Message-State: AOJu0YxVVhGmGI+qkHT3mAMV1+GJSEj89jSf26vDGXXPsahJMTwM2k52 bmHgVulzgFG7Sd9PNxlgxP/X72XGPkEG0/AWmQ5HvNZrk0xqe5Vmw75TPFAzXH8UoiA= X-Gm-Gg: AY/fxX6EcJNjRvs/cDIzq6FzZcbwTc3kOpLYTYTWiht11Ai+gcja6FeJ+66U4VCn+hw cMZmDqq36e7G+8Gl9asCHzT/w1fJJkYeawPA/WJNGnU6ulYccJjy12nqG+9cvnVda59le6TKHeb W8DEb8eDi3atGVYGJ6pp3BrpeGToihYHkMW8bchPxOy0mrVT9H+w4VrQQ409Nvzew2uxul0TWY3 M3VvjdRQ+0EysP9btcnmvOH2afxAhzYOFsG15bd65Lo1JP9gp/G7jzBXV4fb41n6cZbjNI7NSKZ HxHAF666trd35qUgQkt2megC2uGIr+u+2nDf7a50ElCnWmVgI2pHWLAY2k/NmHzM5gnB2Tb7pYo Rrojdk2JFnmgxOQeTAjXHtsX2T9GMEao5cvKKbMfanKxJORKRJ3+HVIkycFDn6Kr2lFSR/JTyre vp13rhVKJO3dZd7eat+8l/7MalbPwutINy9eCtoiA= X-Google-Smtp-Source: AGHT+IHJ0vB8GSL5MVmGw4MonjvPS92mfqKmgZf3GXE3W6qVuBmFCX/0aSwJh/vVhz4beNK4PUwgKg== X-Received: by 2002:a05:600c:608d:b0:477:632a:fd67 with SMTP id 5b1f17b1804b1-47a8f8c16bfmr4314055e9.12.1765508966606; Thu, 11 Dec 2025 19:09:26 -0800 (PST) Received: from ?IPV6:2403:580d:fda1::299? (2403-580d-fda1--299.ip6.aussiebb.net. [2403:580d:fda1::299]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7f4c566b3cesm3701873b3a.68.2025.12.11.19.09.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Dec 2025 19:09:26 -0800 (PST) Message-ID: Date: Fri, 12 Dec 2025 13:39:19 +1030 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] btrfs: qgroup: fix memory leak when add_qgroup_item() fails To: dsterba@suse.cz, Deepanshu Kartikey Cc: clm@fb.com, dsterba@suse.com, fdmanana@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+803e4cb8245b52928347@syzkaller.appspotmail.com References: <20251212005224.3565337-1-kartikey406@gmail.com> <20251212030357.GO4859@twin.jikos.cz> Content-Language: en-US From: Qu Wenruo Autocrypt: addr=wqu@suse.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNGFF1IFdlbnJ1byA8d3F1QHN1c2UuY29tPsLAlAQTAQgAPgIbAwULCQgHAgYVCAkKCwIE FgIDAQIeAQIXgBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXVgBQkQ/lqxAAoJEMI9kfOh Jf6o+jIH/2KhFmyOw4XWAYbnnijuYqb/obGae8HhcJO2KIGcxbsinK+KQFTSZnkFxnbsQ+VY fvtWBHGt8WfHcNmfjdejmy9si2jyy8smQV2jiB60a8iqQXGmsrkuR+AM2V360oEbMF3gVvim 2VSX2IiW9KERuhifjseNV1HLk0SHw5NnXiWh1THTqtvFFY+CwnLN2GqiMaSLF6gATW05/sEd V17MdI1z4+WSk7D57FlLjp50F3ow2WJtXwG8yG8d6S40dytZpH9iFuk12Sbg7lrtQxPPOIEU rpmZLfCNJJoZj603613w/M8EiZw6MohzikTWcFc55RLYJPBWQ+9puZtx1DopW2jOwE0EWdWB rwEIAKpT62HgSzL9zwGe+WIUCMB+nOEjXAfvoUPUwk+YCEDcOdfkkM5FyBoJs8TCEuPXGXBO Cl5P5B8OYYnkHkGWutAVlUTV8KESOIm/KJIA7jJA+Ss9VhMjtePfgWexw+P8itFRSRrrwyUf E+0WcAevblUi45LjWWZgpg3A80tHP0iToOZ5MbdYk7YFBE29cDSleskfV80ZKxFv6koQocq0 vXzTfHvXNDELAuH7Ms/WJcdUzmPyBf3Oq6mKBBH8J6XZc9LjjNZwNbyvsHSrV5bgmu/THX2n g/3be+iqf6OggCiy3I1NSMJ5KtR0q2H2Nx2Vqb1fYPOID8McMV9Ll6rh8S8AEQEAAcLAfAQY AQgAJgIbDBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXWBBQkQ/lrSAAoJEMI9kfOhJf6o cakH+QHwDszsoYvmrNq36MFGgvAHRjdlrHRBa4A1V1kzd4kOUokongcrOOgHY9yfglcvZqlJ qfa4l+1oxs1BvCi29psteQTtw+memmcGruKi+YHD7793zNCMtAtYidDmQ2pWaLfqSaryjlzR /3tBWMyvIeWZKURnZbBzWRREB7iWxEbZ014B3gICqZPDRwwitHpH8Om3eZr7ygZck6bBa4MU o1XgbZcspyCGqu1xF/bMAY2iCDcq6ULKQceuKkbeQ8qxvt9hVxJC2W3lHq8dlK1pkHPDg9wO JoAXek8MF37R8gpLoGWl41FIUb3hFiu3zhDDvslYM4BmzI18QgQTQnotJH8= In-Reply-To: <20251212030357.GO4859@twin.jikos.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2025/12/12 13:33, David Sterba 写道: > On Fri, Dec 12, 2025 at 06:22:24AM +0530, Deepanshu Kartikey wrote: >> If add_qgroup_item() fails, we jump to the out label without freeing the >> preallocated qgroup structure. This causes a memory leak and triggers >> the ASSERT(prealloc == NULL) assertion. >> >> Fix this by freeing prealloc and setting it to NULL before jumping to >> the out label when add_qgroup_item() fails. >> >> Reported-by: syzbot+803e4cb8245b52928347@syzkaller.appspotmail.com >> Closes: https://syzkaller.appspot.com/bug?extid=803e4cb8245b52928347 >> Fixes: 8d54518b5e52 ("btrfs: qgroup: pre-allocate btrfs_qgroup to reduce GFP_ATOMIC usage") And that's the wrong commit, at that commit things are still correct and no leakage. >> Signed-off-by: Deepanshu Kartikey > > Thanks for the fix, this has been fixed in a different way by commit > https://github.com/btrfs/linux/commit/b95d1588dd2395d0fa1cd3ecf368b2dcec5445ff > and there were more problems than the one you fixed. > > You're probably using master branch where this code is still broken so > the fix is present only in the development for-next branch. It's been in > linux-next.git though so you may want to check there first before > sending fixes.