From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4359194C9A for ; Tue, 30 Jul 2024 09:41:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722332494; cv=none; b=mU4Wt2Tk05KRjUcGiyTfcXLQXpbc9f9XVnZ/z8LofivW4QB8vY+m7DsTHGmqwSD/t2sh5DqTdlD3NOh0+jHAq58GG0r9ly40SGz/LgbFNSkqQPF0F6Xj0Bz/E0H4cr5Cvqg9+0PtSQVfXw1e/xHL4mx5pv+3xQ+njwyeQhmXG08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722332494; c=relaxed/simple; bh=sAJfbSdkxBuvv/gBWbqyRUcrwK1tk75eXrGx18g35jI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DOPManDWCqT9pMTABGjA+qKlYGMX/LrYssWpSJ1oJ7Ug3D9lMW3UQeC1aDXePcohqQ5g2P02XN14SXMHo3u6R+or77wmVM40Qua82S9FnZr7jX43RO5G9cAvPGRfyMdAVKNVhIY9jZLi6fIUImBWnoV2VH3Cp5MtUjLDyTCJu+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TWPHIvow; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TWPHIvow" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722332491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bucWtKsDCljZn42RLmuuTT14VK+qGuaRfxJDfBS1Xeo=; b=TWPHIvowmFk5C1KTtP/sBTI2V+wwbeRtuUocQX6NSJPr6NNouNhOYwbRF4PDktNORaXj45 YnCrdYlK2QQufhqWc0gHCN7GNlDLWx6/ty+n3LWCKC8rKIocguCS9SiyQUSVWjlA/z2Qet f7Y4ktzp1M2qQzMwWx39UtVRdiP3QSg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-159-xAhGl0unNj2lQZZ7vYfpoA-1; Tue, 30 Jul 2024 05:41:30 -0400 X-MC-Unique: xAhGl0unNj2lQZZ7vYfpoA-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-36873ed688dso1949936f8f.1 for ; Tue, 30 Jul 2024 02:41:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722332489; x=1722937289; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bucWtKsDCljZn42RLmuuTT14VK+qGuaRfxJDfBS1Xeo=; b=UM5pNNTqnq2nieh0VlW90GTwRr5oW1ghKbLsB6RSQZjHLqlTr5cyKq0Vi/5JDosdSS Qy0LbZ4hiL/Liq4R0L9Kr03Iks4hLm5Cyr6JFiIeCJBOMh1zQHUVehD2uOqJpOjEwlzC /Te1Gx+Oy6Ti2iAMoY+haIHtSvtU4NqdE+ARv7yJhcBxNLAxlbFG03cAUQDagxYi/Ucn 1AyjT4PGFknq97An1XmajOEow5XU3QJoQ0rI1QcdTN39JBxPWsEsvYgOtYP4QGe/efgx 6otKi1sY2x/EFWqYqZUcVUTKpxifCGnDbutwTQDn1ux9dIseLpC4luqAnGFVTSu4HdXF Xqzw== X-Forwarded-Encrypted: i=1; AJvYcCW9xocx3WDYEYLyAN9hcjLnbgPqbdVPhHQFm5fXFm3EMPGTOD+dxlMrzFnlLCcODtt39ybpletBwzUpv1opbtVzZqPjP/ctJsGBEyvT X-Gm-Message-State: AOJu0Yz9t62sPnGe4czaSNIvPpaPTE35jVyrsR1e2+HwpOXVauZdpuBe qtJiLmVpkSj3jwdQB3z5ImtNPt4/uFO+rGqmjXe1GjblTfnaXOkEQGOvM3IgaRWY/2QXxeg9iZX BU870YFXlfz4DN8P55a321AM7+hS7A3rQbz4fGhP+T5bcE4/iDBA1YS5QNijQuQ== X-Received: by 2002:a5d:6b45:0:b0:368:3198:5ac4 with SMTP id ffacd0b85a97d-36b5d08b2e4mr6410856f8f.39.1722332489370; Tue, 30 Jul 2024 02:41:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEeM2z1tq8sy4zCr5Saz0gUFLEMWJsZ/+kNOkOJh3ajK7DTu6J+rNTLz/Qsyebt81/kxLQXlg== X-Received: by 2002:a5d:6b45:0:b0:368:3198:5ac4 with SMTP id ffacd0b85a97d-36b5d08b2e4mr6410840f8f.39.1722332488929; Tue, 30 Jul 2024 02:41:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:4e00:31ad:5274:e21c:b59? (p200300cbc7064e0031ad5274e21c0b59.dip0.t-ipconnect.de. [2003:cb:c706:4e00:31ad:5274:e21c:b59]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b367c0889sm14247384f8f.22.2024.07.30.02.41.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jul 2024 02:41:28 -0700 (PDT) Message-ID: Date: Tue, 30 Jul 2024 11:41:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2] mm/gup: Clear the LRU flag of a page before adding to LRU batch To: Ge Yang , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, liuzixing@hygon.cn References: <1719038884-1903-1-git-send-email-yangge1116@126.com> <3a2ab0ea-3a07-45a0-ae0e-b9d48bf409bd@redhat.com> <79234eac-d7cc-424b-984d-b78861a5e862@126.com> <9e018975-8a80-46a6-ab38-f3e2945c8878@redhat.com> <1c5f1582-d6ea-4e27-a966-e6e992cf7c22@126.com> Content-Language: en-US From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <1c5f1582-d6ea-4e27-a966-e6e992cf7c22@126.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 30.07.24 11:36, Ge Yang wrote: > > > 在 2024/7/30 15:45, David Hildenbrand 写道: >>>> Looking at this in more detail, I wonder if we can turn that to >>>> >>>> if (!folio_test_clear_lru(folio)) >>>>       return; >>>> folio_get(folio); >>>> >>>> In all cases? The caller must hold a reference, so this should be fine. >>>> >>> >>> Seems the caller madvise_free_pte_range(...), calling >>> folio_mark_lazyfree(...), doesn't hold a reference on folio. >>> >> >> If that would be the case and the folio could get freed concurrently, >> the folio_get(folio) would be completely broken. >> >> In madvise_free_pte_range() we hold the PTL, so the folio cannot get >> freed concurrently. >> > > Right. > >> folio_get() is only allowed when we are sure the folio cannot get freed >> concurrently, because we know there is a reference that cannot go away. >> >> > > When cpu0 runs folio_activate(), and cpu1 runs folio_put() concurrently, > a possible bad scenario would like: > > cpu0 cpu1 > > folio_put_testzero(folio) > if (!folio_test_clear_lru(folio))// Seems folio shouldn't be accessed > > return; > folio_get(folio); > __folio_put(folio) > __folio_clear_lru(folio) > > > Seems we should use folio_try_get(folio) instead of folio_get(folio). In which case is folio_activate() called without the PTL on a mapped page or without a raised refcount? -- Cheers, David / dhildenb