From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8CAE230987 for ; Tue, 22 Apr 2025 06:44:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745304271; cv=none; b=LBeyPNXJ5q4hQE70FGowoq6h7vzwwk7GfumfJOyr+3pg3VyCV7ck0VwO6IL21rZFajRJBrjFIceWg2whuanrxdPU40tOrJqK4/L2CMp3SgCV/SfhL9zEtLHvrzdSNQHAWjRKYv+TOBvVl35kkdrMtoydbgsKhLEArndpgGdS7Rw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745304271; c=relaxed/simple; bh=pL9CVghxG1ZKZG1MuX1QtZhXgzKhXTo0AK7d0/+p3xY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Xbjq5BFlJ61Z3udVTYCRST6tftSsNAj1u+rE5EDS10pmZNKmTu4QpQUy6ZHLpZrbb6Gsa6RpmTRe9hHHHGnXyEwR5P4wRruXVtJ1jMoQEbk2bHgHvOzRq3uDfwXqBPFD/Gk5X4WY13o0Z1pHObSFDyOkp1d6U9bm+IuFwfb8yUc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=P25l369j; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="P25l369j" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43cfe574976so34113265e9.1 for ; Mon, 21 Apr 2025 23:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745304268; x=1745909068; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kQPImNugkItyfP+G4uJ4TvGScdbcNscFNsfQCd9dZNE=; b=P25l369jAn9sNJUob6mGg2mVdvGuM3gRMBmf35Zmk/W5ck+xHjn+4wiLOxBzgjpJqW DN30LH7NfsdefQr8jK79hdrwUymBvasQoWCx0L2K6nqOTmOdd+r80O46YRSu1aKRrFjo ULJP52yxNqsVXlaxRZzdxosbiXhTWzNfzChfaWEuzLxxsHP2IMIr3GjfOs1BgnCEXJE/ UsFSkUHuLw5lsCS+smx8Uco9oGNI6aVrrwBZOFR10mOnU6MfQD+n6kMHlETJce/aXSZG 28gz8G5LhMPuYUcIiG7pxswa0+G18iZyGKqc0UllyERgibFGGdogRPEHavLno2AmrCpp aLYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745304268; x=1745909068; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kQPImNugkItyfP+G4uJ4TvGScdbcNscFNsfQCd9dZNE=; b=bZfTw+ZbvRiEig40KXqIxjOwDqjFYD6kRz07Rto+Y4yd607/8X/ofGWQGTSQDqDaES 2nuhxnX2CHybioFxiXqu1O0AxCqafscFd2o0O84n/no8QK9Lr+0vyr7P3/gCqRq62sbc 5ksxIwc428UiCsZkqXs+l8eB3nISMwmo3XHl5Kpr1E0WKcQOC68qlB5bW6aHWDNofGBv c4c9OpGS76Isgm/18gDX9UtfcqEjh6Sm2AsZbVrO0anmcjDJbA/anC9UGqx9DCzUHLjW ClAANaWhcu+XOxG/wejFcWK25yvXkP6/J2FAbK5Y6vfk87oLMnL0RrePpVOdLK58XRhB 2j9w== X-Forwarded-Encrypted: i=1; AJvYcCVpz529JwEccjYSbgENJo8H87ADfMGJ8JCZnJFDuB2pJj0KvLnomkDIFTr8+Zfa2Rrd1pvpdaib79vBnKo=@vger.kernel.org X-Gm-Message-State: AOJu0YxrgD45bd4NfMXkdl6jcjFC9JvnTU/FdWaZoR/cJufChF6rSdL3 H3iHlZfsZNQhKZEvOOsm6/t5lIyif8W7G7ZE9HhtVMvoIdEjZhBHFRoFqq4Alh+21sJKjuIj63f b X-Gm-Gg: ASbGnctjV0FZ2h4S5lzBhkNhQHuMg9+jlW/X74siHIgxN/b9jQLIB2NwyTjrQPE81vl VO6Oak752WoDTssAUd4aMv6PLvjd4z4frglcpSxlkPBwqUDPzwtAHDdQ7qN6UGmSLRlrS9digl2 chpZ0uQv65Ch7ftuFNQr4/aNru5SS9x+DcwEUnUa5OWQX2cgCveJHgMz3M7SVBT7cQhjVnPx/KV QChBDPhK8cIFD80r3X0TCOOo5iVAaNkp1M3nrpu30jiR9p8UkdJMd3qTQesZa1zFiDS+B/YxL97 ON//xUt8qavuT+J51FpvbZoHCzZle7QwspUA5lWb5aHN/A== X-Google-Smtp-Source: AGHT+IHUNJ5wQ9P52XuaZE0IU0Ci7qmgXOj8IWWiW+Ga6WWO0mvjKQK2WDhvuSV7fUR8QE54qZimKg== X-Received: by 2002:a05:600c:5023:b0:43c:fa0e:4713 with SMTP id 5b1f17b1804b1-4406ab7efadmr141939785e9.2.1745304268110; Mon, 21 Apr 2025 23:44:28 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4406d5cf2easm160870545e9.31.2025.04.21.23.44.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 23:44:27 -0700 (PDT) Date: Tue, 22 Apr 2025 09:44:24 +0300 From: Dan Carpenter To: Gabriel Shahrouzi Cc: gregkh@linuxfoundation.org, jic23@kernel.org, lars@metafoo.de, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Michael.Hennerich@analog.com, sonic.zhang@analog.com, vapier@gentoo.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev Subject: Re: [PATCH 5/5] staging: iio: adc: ad7816: Simplify channel validation using chip_info Message-ID: References: <20250419135638.810070-1-gshahrouzi@gmail.com> <20250419135638.810070-6-gshahrouzi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250419135638.810070-6-gshahrouzi@gmail.com> On Sat, Apr 19, 2025 at 09:56:38AM -0400, Gabriel Shahrouzi wrote: > Refactor the channel validation logic within ad7816_store_channel() to > leverage the max_channels field previously introduced in the > ad7816_chip_info structure. > > Signed-off-by: Gabriel Shahrouzi Could you add the ->max_channels struct member here? This patch would be easier to review if it had all the ->max_channels information in one place so we didn't have to jump back to patch 3 to verify that it's correct. regards, dan carpenter