From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 736F0C433EF for ; Mon, 11 Apr 2022 04:27:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243242AbiDKE3m (ORCPT ); Mon, 11 Apr 2022 00:29:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236240AbiDKE3i (ORCPT ); Mon, 11 Apr 2022 00:29:38 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E8661B7BE; Sun, 10 Apr 2022 21:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1649651245; x=1681187245; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=XMkyb6U22eVnNL7TEkYzIf/lCVfO5BZjV/i/7bGW49M=; b=F8PGjbQhRpUn8sEaLN+zGq3Kht9KxRensfKJu4lEjBhYJq3FDl3qu5Bt shGVghQO5MLgS5K5eFc0WHAba7BPm4NCuABro03ZSmIXoXb2DMJRNfgYx R0/9qUfnk5U7owDUCxbSdUpA8md1E2igwO7AMSjQIyDc8/EF9JkYg42M3 E=; Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by alexa-out-sd-01.qualcomm.com with ESMTP; 10 Apr 2022 21:27:24 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg03-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2022 21:27:24 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Sun, 10 Apr 2022 21:27:23 -0700 Received: from [10.79.138.7] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Sun, 10 Apr 2022 21:27:20 -0700 Message-ID: Date: Mon, 11 Apr 2022 09:57:17 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 3/3] soc: qcom: llcc: Add MODULE_DEVICE_TABLE() Content-Language: en-US To: Bjorn Andersson , Andy Gross , Konrad Dybcio , Luca Weiss CC: Rob Herring , Krzysztof Kozlowski , , , References: <20220408213336.581661-1-bjorn.andersson@linaro.org> <20220408213336.581661-3-bjorn.andersson@linaro.org> From: Sai Prakash Ranjan In-Reply-To: <20220408213336.581661-3-bjorn.andersson@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/9/2022 3:03 AM, Bjorn Andersson wrote: > The llcc-qcom driver can be compiled as a module, but lacks > MODULE_DEVICE_TABLE() and will therefore not be loaded automatically. > Fix this. > > Fixes: a3134fb09e0b ("drivers: soc: Add LLCC driver") > Signed-off-by: Bjorn Andersson > --- > drivers/soc/qcom/llcc-qcom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c > index a76d58195637..918bfd0df0e2 100644 > --- a/drivers/soc/qcom/llcc-qcom.c > +++ b/drivers/soc/qcom/llcc-qcom.c > @@ -809,6 +809,7 @@ static const struct of_device_id qcom_llcc_of_match[] = { > { .compatible = "qcom,sm8450-llcc", .data = &sm8450_cfg }, > { } > }; > +MODULE_DEVICE_TABLE(of, qcom_llcc_of_match); > > static struct platform_driver qcom_llcc_driver = { > .driver = { Reviewed-by: Sai Prakash Ranjan Thanks, Sai