From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D80B7C4332F for ; Fri, 4 Nov 2022 14:37:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231446AbiKDOha convert rfc822-to-8bit (ORCPT ); Fri, 4 Nov 2022 10:37:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231842AbiKDOgh (ORCPT ); Fri, 4 Nov 2022 10:36:37 -0400 Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 914FE31FA0 for ; Fri, 4 Nov 2022 07:33:45 -0700 (PDT) Received: from omf09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B1E30A1409; Fri, 4 Nov 2022 14:33:43 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA id 4B6D220028; Fri, 4 Nov 2022 14:33:40 +0000 (UTC) Message-ID: Subject: Re: [PATCH -next v2] checkpatch: Add check for array allocator family argument order From: Joe Perches To: Lukas Bulwahn , Liao Chang Cc: apw@canonical.com, dwaipayanray1@gmail.com, linux-kernel@vger.kernel.org, bagasdotme@gmail.com, pbonzini@redhat.com Date: Fri, 04 Nov 2022 07:33:39 -0700 In-Reply-To: References: <20221104070523.60296-1-liaochang1@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Rspamd-Server: rspamout05 X-Rspamd-Queue-Id: 4B6D220028 X-Stat-Signature: 4sjyohrgqpg944iu7h8hd45b31x5o5r7 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX19wD3RqL7rcRrcmMu0rbTYsZy3DyVjpZy4= X-HE-Tag: 1667572420-735852 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2022-11-04 at 09:35 +0100, Lukas Bulwahn wrote: > On Fri, Nov 4, 2022 at 8:08 AM Liao Chang wrote: > > > > These array allocator family are sometimes misused with the first and > > second arguments switchted. > > Just a nit: > > s/switchted/switched/ > > But probably you actually mean "swapped". I think there is a slight > difference between the two words, "switched" and "swapped". And here > the arguments are swapped. Note: I am also not a native speaker. > > For the implementation change: > > Acked-by: Lukas Bulwahn > > How many new findings are now identified with this extended check on > linux-next? Could you run checkpatch on all files of linux-next and > share the new findings? Then we can do a quick scan if some instances > should be immediately fixed or some janitor should follow through with > such a task. There are ~25. It's fairly trivial Lukas and only cosmetic. https://lore.kernel.org/lkml/d92ada3062bc1c3a7557bfa0499fc4a8cee3aa10.camel@perches.com/