From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DEA1175A7C for ; Thu, 11 Jun 2026 23:11:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781219473; cv=none; b=EGpnuIG5Inu7X8dsHOrIK+8Pf05FVh3+OSnMt2yDjAUidWsCpNIWqOLL5NfyJweXDJzvT7f+aRZ7ybeyvaHjpK75h7jRcjuu3s7hIN1NojFdrBpxLAb83aak6Dis12ffFloAy083A6gyGryz6DB3rVP/34jJ0EUzo6X2ZGgYwAg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781219473; c=relaxed/simple; bh=7llc2zU704CZuS6wcMO/gSnF4DuWhD/d1CvuLJDTGr4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gz3w8lNApyCj++QBLSMkzaU/I9pMYOJtJjUPahHa99UL8WpsnJRpUnpZYcRZN8ckrY4qGrM5GnJjahM2t3nrVP6pdL+36WuOxR7BwGBa1prZWuYm8TfUWuvcn9zh5512W7QY+dMIdip5Oar+nDGFai9gRXLZL+OWVZ0JPPO0/0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WpCpPe6x; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ieu+8VxN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WpCpPe6x"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ieu+8VxN" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65BMVn6D1921636 for ; Thu, 11 Jun 2026 23:11:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /ra7DsXwOaiwrHQtA1SnHHFQrkE42atPpkf17mbDUMI=; b=WpCpPe6xOrIw3GJw OB2xOx5k56CxaWchG8ZoWn8Tp92pVo73Tlz5PBuM6DNP3QWC5YObQT2m78CfBNW3 uqAdeWVv8eCTzXjLNUrtH8HlEtmyT1E5TepGS3twnH33iRZCjB1Wn8mKh659Ii6/ VdCctGfdTa36CJivRtBjUvApbvG//xJj5PSbGgy3g67umUwKPlZMdo2bDimh2Ums lokv133+AAFudw+8dQlvmlYvBA/Y8kaIm9rNV1zDVqrAXLwkwOR52cQ9StYG6Jj0 nAh3D/aSgA4JgAjHsR1xGYzMYnl7mTVO+YnN1+yzVVuyJqeOfVazcFS+4UO3AI+d RHntVQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er1cbhb26-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 11 Jun 2026 23:11:11 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84238e83851so240219b3a.1 for ; Thu, 11 Jun 2026 16:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781219470; x=1781824270; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/ra7DsXwOaiwrHQtA1SnHHFQrkE42atPpkf17mbDUMI=; b=Ieu+8VxNigLKj2pQutpJHiUwFxktPLUaZUNXNkq9f57k5FCF6ZhvZ1rXqLa1Fya5Pm Iv7mT/HMUJ8ZlAFxfLCuF1aA3zK0I9ve2Eab2P3N41ClACslJ6lm/vRR6iqw3cbuGTZf rYHkP1x4/GLgcyfHy6wEyk6ABHI+DwtOrbz6gJHDlx/vcmngDJUjTAKwktcvRaMpsq0C MkswauyDN8oDfalH76JweNGKKq+3k3X1TSqNf+D3OGKU3Jr+a6H+CWQeDsknKIHDwhek NhvOpY4zg1xe8DdVZa6SKrkENDpdQAqJDToTlh9VPBu1eW8/h+unbh9gXb/un3b/tCBz +mMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781219470; x=1781824270; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/ra7DsXwOaiwrHQtA1SnHHFQrkE42atPpkf17mbDUMI=; b=nhugCAfNte0X/nI25uDfqzZr7nh2/EcS+qn4cHPVgpLFMa335KBvsBNLa/yHly7hPq DyZzEMFt7gX84/1rPnIuTjId9SrnSWbU+JtOucawQTpNMRtqQmhGJUHlyOk1PdU5no85 8ij3XmpFdrCVaKMu/Z+zGColfWWbn/xuNJ3CwLeMai17dQp8HIn/t97Ho01hp1Jd/TJd B9krtegHBhLwpFspn9MnZqc5LV2fdRigy8HzAEhs5pc7tnFSw/z5y5cRq7dvHH9Vh0zd KRxnfGC7/KKaTp85aPSctLXfY1xiAqZel0YN8hnUMGlMN96k1WQcwIw3ZNp/f2XqqCJd 6kWw== X-Forwarded-Encrypted: i=1; AFNElJ/4ReQTBYTzPSVEMv4gx4LsM+jfcWw+91onUjziIbBEZBY6sNVhRfRk7/kANjrveGjuUeDp7eLfS71N9H8=@vger.kernel.org X-Gm-Message-State: AOJu0YyVgQcPPFOy/kDIugY4c/kg2xWhI3iAC7lWA5OIXynG5Vptllis mGk81dHM5bEBcqKtz7JqcLB8btzRftEZgvctKGFXQP10yVWKZyuLLS9FV/ROJbggx+KyQOHFnyp oa0CesXoqVqJMWdoO3Kks2xKQidwljI2bTcXPkkFKgJ+SuooZaqq49VZ9jYrse1iwYmd0MyGzLW wHuA== X-Gm-Gg: Acq92OHKfoiPA6SwCPKCybGdp7LRAvZ1aYbgyVmV0V25SaNMj/ZngsDCKJDczVrHUzK V8wQVmeEdacJBW5MXNWM6GusiHpGc1yQDoy9865Go15zOVzJDJByKujJQCLpBCkTo3jg3SLDzx9 3jxCGqLa1vH0N2ziFleBH2s5a5LArzOzZ+/WjeRecsEJLbv4DO7aDqTkyW/IEKb8rRrU/IAJaY5 ILSTvSAUXkrMQ8u/cx03hNl5SLVCKvR8BT5qGcXiN4NMAadXj7L3AFFt3yvTawvmks3eeCTRn0c eoSnDBolB4FwWoAKaMj1ftHA9Nyc5W8qOnYIEU8eHWmAULk2zS5rPeXobUH8F0nRuo0LHAspvIP gclthfjSRKFiRMbuEle+DKYRu2SW+zEomBkAfJT7v1tAwWD2VFHmgDPHBq6USzqSOvsQWAnSYdp TqufVZaclWb28= X-Received: by 2002:a05:6a00:1c97:b0:82f:48e:241c with SMTP id d2e1a72fcca58-8434ce95df6mr100397b3a.23.1781219470117; Thu, 11 Jun 2026 16:11:10 -0700 (PDT) X-Received: by 2002:a05:6a00:1c97:b0:82f:48e:241c with SMTP id d2e1a72fcca58-8434ce95df6mr100361b3a.23.1781219469634; Thu, 11 Jun 2026 16:11:09 -0700 (PDT) Received: from [10.133.33.228] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434b0112edsm177647b3a.45.2026.06.11.16.11.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 16:11:09 -0700 (PDT) Message-ID: Date: Fri, 12 Jun 2026 07:11:04 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] arm64: dts: qcom: glymur: add coresight nodes To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260519-add-coresight-nodes-for-glymur-v5-1-3dad99fe31e0@oss.qualcomm.com> <3c2fdcf8-957b-4b28-85b7-3a50ab8ee485@oss.qualcomm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <3c2fdcf8-957b-4b28-85b7-3a50ab8ee485@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: fuAbWuTMfOWGJnJYuFPQVmJJUhSH2sft X-Proofpoint-ORIG-GUID: fuAbWuTMfOWGJnJYuFPQVmJJUhSH2sft X-Proofpoint-Spam-Info: AW1haW4tMjYwNjExMDIzMiBTYWx0ZWRfX0M0v89UvLIxW Rarapj5bpEu29NYXrlzKXqDJOBM5BCv7/qdT+QThcWRZkOn4Rq9GtdjWCNKO7uKWaUXksD/TXEi AYCPzu6IyD0S3f1NcWYCcJX56htt9bw= X-Authority-Analysis: v=2.4 cv=S57pBosP c=1 sm=1 tr=0 ts=6a2b408f cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=pvX1nSozBNrohX3L37MA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjExMDIzMiBTYWx0ZWRfX3tbdy9ajPj35 OwYMciPENfPTX1GhZC7N92NPwx+91uvH/QpDgcyzClx91pd91IWHn9BO2irI9qhjCAGL0wj0ZmA YlujsDpPpbTdqTm6ZZaAFvBd+T/ckj9KjBT3PaiZpHUFRMVq7A43DIP5Ac/okI0MmUWPDaIfMKV XfOG3cs4YqCpwnQiRGlPVUbsEqdbtcPKfSPRFGqH9D4AK13JyVuYpyYeRzGjxeNatcv7jXyYSJb v7jlx5I2zASoTuKuHpRvnfxzV6kAsaplQdqz7TCMfcn0i9CTZer9+8iPfWV4VUyoqpqc0gBmTTd cSGzXheSBqCvOCpPkHbDyDy+awlDD9Sgki3R46Rkwl2W8O7sCedZi3KFAC0Rn1boCFu7c0srUTS je0yWpsDfPlD514dqaPzJANWzU20Df1mSNxuGWBbYnCxPoteFefc4tnxXDEf2n/blnFrdnFQA4r /+SfGIRu1UcOirZdMLA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_05,2026-06-11_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 adultscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606110232 On 6/11/2026 5:28 PM, Konrad Dybcio wrote: > On 5/19/26 3:14 PM, Jie Gan wrote: >> Add CoreSight nodes to enable trace paths like TPDM->ETF/STM->ETF. >> These devices are part of the AOSS, CDSP, QDSS, PCIe5, TraceNoc and >> some small subsystems, such as GCC, IPCC, PMU and so on. >> >> Delete cti_wpss DT node on Mahua since this device will cause NoC issue >> on Mahua device. > > Another good explanation is that it simply doesn't exist there! > >> Signed-off-by: Jie Gan >> --- > > [...] > > >> + tpdm-cdsp-llm { > > Nodes without a unit address should be sorted alphabetically > >> + compatible = "qcom,coresight-static-tpdm"; >> + qcom,cmb-element-bits = <32>; > > Do these other TPDMs not have the "DSB element" as the driver > calls it? Depends on the design of the TPDM. tpdm-cdsp-llm here only supports CMB mode. There are three types of TPDM: CMB only DSB only support both > >> + >> + out-ports { >> + port { >> + cdsp_llm_tpdm_out: endpoint { >> + remote-endpoint = <&cdsp_tpda_in1>; >> + }; >> + }; >> + }; >> + }; >> + >> + tpdm-cdsp-llm2 { >> + compatible = "qcom,coresight-static-tpdm"; >> + qcom,cmb-element-bits = <32>; >> + >> + out-ports { >> + port { >> + cdsp_llm2_tpdm_out: endpoint { >> + remote-endpoint = <&cdsp_tpda_in2>; >> + }; >> + }; >> + }; >> + }; >> + >> + tpdm-cdsp-cmsr { >> + compatible = "qcom,coresight-static-tpdm"; >> + >> + qcom,cmb-element-bits = <32>; >> + qcom,dsb-element-bits = <32>; > > Some nodes have a \n between compatible and other properties, some don't > Please unify the style (fwiw I prefer the one with a \n) I will take care of it in the future. Thanks, Jie > >> base-commit: e98d21c170b01ddef366f023bbfcf6b31509fa83 > > Please rebase, doesn't apply on next-20260610 > > Konrad