From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751990AbdJ3SCc (ORCPT ); Mon, 30 Oct 2017 14:02:32 -0400 Received: from mail-pg0-f43.google.com ([74.125.83.43]:57198 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469AbdJ3SCa (ORCPT ); Mon, 30 Oct 2017 14:02:30 -0400 X-Google-Smtp-Source: ABhQp+RS6hJV/UnLou5m81lSZYo2sqaKUmXkUIb7xId++FP1dLdKSZGb+L+YtQKXjWxb/+P/YCeTng== Subject: Re: [PATCH v2] bcache: explicitly destroy mutex while exiting To: Liang C Cc: Coly Li , linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171010090049.6596-1-liangchen.linux@gmail.com> <01f432e8-950a-fc9f-150d-0b51fa9e7559@coly.li> From: Michael Lyle Message-ID: Date: Mon, 30 Oct 2017 11:02:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Liang-- On 10/30/2017 05:33 AM, Liang C wrote: > Hi Michael, > Would you please to include this patch in your tree for the next > release? It seems passed the review. Thank you. > > Thanks, > Liang Thanks for the reminder. It's in my bcache-for-next tree at https://github.com/mlyle/linux/ along with a few other small changes. I am testing today and plan on sending them up to Jens soon if I have good luck overall (and after reading overall diff). Though: it is getting late for non-critical changes in 4.15 so I need to have perfect test sequences with no unexplained anomalies to send these to Jens for 4.15. Mike > > On Tue, Oct 10, 2017 at 11:44 PM, Michael Lyle wrote: >> On 10/10/2017 05:25 AM, Coly Li wrote: >>> On 2017/10/10 下午5:00, Liang Chen wrote: >>>> mutex_destroy does nothing most of time, but it's better to call >>>> it to make the code future proof and it also has some meaning >>>> for like mutex debug. >>>> >>>> As Coly pointed out in a previous review, bcache_exit() may not be >>>> able to handle all the references properly if userspace registers >>>> cache and backing devices right before bch_debug_init runs and >>>> bch_debug_init failes later. So not exposing userspace interface >>>> until everything is ready to avoid that issue. >>>> >>>> Signed-off-by: Liang Chen >>> >>> Hi Liang, >>> >>> No more comment from me, it looks good. Thanks. >>> >>> Reviewed-by: Coly Li >> >> Looks good to me too. >> >> Reviewed-by: Michael Lyle >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-bcache" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >