From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD5741E5B95 for ; Tue, 30 Dec 2025 13:23:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767101041; cv=none; b=M8BRJxLQ3FCm1kEKNyrX93b1TrLRIdZvWZoG4RvV+zLD8QyAtjhfDnD9DFb3TWu0L1/PQM06D5BtzfXMrLha17YgT8EQiITjQMvHXsyjvkkYX/vnCRhsDgOL5zqrQoY5FKaBFFYZ+9VxfvJs6L+xliFa6+7pgXIIvCzkVK4dfBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767101041; c=relaxed/simple; bh=ueRwGKc6dUuh4vjK8zitLsVaem8IUtCnVornbzI3oS4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WQMBlu8zhF24SCMvGNVs1wLxKsylr4ZL/PJQMB0EqOMZ+nbaxvB2aNOYp7B3qw55xkF5JBZrThnWThMsSNJy5/ivD+InFhbj5T0mvLfbtnqIACe+qRpdJSqSNcDUw9GMEZp3tGUiPQLKpxk2AsXP6CnqMOagdiKAxvanJQ8sC8w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KLKZdTaj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DO98EiIL; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KLKZdTaj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DO98EiIL" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BU9V5Mn2551303 for ; Tue, 30 Dec 2025 13:23:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lBamiEQy3DN3DCzO+ay2wPm3yXsvknh9NRFFfscsXcE=; b=KLKZdTajAmQZd2KK DmQf3wD5kU2AFMCawtEBQNHaXcSnTgjeNAVIb0i6E8fOCY/JKoqrNTEnzdGZW6GF kckEENW9V8fhfMVrO+GrrmWv/WDV955MRsuMuSjBXPPnthD6zjveCsB9+GzCiJA3 LXPLbQaQwcie6rNPHbUSLiwn8PB1hEpu7lH1XLBOAPBEknRZ12+OkBm9lTzgd+2C WA0vNWvdfnMCB9BGX4PSbViDZLi1R8suPnu+858XMvH39ucHRJy25jMH9vWkunC6 R/5ZNtQn9PW8OryvSkotuOKZRzrTen/JWQz18E/h1G5MNqnHvaBRMpfKdk2ZIIQa VAfwEg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bc0skhxgu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Dec 2025 13:23:58 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ee05927208so44289171cf.1 for ; Tue, 30 Dec 2025 05:23:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767101038; x=1767705838; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lBamiEQy3DN3DCzO+ay2wPm3yXsvknh9NRFFfscsXcE=; b=DO98EiILB4e6vvHte7PPCTEWD6ps8Zs/jMZ2hMqxXDsP5GhqvigjVqQX+sg0xyLGqS RswhSixw4gksk44s2e4ae3JJaozxbwr6/Tyq0glUhXZfW9VEsVVsaU/oC9x73OLK4jk4 51qP3QAkc5jQ1K3m35yowXj+dG5oDoEemsOP2lYz3Ompw5ujJ6gYMsKglJFoqQrReetB ftylkO0y6nqiveW0SwwaB1ufVd6pX8zxXdyfwikv1GeJrdTAiXTc9gf4HPSUFAQiX6m6 FM7/Fm5H8BSyPamYQo2pH63tWBKE7YdIxabStq9U2r+q47/plUnELCvxCwAto+RKqC0P ZCUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767101038; x=1767705838; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lBamiEQy3DN3DCzO+ay2wPm3yXsvknh9NRFFfscsXcE=; b=aJnbDJP2P2RcKvt0HDZyEDmTM4oUTSnGRKtGjACbYR6lUic9B138z1Z9r7UDfxd9vI mMjTnK6t46SL5KAorqLwniKRzoAiBYvTqBLEHVlvXJiB/xjgCO0Grxyu9u/HFigitvy2 MC5jl9P4VOOP/dEfIU30Zin4DjKXqNzsJbz7l3NdSLqK/vV1kvm2qO/RddVcZb5OD8+k varjzbCzVlZjBWUd8hnJMW/xYsiyuWViiQ9F8HehHXNAdX/GngAkk2C6I4n48apbsXHK L00e6jS+9K5jaTbWVOlHlYxRNb+4DLi0ZqTIX1IDXyevcWeR6910cUvX6bOcwgOqBubT m2Uw== X-Forwarded-Encrypted: i=1; AJvYcCXyTXoQOfPLqJBPIhhf6TOxsbdI4tinTyGnI0Eg2rW+Nye5MZq2faOBiHNztqJguY/40iYGZVXobW8JrvQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3kFMndbEvp04lEx/7cHEMqZ/X0m0ps2ovBFv4nEPAWefkXChu DZtV/KYGsVFo78fd/bGNxzVIpWvmM6XBc2PWJJqH0CVvW7mhwXNiiQGszC4UDHO/cdk2xHHaOvm xDRHotULQ96rQc9LhuJ/WuvSs6HI5x4HMkGPwE4RnawW16zvIVzwYjtCP87EvDwxvOybEc2PZBT w= X-Gm-Gg: AY/fxX41ZPfdmWkSKJ9ksvnBfLXvvt5eu2E/i+F44/esOwnzDCww1o/xyTvAfUitbof elGSXiE64wJN446lBAaR3t1aalxULU1vnT3VWoszVW9dY11LS8R7SlQyJzn/ow9rMmnIosyn0SC uJS7QleInH4OfG1Q7zIGyBfeNziFqUfBVJF/6O9m5CNgavo4p8ElrPQOxGZ7D7HBSV1haoKu1Fu shziefKc0vjuReRtbjTEXpVStUNgGjl1IgXrY/9o10XRdx6eBCe7VxgCsr78I2mGHuZzRu3cuQY d/DMV379D4wPd/2bwIxqVmrMSZT0Ag7TMeUODOzSO/JQO/nEmmGpstRdM2XfIgfi6tv7s2/M4QO 1abw4JqXqwcbIEga8AaaSx4Bq2NIirGQ2NZKvJgi9dxm1LSGW3rrC+sxLmTBRTORH8g== X-Received: by 2002:ac8:5e4f:0:b0:4ec:f9c2:c1ec with SMTP id d75a77b69052e-4f4abdc5c87mr381306341cf.9.1767101038032; Tue, 30 Dec 2025 05:23:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IGL3EgR/boC+rDExbmIrfZeSeIUUjNzzXVRssTn+sUtVRW2phBtE0fgvFV4J8KeAfmDw7S9NQ== X-Received: by 2002:ac8:5e4f:0:b0:4ec:f9c2:c1ec with SMTP id d75a77b69052e-4f4abdc5c87mr381306081cf.9.1767101037616; Tue, 30 Dec 2025 05:23:57 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037a62973sm3702301866b.6.2025.12.30.05.23.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Dec 2025 05:23:57 -0800 (PST) Message-ID: Date: Tue, 30 Dec 2025 14:23:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] misc: fastrpc: Sanitize address logging and remove tabs To: Ekansh Gupta , srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com, stable@kernel.org References: <20251230110225.3655707-1-ekansh.gupta@oss.qualcomm.com> <20251230110225.3655707-2-ekansh.gupta@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251230110225.3655707-2-ekansh.gupta@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMwMDEyMCBTYWx0ZWRfX5DGi8VNYrqZl cnLAkQFuOGZhcds6jQI8PcKaYLZtZFQaWKNyxvwt25t364Iz0835WPAhRYlQrEvm9zQqeks7ZkW KLbptZ6p+bdVdv/RMe7GsIM6eeuIzpnNEGYso+ZF/BJG/D1bTY/OsJRzr8BuKE7rVZDjsVRxLFw GydT7GG7qn2axEmDW6QNyxiRybvzSl9XMbZOI5iulsSwvY16yI/ff0lMJxbZBRaIz6+XofXbBey ZJE0dWHZOuBAxQUvfdQAFdiWraJDgFGLvA6aV1mmq8vSEhBISbY7JS2EQwfRqDWmPuSi+7iWTC5 ph6aXt5etBznbIX6YPv32QxHoUMrWzkMfFBeeWcLHCuUoyI5QwaNdbKD+b54T3Ecpj/FxPXLu0J Uw1nmddgkioNv5aAtZbIQcf9/Osn6qQ+M77mmTM3md2YaERcr13/mMlTGzxGuBiVEjhdt6RuWNt vLhq2zqhGJMv/TaEtqA== X-Proofpoint-ORIG-GUID: dGXoXXu3RhMysUU9duzgaFewNPqKpRqN X-Proofpoint-GUID: dGXoXXu3RhMysUU9duzgaFewNPqKpRqN X-Authority-Analysis: v=2.4 cv=FJ0WBuos c=1 sm=1 tr=0 ts=6953d26e cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=97OCAh6v3L_eXYMdJ_MA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-30_01,2025-12-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 impostorscore=0 spamscore=0 phishscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512300120 On 12/30/25 12:02 PM, Ekansh Gupta wrote: > Avoid printing raw addresses in driver logs by using %p for remote > buffer addresses. This reduces the risk of information leaks and > conforms to kernel logging guidelines. Remove tabs in dev_* > messages. > > Fixes: 2419e55e532d ("misc: fastrpc: add mmap/unmap support") > Cc: stable@kernel.org > Signed-off-by: Ekansh Gupta > --- > drivers/misc/fastrpc.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c > index ee652ef01534..408fe47e9db7 100644 > --- a/drivers/misc/fastrpc.c > +++ b/drivers/misc/fastrpc.c > @@ -1830,13 +1830,13 @@ static int fastrpc_req_munmap_impl(struct fastrpc_user *fl, struct fastrpc_buf * > err = fastrpc_internal_invoke(fl, true, FASTRPC_INIT_HANDLE, sc, > &args[0]); > if (!err) { > - dev_dbg(dev, "unmmap\tpt 0x%09lx OK\n", buf->raddr); > + dev_dbg(dev, "unmap OK: raddr=%p\n", (void *)(unsigned long)buf->raddr); Would it be easier if we did away with the uintptr_t, since the protocol seems to assume all addresses are u64s anyway? Konrad