From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: rostedt@goodmis.org
Cc: linux-kernel@vger.kernel.org, Tom Zanussi <tom.zanussi@linux.intel.com>
Subject: [PATCH 2/2] tracing: Remove redundant destroy_call_preds() call
Date: Sun, 10 Nov 2013 23:03:46 -0600 [thread overview]
Message-ID: <a8ce7c51137ff8770f3e6a0e19e019a5c99f131b.1384145701.git.tom.zanussi@linux.intel.com> (raw)
In-Reply-To: <cover.1384145701.git.tom.zanussi@linux.intel.com>
In-Reply-To: <cover.1384145701.git.tom.zanussi@linux.intel.com>
Before calling destroy_call_preds(), __trace_remove_event_call() calls
event_remove(), which ends up calling destroy_call_preds() (via
destroy_preds()) if USE_CALL_FILTER is set. That means the second
call is redundant and can be removed.
Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Reported-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/trace_events.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index f919a2e..a14f6a1 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -1708,7 +1708,6 @@ static void __trace_remove_event_call(struct ftrace_event_call *call)
{
event_remove(call);
trace_destroy_fields(call);
- destroy_call_preds(call);
}
static int probe_remove_event_call(struct ftrace_event_call *call)
--
1.8.3.1
prev parent reply other threads:[~2013-11-11 5:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 5:03 [PATCH 0/2] tracing: a couple minor for-next fixes Tom Zanussi
2013-11-11 5:03 ` [PATCH 1/2] tracing: Add __rcu to enter/exit_syscall_files Tom Zanussi
2013-11-11 5:03 ` Tom Zanussi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8ce7c51137ff8770f3e6a0e19e019a5c99f131b.1384145701.git.tom.zanussi@linux.intel.com \
--to=tom.zanussi@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®