From: "Jürgen Groß" <jgross@suse.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Mario Limonciello <mario.limonciello@amd.com>,
"moderated list:XEN HYPERVISOR INTERFACE"
<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen: take system_transition_mutex on suspend
Date: Mon, 22 Sep 2025 08:06:26 +0200 [thread overview]
Message-ID: <a8d1d076-81b0-424e-b281-dfbd49130d38@suse.com> (raw)
In-Reply-To: <20250921162853.223116-1-marmarek@invisiblethingslab.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 747 bytes --]
On 21.09.25 18:28, Marek Marczykowski-Górecki wrote:
> Xen's do_suspend() calls dpm_suspend_start() without taking required
> system_transition_mutex. Since 12ffc3b1513eb moved the
> pm_restrict_gfp_mask() call, not taking that mutex results in a WARN.
>
> Take the mutex in do_suspend(), and use mutex_trylock() to follow
> how enter_state() does this.
>
> Suggested-by: Jürgen Groß <jgross@suse.com>
> Fixes: 12ffc3b1513eb "PM: Restrict swap use to later in the suspend sequence"
> Link: https://lore.kernel.org/xen-devel/aKiBJeqsYx_4Top5@mail-itl/
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> Cc: stable@vger.kernel.org # v6.16+
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2025-09-22 6:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-21 16:28 Marek Marczykowski-Górecki
2025-09-22 6:06 ` Jürgen Groß [this message]
2025-09-24 16:24 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8d1d076-81b0-424e-b281-dfbd49130d38@suse.com \
--to=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=marmarek@invisiblethingslab.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=rafael.j.wysocki@intel.com \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®