From: Alexey Dobriyan <adobriyan@gmail.com>
To: Vincent Mailhol <mailhol@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Alexander Lobakin <alobakin@pm.me>, Arnd Bergmann <arnd@arndb.de>,
David Sterba <dsterba@suse.cz>, Ivo van Doorn <ivdoorn@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] container_of: remove useless pair of parentheses
Date: Wed, 15 Jul 2026 17:30:42 +0300 [thread overview]
Message-ID: <a8d8b317-4d2a-4398-9968-37e02a328686@p183> (raw)
In-Reply-To: <20260714-containerof_refactor-v1-2-b5c31164d2ad@kernel.org>
On Tue, Jul 14, 2026 at 08:18:02PM +0200, Vincent Mailhol wrote:
> The last expression in container_of() doesn't need an extra pair of
> parenthesis. Remove it.
>
> Signed-off-by: Vincent Mailhol <mailhol@kernel.org>
> ---
> include/linux/container_of.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/container_of.h b/include/linux/container_of.h
> index 28500a62ab7e..68153170db32 100644
> --- a/include/linux/container_of.h
> +++ b/include/linux/container_of.h
> @@ -21,7 +21,7 @@
> static_assert(__same_type(*(ptr), typeof_member(type, member)) || \
> __same_type(*(ptr), void), \
> "pointer type mismatch in container_of()"); \
> - ((type *)(__mptr - offsetof(type, member))); })
> + (type *)(__mptr - offsetof(type, member)); })
container_of_const() has the same problem. And it should parenthesize
first argument to _Generic.
next prev parent reply other threads:[~2026-07-15 14:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 18:18 [PATCH 0/3] container_of: refactors Vincent Mailhol
2026-07-14 18:18 ` [PATCH 1/3] container_of: apply typeof_member() to container_of() Vincent Mailhol
2026-07-14 18:18 ` [PATCH 2/3] container_of: remove useless pair of parentheses Vincent Mailhol
2026-07-15 14:30 ` Alexey Dobriyan [this message]
2026-07-15 14:51 ` Vincent Mailhol
2026-07-15 14:57 ` Greg Kroah-Hartman
2026-07-15 16:27 ` Vincent Mailhol
2026-07-16 14:09 ` Greg Kroah-Hartman
2026-07-14 18:18 ` [PATCH 3/3] container_of: remove local __mptr variable Vincent Mailhol
2026-07-15 4:54 ` [PATCH 0/3] container_of: refactors Greg Kroah-Hartman
2026-07-15 5:33 ` Vincent Mailhol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8d8b317-4d2a-4398-9968-37e02a328686@p183 \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alobakin@pm.me \
--cc=arnd@arndb.de \
--cc=dsterba@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=ivdoorn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mailhol@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox