From: Dan Carpenter <dan.carpenter@linaro.org>
To: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
Cc: gregkh@linuxfoundation.org, dpenkler@gmail.com,
~lkcamp/patches@lists.sr.ht, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: gpib: fix style at nec7210_t1_delay definition
Date: Wed, 12 Feb 2025 10:07:48 +0300 [thread overview]
Message-ID: <a8da3395-e383-48d2-8c1e-fa70874ad551@stanley.mountain> (raw)
In-Reply-To: <20250212024247.176572-3-rodrigo.gobbi.7@gmail.com>
On Tue, Feb 11, 2025 at 11:35:37PM -0300, Rodrigo Gobbi wrote:
> due a change of the return type of t1_delay function, checkpatch
> was triggering a style error.
>
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
This should be folded into the previous patch. Generally we avoid
introducing checkpatch warnings and then fixing them later. Sometimes
that ignoring checkpatch and then fixing it later can make the review
easier if a patch is really massive but this change is only medium sized.
regards,
dan carpenter
prev parent reply other threads:[~2025-02-12 7:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 2:35 [PATCH 0/2] staging: gpib: change return type of t1_delay function to report errors Rodrigo Gobbi
2025-02-12 2:35 ` [PATCH 1/2] " Rodrigo Gobbi
2025-02-12 7:05 ` Dan Carpenter
2025-02-12 2:35 ` [PATCH 2/2] staging: gpib: fix style at nec7210_t1_delay definition Rodrigo Gobbi
2025-02-12 7:07 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8da3395-e383-48d2-8c1e-fa70874ad551@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=rodrigo.gobbi.7@gmail.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®