From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91DC51FC8 for ; Wed, 29 Jul 2026 18:54:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785351284; cv=none; b=s9lIJEb6gbRFlpeoKMxQBwWqD8Ee2LV+Zt6L9inNmoMrGmwhX7XIZfqWxcJmmY0H4gowg8QtfqFuvGe8CQmBwEWh92olYaqXzE/RU+0maTrEozIw/8CDnlxRwpEjVQTLOJt6GTt7SDkFaJzXh9+Z0Xn4UT6URGdG9QVYEhywOss= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785351284; c=relaxed/simple; bh=mIdBjX8uWqj3jMTW4Q4CHO0TOmt+GQF84JHyOLNKTHY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nGLmFHItc2MTQ9pc75lvw45VR9JLoAZr9tqpDUSU+4DOnJYp6QReo92906bUHYmFAmaeHB7wHMd81kNC2WrE/XJkgGKm49PZMm2f1Et+eCeBYyznXwPaxu16/PUt2m9C4pOfvK0YPzUjbXySPjo+OgaWV0trAuxFhUTxTorVQWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CpMHFBK0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=beub8Z4a; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CpMHFBK0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="beub8Z4a" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66TISdhi2177809 for ; Wed, 29 Jul 2026 18:54:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GGb/D0+cHzWfDdgb8vv4OyJOIxrUr1v/2y04Z8q3NrA=; b=CpMHFBK0Dt3WId6t 94I3Gp4gLVZx+iRAu4EGJk19Pgd2L29Szjb1iMI214t1oAG3jWxypJSPfIJ/qRKj sijV3O6LKp0e6/qq+5zecS0Ga9RG+BeHfKbb0h0Un6ffOmTUDiticdMCLI+P+eYB umAbrER3dIeFaLdDEJ9shbRKuRQNf4BYc/r5lT8pQPyHEUsTLkLs+7Cr3yklMKTk QRBMRSyQa6wSabS+/iSfa07huE6x5ZiD0WbMcNKtFRvAWP0KNTbsxhoUXmc9MZX8 jXxKCtHMS6BdMRru09gYb3R0QoZ9TzP8DwU7o8AVps4QGMAM+ks/QAZlwPIb8dVV 2aDvcQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fqps2r4ct-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Jul 2026 18:54:34 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cee894b3d8so22761865ad.2 for ; Wed, 29 Jul 2026 11:54:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785351216; x=1785956016; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=GGb/D0+cHzWfDdgb8vv4OyJOIxrUr1v/2y04Z8q3NrA=; b=beub8Z4a88InJOQ+lJ6w2KDnLDp/Q1qdyHNXWy8zDHYXdwS7DmmTU97RxiACU+Y+xl rR5d+gNu57UmrvuIZ/pfBi7prDEmMRkK4Qo9C8d0HfCzcnv8W7V/Ft7wP6q200Ap0C8h JtPBzT/Pmrum42Ouf0ar7Nc5RsynTe78w45I3uEIERM5fvKMSCV7J5JxZHeHl1fSeafo xy3XBPBM3S+UoSAWHmKlGasFwnobe/ML7vxA7qyly5BukXM1lyvCNe7t4iqzKrdE1Y4X nlm0G2wf1FFLVScA72WoC+8q2hCDo7afIyvyk0pW0C+JldaHnf5i4bIY0QyXbWMmbVUo M7yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785351216; x=1785956016; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GGb/D0+cHzWfDdgb8vv4OyJOIxrUr1v/2y04Z8q3NrA=; b=e+sK7k8MSnVy9fokwtK2Rx5BxThH1kM4/eqc+us5u6vnSqjFt5YUWt+2C+CKPd7j18 +iejOM/8dDDLM8Czb8dYwX8dmAWA7eMiz5n1G1FuSkZ3VbozEb6Zt9zuu63s5Lj8JkPR hakKuI9pqlzsQe2eJOd17HHVjayRoYccQPLeJp7CDAaFrIBZjimXH4ntE9ahawFsVrsw pNZxpsU/5pKJOlGpEVgqeXGrdo4KHlJAv5yYCDxFofU7KZ3THKVCUxpzWq3O8dBqvIfL mdNwFwdtoNYB0ffCI/7qc+SDqpNlMTyWIHCq3WrdstL4MMaJGKmXOi730Ez3tlsmQMOf 0OIw== X-Forwarded-Encrypted: i=1; AHgh+Rr0dYA034ZmcXLTmBe/fV/2o3F5Dnp5f/0GMFBPpsDqMm8Xvb/B0eVWbzVd2fnMPpsxGv8erxd3TLK+6zs=@vger.kernel.org X-Gm-Message-State: AOJu0Yxtujssrrm92jQK9rKVgdpTm4v9LnVU0qBW24PA4jf5NjVcb0yp +W/AkzPi5YHF8G2Gu6Fh/pn/GbkdiJM7zeTjhEIUv6Xi1/Pyw83uIjboT9yK+t028Iekf75dsmy FbNPNDXGLbBSfj9qMcUnK+4jmR5WvSgLz+W9j+LpnHhgRLmH5FZnpNUDX8L5RWNccPkY= X-Gm-Gg: AR+sD12sFP62kv1w3u6Ah3gXlJQQ+1tX0V9fH8oUrVFvKEOrHI5S+jOpOe5/MMcqayV yal0M20aX7ZYUngUJpVmCdI9z8UUtwqSN44ssOzgMCBW+KfT/SyoM8jKUF/gT9B0stc2OLhGTUB TjZaodHfaGQUapc5281NWO7uiQp65TFH3djw+tA1chW7w6GRDyLcblU1E+KmR4fTWpaqHtGPHXt 4HIGZq3EL2h6g2wIVrsQbq6qUIjeY0giSCb9ehE80CrqMaxTa68eZNP5XGudk28YbXlddRJdXjT i4I+MA5ZBqxRmK9yQy/hxz6wcJo+Ob+WbWWaFSkbbDD+5o61oOaVia2C2WfIk42D/+DM4BpbWcT pgD+aV9EWVAy46+zfZdH2UIe+JK2sf91dHHOkIHV7gHAaZCbWFJc3MdiZ3fAe X-Received: by 2002:a17:903:19e4:b0:2cc:c9cb:371c with SMTP id d9443c01a7336-2d033d576c7mr632895ad.40.1785351215751; Wed, 29 Jul 2026 11:53:35 -0700 (PDT) X-Received: by 2002:a17:903:19e4:b0:2cc:c9cb:371c with SMTP id d9443c01a7336-2d033d576c7mr632705ad.40.1785351215381; Wed, 29 Jul 2026 11:53:35 -0700 (PDT) Received: from [10.227.110.203] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31504baa01dsm13218325eec.12.2026.07.29.11.53.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jul 2026 11:53:34 -0700 (PDT) Message-ID: Date: Wed, 29 Jul 2026 11:53:32 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: zd1211rw: reject secondary interfaces to prevent conflicts To: syzbot , syzkaller-bugs@googlegroups.com, Slawomir Stepien , linux-wireless@vger.kernel.org, Daniel Drake Cc: johannes.berg@intel.com, kees@kernel.org, linux-kernel@vger.kernel.org, nihaal@cse.iitm.ac.in, syzbot@lists.linux.dev References: <0720e3ad-d98e-47d7-89af-4d22416b0fbc@mail.kernel.org> From: Jeff Johnson Content-Language: en-US In-Reply-To: <0720e3ad-d98e-47d7-89af-4d22416b0fbc@mail.kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: NRdzx40RHcgD4q_OoHanBnbo8TKQNrrw X-Proofpoint-ORIG-GUID: NRdzx40RHcgD4q_OoHanBnbo8TKQNrrw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI5MDE0NCBTYWx0ZWRfX0KwAIjcoykPk bg2nEy/O3JhBg1+Im1hIjXAzD2KRmtdKM2kJti48oTA2pwCi39OXAx6CfrFTzsSa2qahQq792dO glp1S3aXtDdZuINxI0Yqft65Lb2gBA/R9ymaBWgMuVzZDWXCa3u8uW4zfL4TP/1W/ezjgqaZnK3 ZSoZ42IWBed4x4jCvwS7iIACD3iOpGKaV3Y1xxv/ZKVNWlKgbD4KCbEggjOxuVkPF8XW9Uad+cU rYAYKvSZIuYNgsUSLxlFx7W8Nbdxzc9R7T2LLTB4duRTMwEWpTxXCrTNvacriqhViMzqfbUX2MB RrBGw/GPO+hvRxwTfU0eJRrMlxU2wV70RGL9gHRENU0yFGljJE8oBMk1t/qeZbe6VaUtQG01CwS GG0Xc6XBHI8LhB8E8Ql2aixx3b6oopvcrGRDgX48yBkbbL8RVpvtnkMWvL1Et4rHtM9jXzC74UD D0bNXYKi+rxjtwBUOHQ== X-Authority-Analysis: v=2.4 cv=YaSNIQRf c=1 sm=1 tr=0 ts=6a6a4c6d cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=hi2ICmPa-PouKQFzbIkA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI5MDE0NCBTYWx0ZWRfX7Eu3enfbkDxO 1qhFgD4yWH3Tz22PrwQ11t7c0zfwd1EN9HD4exeMSIUvULH+tAaU4VzRfT5AM7Npg2rz0nPWvrr MTWTTIjDnjXf5QAJphbUWTjWLKSRS94= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-29_07,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 phishscore=0 adultscore=0 suspectscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607290144 On 7/29/2026 1:04 AM, syzbot wrote: > @@ -1353,6 +1353,13 @@ static int probe(struct usb_interface *intf, const struct usb_device_id *id) > struct zd_usb *usb; > struct ieee80211_hw *hw = NULL; > > + /* ZD1211 devices are single-function. Reject secondary interfaces this does not follow linux block comment style /* should be on a separate line (at one time networking code had a different style, but not now) > + * to prevent multiple instances from conflicting on hardcoded endpoints > + * and triggering recursive locking warnings. > + */ > + if (intf->cur_altsetting->desc.bInterfaceNumber != 0) > + return -ENODEV; > + > print_id(udev); > > if (id->driver_info & DEVICE_INSTALLER) > > > base-commit: 1590cf0329716306e948a8fc29f1d3ee87d3989f