mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "young dave" <hidave.darkstar@gmail.com>
To: "Steven French" <sfrench@us.ibm.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"David Kleikamp" <shaggy@us.ibm.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Shirish S Pargaonkar" <shirishp@us.ibm.com>
Subject: Re: 2.6.22-rc1-mm1 cifs_mount oops
Date: Thu, 24 May 2007 01:05:03 +0000	[thread overview]
Message-ID: <a8e1da0705231805j47fb7438k1a2f5926b20835f9@mail.gmail.com> (raw)
In-Reply-To: <OF5C2BA51B.B63E317D-ON872572E4.00793F56-862572E4.007A3D2C@us.ibm.com>

Hi,

I have one problem about this:  after the srvTcp->tsk is set to NULL
(maybe the thread is  still there, isn't it?), is the kthread still
needed to be stopped by calling kthread_stop()? If it is true, then
the task_struct should be saved before send_sig like my patch:

                        if (srvTcp->tsk) {
+                               struct task_struct * tsk = srvTcp->tsk;
                               send_sig(SIGKILL,srvTcp->tsk,1);
-                               kthread_stop(srvTcp->tsk);
+                               kthread_stop(tsk);

Regards
dave

  reply	other threads:[~2007-05-24  1:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-23  0:50 young dave
2007-05-23  2:22 ` Andrew Morton
2007-05-23  2:59   ` young dave
2007-05-23  3:21     ` Andrew Morton
2007-05-23  7:16       ` young dave
2007-05-23  8:37       ` young dave
2007-05-23 13:28         ` Steven French
2007-05-23 16:10           ` Andrew Morton
2007-05-23 22:14             ` Steven French
2007-05-24  1:05               ` young dave [this message]
2007-05-24  2:38                 ` Steven French
2007-05-23 13:56   ` Steven French
2007-05-23 14:59 Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8e1da0705231805j47fb7438k1a2f5926b20835f9@mail.gmail.com \
    --to=hidave.darkstar@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfrench@us.ibm.com \
    --cc=shaggy@us.ibm.com \
    --cc=shirishp@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®