From: "young dave" <hidave.darkstar@gmail.com>
To: "Matt Keenan" <tank.en.mate@gmail.com>
Cc: "Jeff Garzik" <jeff@garzik.org>,
"J. Bruce Fields" <bfields@fieldses.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
neilb@suse.de, nfs@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [NFS] [PATCH] NFSD: fix uninitialized variable
Date: Tue, 29 May 2007 08:32:42 +0000 [thread overview]
Message-ID: <a8e1da0705290132l328f1e4t10d2c0495d46f5fe@mail.gmail.com> (raw)
In-Reply-To: <465BD64A.3040302@gmail.com>
Hi, matt
embarrassed :)
below resend it.
diff -dur linux/fs/nfsd/nfs4acl.c linux.new/fs/nfsd/nfs4acl.c
--- linux/fs/nfsd/nfs4acl.c 2007-05-29 12:28:29.000000000 +0000
+++ linux.new/fs/nfsd/nfs4acl.c 2007-05-29 16:32:26.000000000 +0000
@@ -183,8 +183,6 @@
summarize_posix_acl(struct posix_acl *acl, struct posix_acl_summary *pas)
{
struct posix_acl_entry *pa, *pe;
- pas->users = 0;
- pas->groups = 0;
pas->mask = 07;
pe = acl->a_entries + acl->a_count;
@@ -229,6 +227,7 @@
int eflag = ((flags & NFS4_ACL_TYPE_DEFAULT) ?
NFS4_INHERITANCE_FLAGS | NFS4_ACE_INHERIT_ONLY_ACE : 0);
+ memset(pas, 0, sizeof(struct posix_acl_summary));
BUG_ON(pacl->a_count < 3);
summarize_posix_acl(pacl, &pas);
next prev parent reply other threads:[~2007-05-29 8:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-27 10:34 Jeff Garzik
2007-05-29 3:00 ` [NFS] " J. Bruce Fields
2007-05-29 3:19 ` Jeff Garzik
2007-05-29 4:31 ` young dave
2007-05-29 7:29 ` Matt Keenan
2007-05-29 8:32 ` young dave [this message]
2007-05-29 19:52 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8e1da0705290132l328f1e4t10d2c0495d46f5fe@mail.gmail.com \
--to=hidave.darkstar@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
--cc=tank.en.mate@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®