From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1757133AbXGZEU0@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757133AbXGZEU0 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 Jul 2007 00:20:26 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750953AbXGZEUR
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 26 Jul 2007 00:20:17 -0400
Received: from nz-out-0506.google.com ([64.233.162.230]:56547 "EHLO
	nz-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750921AbXGZEUQ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 Jul 2007 00:20:16 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=D/f1+x74xXjNpbr/sd3Tf2OGNyOU+laHSuMQ0itS8+pCf7NZay+dPq9HOQm9uQWfoloHgFkdOTH2VBavbXAPCq1r/zNCgZFNqt6JumMEQlGGtrhkt0NY+UBJNWtovBNwwNqCvKNy+wWMs1Vg9wCDoRt6HhiafzbBD3A6OojBxqo=
Message-ID: <a8e1da0707252120l5e9e441bm53e2ba25bc9c20f0@mail.gmail.com>
Date: Thu, 26 Jul 2007 04:20:10 +0000
From: "Dave Young" <hidave.darkstar@gmail.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH]gx-suspmod.c use boot_cpu_data instead of current_cpu_data
Cc: linux-kernel@vger.kernel.org, "Dave Jones" <davej@codemonkey.org.uk>,
       cpufreq@www.linux.org.uk
In-Reply-To: <20070724234045.2cec5525.akpm@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20070725141905.GA4567@darkstar.te-china.tietoenator.com>
	 <20070724234045.2cec5525.akpm@linux-foundation.org>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

>On 7/25/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Wed, 25 Jul 2007 14:19:05 +0000 Dave Young <hidave.darkstar@gmail.com> wrote:
>
> > Hi,
> > in preemptible kernel will report BUG: using smp_processor_id() in preemptible, so use boot_cpu_data instead of current_cpu_data.
> >
> > Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
> >
> > ---
> > arch/i386/kernel/cpu/cpufreq/gx-suspmod.c |    4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff -pur linux/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c linux.new/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
> > --- linux/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c   2007-07-25 14:11:06.000000000 +0000
> > +++ linux.new/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c       2007-07-25 13:57:29.000000000 +0000
> > @@ -181,8 +181,8 @@ static __init struct pci_dev *gx_detect_
> >       struct pci_dev *gx_pci = NULL;
> >
> >       /* check if CPU is a MediaGX or a Geode. */
> > -     if ((current_cpu_data.x86_vendor != X86_VENDOR_NSC) &&
> > -         (current_cpu_data.x86_vendor != X86_VENDOR_CYRIX)) {
> > +     if ((boot_cpu_data.x86_vendor != X86_VENDOR_NSC) &&
> > +         (boot_cpu_data.x86_vendor != X86_VENDOR_CYRIX)) {
> >               dprintk("error: no MediaGX/Geode processor found!\n");
> >               return NULL;
> >       }
>
> um, I suspect it really wants to get at the current CPU.  But putting a
> preempt_disable() around just that code is meaningless: the current CPU
> could change immediately before or after the code block. It needs deeper
> fixing, methinks.
The only target is to get the cpu vendor, so boot_cpu_data is enough,
the drivers/mtd/nand/cs553x_nand.c has the same usage.