mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Dave Young" <hidave.darkstar@gmail.com>
To: "Stefan Richter" <stefanr@s5r6.in-berlin.de>
Cc: "Matthew Wilcox" <matthew@wil.cx>,
	gregkh@suse.de, linux-kernel@vger.kernel.org,
	linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 06/12] pci : Use mutex instead of semaphore in driver core
Date: Wed, 2 Jan 2008 10:29:41 +0800	[thread overview]
Message-ID: <a8e1da0801011829p15da81dcw9db0f7cbb5444467@mail.gmail.com> (raw)
In-Reply-To: <477632A7.6050208@s5r6.in-berlin.de>

On Dec 29, 2007 7:42 PM, Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> Matthew Wilcox wrote:
> > Patches should be self-contained for ease of bisecting.  I can't tell
> > whether this patch is correct or not because you haven't included all
> > the other places that need to change at the same time as this.
>
> I think a broken-up patch series isn't totally wrong to do for a first
> look at these RFC patches.  Of course the series needs to become a
> single patch before it is committed to a tree whose history needs to
> support bijection, e.g. -mm.
>
> However, Dave's postings lack a References: header which refer to his
> 00/12 posting.

Thanks.  I agree with you, for bitsection it should be a single one.

>
> (Also, a bonus in the 00/12 posting would be a listing of all patch
> titles in the series and the total diffstat of the series, but nearly
> nobody does this.)

Your sugestion is better.

And, andrew recommends not to use 00/xx introduction email in series
in his "The perfect patch":
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

> --
> Stefan Richter
> -=====-=-=== ==-- ===-=
> http://arcgraph.de/sr/
>

  parent reply	other threads:[~2008-01-02  2:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-29  1:10 Dave Young
2007-12-29  2:55 ` Matthew Wilcox
2007-12-29  5:08   ` Dave Young
2007-12-29 11:42   ` Stefan Richter
2007-12-29 12:16     ` Matthew Wilcox
2007-12-29 12:38       ` Stefan Richter
2008-01-02  2:29     ` Dave Young [this message]
2008-01-02 11:14       ` The perfect patch - Posting a patch series (was Re: [PATCH 06/12] pci : Use mutex instead of semaphore in driver core) Stefan Richter
2008-01-02 11:41         ` Jan Engelhardt
2008-01-02 13:05           ` The perfect patch - Posting a patch series Stefan Richter
2008-01-03  6:10         ` The perfect patch - Posting a patch series (was Re: [PATCH 06/12] pci : Use mutex instead of semaphore in driver core) Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8e1da0801011829p15da81dcw9db0f7cbb5444467@mail.gmail.com \
    --to=hidave.darkstar@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=matthew@wil.cx \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®