From: Dave Young <hidave.darkstar@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Gerd Hoffmann <kraxel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roland McGrath <roland@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org, James Morris <jmorris@namei.org>
Subject: Re: [PATCH 07/18] sysctl extern cleanup - compat
Date: Sat, 20 Feb 2010 23:16:30 +0800 [thread overview]
Message-ID: <a8e1da1002200716u1eb6224fr7b3d6eca1c015cb8@mail.gmail.com> (raw)
In-Reply-To: <201002201551.56851.arnd@arndb.de>
On Sat, Feb 20, 2010 at 10:51 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Saturday 20 February 2010 15:13:28 Dave Young wrote:
>> Extern declarations in sysctl.c should be move to their own head file,
>> and then include them in relavant .c files.
>>
>> Move compat_log extern declaration to linux/compat.h
>>
>> Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
>
> Good idea in principle, but please don't enclose the extern
> declaration in #ifdef:
>
>> --- linux-2.6.32.orig/include/linux/compat.h 2010-02-20 14:02:24.334925488 +0800
>> +++ linux-2.6.32/include/linux/compat.h 2010-02-20 14:24:30.405627048 +0800
>> @@ -17,6 +17,9 @@
>> #include <asm/siginfo.h>
>> #include <asm/signal.h>
>>
>> +#ifdef CONFIG_SYSCTL
>> +extern int compat_log;
>> +#endif
>> #define compat_jiffies_to_clock_t(x) \
>> (((unsigned long)(x) * COMPAT_USER_HZ) / HZ)
>
> This will force a rebuild of everything that #includes linux/compat.h when CONFIG_SYSCTL
> changes, while nothing really changes.
>
> Obviously, the same goes for the entire series.
Yes, indeed. Thanks for the comments.
Actually I need resend the whole patchset with a updated version.
>
> Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Regards
dave
prev parent reply other threads:[~2010-02-20 15:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-20 14:13 Dave Young
2010-02-20 14:51 ` Arnd Bergmann
2010-02-20 15:16 ` Dave Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8e1da1002200716u1eb6224fr7b3d6eca1c015cb8@mail.gmail.com \
--to=hidave.darkstar@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=jmorris@namei.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®