mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Young <hidave.darkstar@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Joe Perches <joe@perches.com>,
	linux-kernel@vger.kernel.org,
	Randy Dunlap <randy.dunlap@oracle.com>,
	Li Zefan <lizf@cn.fujitsu.com>
Subject: Re: [PATCH 03/06] kernel.h hexdump cleanup
Date: Thu, 25 Feb 2010 11:27:29 +0800	[thread overview]
Message-ID: <a8e1da1002241927n53287c0xeab50d6d6d623d99@mail.gmail.com> (raw)
In-Reply-To: <20100224181646.bde9c183.akpm@linux-foundation.org>

On Thu, Feb 25, 2010 at 10:16 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Thu, 25 Feb 2010 09:52:49 +0800 Dave Young <hidave.darkstar@gmail.com> wrote:
>
>> On Tue, Feb 23, 2010 at 3:43 AM, Joe Perches <joe@perches.com> wrote:
>> > On Mon, 2010-02-22 at 22:19 +0800, Dave Young wrote:
>> >> hexdump stuff in kernel.h should be put into a standalone head file
>> >
>> > I think it'd be clearer to have logging functions
>> > in kernel.h split into a separate header or grouped
>> > a bit better in kernel.h.
>> >
>> > I would have kernel.h #include that header though
>> > rather than splitting out things like hexdump functions
>> > into a separate file requiring yet another #include in
>> > source files.
>>
>> Andrew, what do you think about this?
>
> Well.  Avoiding bisection-bustage is hardly a priority any more, but
> let's not break bisection this time if we can avoid it.

Thanks, see it.

>
>> Actually I hesitate to send this patch as well, too many recipients
>> needed from get_maintainer.pl.
>
> They'll live ;)
>



-- 
Regards
dave

  reply	other threads:[~2010-02-25  3:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-22 14:19 Dave Young
2010-02-22 19:25 ` Mike Frysinger
2010-02-25  1:52   ` Dave Young
2010-02-22 19:43 ` Joe Perches
2010-02-25  1:52   ` Dave Young
2010-02-25  2:16     ` Andrew Morton
2010-02-25  3:27       ` Dave Young [this message]
2010-02-25  3:39       ` Joe Perches
2010-02-25  4:44 ` Jaswinder Singh Rajput
2010-02-25  7:04   ` Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8e1da1002241927n53287c0xeab50d6d6d623d99@mail.gmail.com \
    --to=hidave.darkstar@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome