From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751188AbdE2QKr (ORCPT ); Mon, 29 May 2017 12:10:47 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:52080 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750987AbdE2QKp (ORCPT ); Mon, 29 May 2017 12:10:45 -0400 Subject: Re: [PATCH 02/15] iio: dac: stm32: use devm_of_platform_populate() To: Benjamin Gaignard CC: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Alexandre Torgue , , , References: <1496072763-31209-1-git-send-email-benjamin.gaignard@linaro.org> <1496072763-31209-3-git-send-email-benjamin.gaignard@linaro.org> From: Fabrice Gasnier Message-ID: Date: Mon, 29 May 2017 18:10:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1496072763-31209-3-git-send-email-benjamin.gaignard@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG5NODE2.st.com (10.75.127.14) To SFHDAG5NODE3.st.com (10.75.127.15) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-29_11:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/29/2017 05:45 PM, Benjamin Gaignard wrote: > Use devm_of_platform_populate() instead of of_platform_populate and > of_platform_depopulate to simplify driver code > > Signed-off-by: Benjamin Gaignard > > CC: Jonathan Cameron > CC: Hartmut Knaack > CC: Lars-Peter Clausen > CC: Alexandre Torgue > CC: Fabrice Gasnier > CC: linux-iio@vger.kernel.org > CC: linux-arm-kernel@lists.infradead.org > CC: linux-kernel@vger.kernel.org > --- > drivers/iio/dac/stm32-dac-core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/iio/dac/stm32-dac-core.c b/drivers/iio/dac/stm32-dac-core.c > index 75e4878..9c42537 100644 > --- a/drivers/iio/dac/stm32-dac-core.c > +++ b/drivers/iio/dac/stm32-dac-core.c > @@ -130,7 +130,7 @@ static int stm32_dac_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, &priv->common); > > - ret = of_platform_populate(pdev->dev.of_node, NULL, NULL, dev); > + ret = devm_of_platform_populate(&pdev->dev); > if (ret < 0) { > dev_err(dev, "failed to populate DT children\n"); > goto err_pclk; > @@ -151,7 +151,6 @@ static int stm32_dac_remove(struct platform_device *pdev) > struct stm32_dac_common *common = platform_get_drvdata(pdev); > struct stm32_dac_priv *priv = to_stm32_dac_priv(common); > > - of_platform_depopulate(&pdev->dev); Hi Benjamin, Same as patch 1, This is going to change order of sub devices removal. It may end-up with bellow resources being removed while sub-device still needs them. Not sure this is a good candidate for such a change. Best Regards, Fabrice > clk_disable_unprepare(priv->pclk); > regulator_disable(priv->vref); > >