mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	linux-kernel@vger.kernel.org
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	MyungJoo Ham <myungjoo.ham@samsung.com>
Subject: Re: [PATCH 2/2] extcon: max77843: add device-tree compatible string
Date: Fri, 6 Oct 2023 08:41:17 +0200	[thread overview]
Message-ID: <a8e81590-3fc5-4777-bd60-cea872592c56@kernel.org> (raw)
In-Reply-To: <20231005104327.981101-2-m.szyprowski@samsung.com>

On 05/10/2023 12:43, Marek Szyprowski wrote:
> Add the needed device-tree compatible string to the MAX77843 extcon
> driver, so it can be automatically loaded when compiled as a kernel
> module and given device-tree contains separate 'muic' node under the main
> MAX77843 PMIC node.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  drivers/extcon/extcon-max77843.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
> index 1bc0426ce3f1..e04ebdda886a 100644
> --- a/drivers/extcon/extcon-max77843.c
> +++ b/drivers/extcon/extcon-max77843.c
> @@ -946,6 +946,12 @@ static const struct platform_device_id max77843_muic_id[] = {
>  };
>  MODULE_DEVICE_TABLE(platform, max77843_muic_id);
>  
> +static const struct of_device_id of_max77843_muic_dt_match[] = {
> +	{ .compatible = "maxim,max77843-muic", },
> +	{ /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(of, of_max77843_muic_dt_match);

As robot reports, there is indeed no user of it. :/ You need to include
it in driver OF table or add maybe_unused.

Best regards,
Krzysztof


  parent reply	other threads:[~2023-10-06  6:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20231005104339eucas1p17e2b8f2886bbd529c207e68e8de18b01@eucas1p1.samsung.com>
2023-10-05 10:43 ` [PATCH 1/2] extcon: max77693: " Marek Szyprowski
     [not found]   ` <CGME20231005104339eucas1p147e85630eec0ec4b476a21ed2cd3650d@eucas1p1.samsung.com>
2023-10-05 10:43     ` [PATCH 2/2] extcon: max77843: " Marek Szyprowski
2023-10-05 10:57       ` Krzysztof Kozlowski
2023-10-06  6:41       ` Krzysztof Kozlowski [this message]
2023-10-05 10:58   ` [PATCH 1/2] extcon: max77693: " Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8e81590-3fc5-4777-bd60-cea872592c56@kernel.org \
    --to=krzk@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®