From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chen Wang <unicorn_wang@outlook.com>,
Chen Wang <unicornxw@gmail.com>,
aou@eecs.berkeley.edu, chao.wei@sophgo.com, conor@kernel.org,
krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
palmer@dabbelt.com, paul.walmsley@sifive.com,
richardcochran@gmail.com, robh+dt@kernel.org, sboyd@kernel.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
haijiao.liu@sophgo.com, xiaoguang.xing@sophgo.com,
guoren@kernel.org, jszhang@kernel.org, inochiama@outlook.com,
samuel.holland@sifive.com
Subject: Re: [PATCH v4 2/4] dt-bindings: clock: sophgo: Add SG2042 bindings
Date: Tue, 5 Dec 2023 16:52:59 +0100 [thread overview]
Message-ID: <a8f02782-375c-4b2c-9d09-fb5898c4f62d@linaro.org> (raw)
In-Reply-To: <MA0P287MB0332E148B9F8922E01758A5CFE85A@MA0P287MB0332.INDP287.PROD.OUTLOOK.COM>
On 05/12/2023 15:15, Chen Wang wrote:
>
> On 2023/12/5 16:08, Krzysztof Kozlowski wrote:
>> On 05/12/2023 01:23, Chen Wang wrote:
>>> From: Chen Wang <unicorn_wang@outlook.com>
>>>
>>> Add bindings for the clock generator on the SG2042 RISC-V SoC.
>> ......
>>> + - const: sophgo,sg2042-clkgen
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + system-ctrl:
>> Missing vendor prefix.
>
> hi, Krzysztof,
>
> One question: under what circumstances is it necessary to add the vendor
> prefix when defining a property?
Custom property, with exceptions of supplies, sometimes GPIOs. Please
see my talks. Twice...
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-05 15:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 0:22 [PATCH v4 0/4] riscv: sophgo: add clock support for sg2042 Chen Wang
2023-12-05 0:22 ` [PATCH v4 1/4] dt-bindings: soc: sophgo: Add Sophgo system control module Chen Wang
2023-12-05 8:06 ` Krzysztof Kozlowski
2023-12-05 0:23 ` [PATCH v4 2/4] dt-bindings: clock: sophgo: Add SG2042 bindings Chen Wang
2023-12-05 8:08 ` Krzysztof Kozlowski
2023-12-05 14:15 ` Chen Wang
2023-12-05 15:52 ` Krzysztof Kozlowski [this message]
2023-12-05 0:23 ` [PATCH v4 3/4] clk: sophgo: Add SG2042 clock generator driver Chen Wang
2023-12-05 1:13 ` Inochi Amaoto
2023-12-05 5:35 ` Chen Wang
2023-12-05 6:34 ` Inochi Amaoto
2023-12-06 1:35 ` Chen Wang
2023-12-05 0:24 ` [PATCH v4 4/4] riscv: dts: add clock generator for Sophgo SG2042 SoC Chen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8f02782-375c-4b2c-9d09-fb5898c4f62d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aou@eecs.berkeley.edu \
--cc=chao.wei@sophgo.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guoren@kernel.org \
--cc=haijiao.liu@sophgo.com \
--cc=inochiama@outlook.com \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=samuel.holland@sifive.com \
--cc=sboyd@kernel.org \
--cc=unicorn_wang@outlook.com \
--cc=unicornxw@gmail.com \
--cc=xiaoguang.xing@sophgo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®