From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754092AbdJIL5J (ORCPT <rfc822;w@1wt.eu>);
        Mon, 9 Oct 2017 07:57:09 -0400
Received: from mga07.intel.com ([134.134.136.100]:13234 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751621AbdJIL5A (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 9 Oct 2017 07:57:00 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,500,1500966000"; 
   d="scan'208";a="160989345"
Subject: Re: [PATCH v2] drm/atomic: Unref duplicated drm_atomic_state in
 drm_atomic_helper_resume()
To: Jeffy Chen <jeffy.chen@rock-chips.com>, linux-kernel@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org,
        Daniel Vetter <daniel.vetter@intel.com>
References: <20171009064641.15174-1-jeffy.chen@rock-chips.com>
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Message-ID: <a8fa4d03-e577-55c2-f2e7-8b1a9f8f1f3f@linux.intel.com>
Date: Mon, 9 Oct 2017 13:56:57 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20171009064641.15174-1-jeffy.chen@rock-chips.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Op 09-10-17 om 08:46 schreef Jeffy Chen:
> Kmemleak reported memory leak after suspend and resume:
> unreferenced object 0xffffffc0e31d8880 (size 128):
>   comm "bash", pid 181, jiffies 4294763583 (age 24.694s)
>   hex dump (first 32 bytes):
>     01 00 00 00 00 00 00 00 00 20 a2 eb c0 ff ff ff  ......... ......
>     01 00 00 00 00 00 00 00 80 87 1d e3 c0 ff ff ff  ................
>   backtrace:
>     [<ffffffc00034bb64>] __save_stack_trace+0x48/0x6c
>     [<ffffffc00034c244>] create_object+0x138/0x254
>     [<ffffffc0009dd218>] kmemleak_alloc+0x58/0x8c
>     [<ffffffc000346de4>] kmem_cache_alloc_trace+0x188/0x254
>     [<ffffffc0005af4c0>] drm_atomic_state_alloc+0x3c/0x88
>     [<ffffffc000591f0c>] drm_atomic_helper_duplicate_state+0x28/0x158
>     [<ffffffc000592098>] drm_atomic_helper_suspend+0x5c/0xf0
>
> Problem here is that we are duplicating the drm_atomic_state in
> drm_atomic_helper_suspend(), but not unreference it in the resume path.
>
> Fixes: 1494276000db ("drm/atomic-helper: Implement subsystem-level suspend/resume")
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> ---
>
> Changes in v2:
> Unref duplicated drm_atomic_state in drm_atomic_helper_resume() instead
> of specific drivers.
>
>  drivers/gpu/drm/drm_atomic_helper.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
> index 01c34bc5b5b0..4a262380c631 100644
> --- a/drivers/gpu/drm/drm_atomic_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_helper.c
> @@ -3052,6 +3052,7 @@ int drm_atomic_helper_resume(struct drm_device *dev,
>  		drm_modeset_backoff(&ctx);
>  	}
>  
> +	drm_atomic_state_put(state);
>  	drm_modeset_drop_locks(&ctx);
>  	drm_modeset_acquire_fini(&ctx);
>  

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Fixes: 0853695c3ba4 ("drm: Add reference counting to drm_atomic_state")
Cc: <stable@vger.kernel.org> # v4.10+

and pushed, thanks for finding it. :)

The bug is probably older than that commit, but only happened on failure paths before. If resume fails we probably have bigger issues than leaking some memory.