From: Logan Gunthorpe <logang@deltatee.com>
To: Leon Romanovsky <leon@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Alex Williamson <alex@shazbot.org>,
Ankit Agrawal <ankita@nvidia.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [PATCH] PCI/P2PDMA: Add missing struct p2pdma_provider documentation
Date: Mon, 5 Jan 2026 09:39:17 -0700 [thread overview]
Message-ID: <a8fc3e98-336a-4448-9ce6-db962bde1a1a@deltatee.com> (raw)
In-Reply-To: <20260104-fix-p2p-kdoc-v1-1-6d181233f8bc@nvidia.com>
On 2026-01-04 05:51, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Two fields in struct p2pdma_provider were not documented, which resulted
> in the following kernel-doc warning:
>
> Warning: include/linux/pci-p2pdma.h:26 struct member 'owner' not described in 'p2pdma_provider'
> Warning: include/linux/pci-p2pdma.h:26 struct member 'bus_offset' not described in 'p2pdma_provider'
>
> Repro:
>
> $ scripts/kernel-doc -none include/linux/pci-p2pdma.h
>
> Fixes: f58ef9d1d135 ("PCI/P2PDMA: Separate the mmap() support from the core logic")
> Reported-by: Bjorn Helgaas <helgaas@kernel.org>
> Closes: https://lore.kernel.org/all/20260102234033.GA246107@bhelgaas
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
LGTM
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
next prev parent reply other threads:[~2026-01-05 17:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 12:51 Leon Romanovsky
2026-01-05 16:39 ` Logan Gunthorpe [this message]
2026-01-06 22:18 ` Bjorn Helgaas
2026-01-06 22:57 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8fc3e98-336a-4448-9ce6-db962bde1a1a@deltatee.com \
--to=logang@deltatee.com \
--cc=alex@shazbot.org \
--cc=ankita@nvidia.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®