From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Jonathan Marek <jonathan@marek.ca>, Vinod Koul <vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Sanyog Kale <sanyog.r.kale@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] soundwire: qcom: add v1.5.1 compatible
Date: Wed, 10 Jun 2020 11:40:10 +0100 [thread overview]
Message-ID: <a8fddf74-9f95-9bc8-6e4f-5fb654c6a43c@linaro.org> (raw)
In-Reply-To: <53817047-f916-b042-70b7-66aa875a9ade@marek.ca>
On 09/06/2020 12:17, Jonathan Marek wrote:
> On 6/9/20 1:26 AM, Vinod Koul wrote:
>> On 08-06-20, 16:43, Jonathan Marek wrote:
>>> Add a compatible string for HW version v1.5.1 on sm8250 SoCs.
>>
>> Please document this new compatible
>>
>
> Does it really need to be documented? The documentation already says the
> compatible should be "qcom,soundwire-v<MAJOR>.<MINOR>.<STEP>". It gives
> "qcom,soundwire-v1.5.0" as an example, which is not actually a supported
> compatible, so my understanding is we don't need to update the list of
> examples with every possible compatible.
checkpatch should have reported about this, and in future once we
convert to yaml and list the compatible strings then dt_binding_check
would fail too. So there is no harm in adding an additional compatible
string for this new entry.
--srini
next prev parent reply other threads:[~2020-06-10 10:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 20:43 [PATCH 0/5] soundwire: qcom: add mmio support Jonathan Marek
2020-06-08 20:43 ` [PATCH 1/5] soundwire: qcom: fix abh/ahb typo Jonathan Marek
2020-06-09 9:18 ` Srinivas Kandagatla
2020-06-08 20:43 ` [PATCH 2/5] soundwire: qcom: add support for mmio soundwire devices Jonathan Marek
2020-06-08 21:31 ` Pierre-Louis Bossart
2020-06-09 4:34 ` Vinod Koul
2020-06-09 9:18 ` Srinivas Kandagatla
2020-06-09 11:20 ` Jonathan Marek
2020-06-09 9:19 ` Srinivas Kandagatla
2020-06-09 11:04 ` Jonathan Marek
2020-06-10 10:55 ` Srinivas Kandagatla
2020-06-08 20:43 ` [PATCH 3/5] soundwire: qcom: add v1.5.1 compatible Jonathan Marek
2020-06-09 5:26 ` Vinod Koul
2020-06-09 11:17 ` Jonathan Marek
2020-06-10 10:40 ` Srinivas Kandagatla [this message]
2020-06-08 20:43 ` [PATCH 4/5] soundwire: qcom: avoid dependency on CONFIG_SLIMBUS Jonathan Marek
2020-06-08 20:58 ` Jonathan Marek
2020-06-08 21:20 ` Pierre-Louis Bossart
2020-06-08 21:46 ` Jonathan Marek
2020-06-09 9:52 ` Srinivas Kandagatla
2020-06-09 11:33 ` Jonathan Marek
2020-06-10 10:36 ` Srinivas Kandagatla
2020-06-10 12:06 ` Jonathan Marek
2020-08-27 18:16 ` Dmitry Baryshkov
2020-06-08 20:43 ` [PATCH 5/5] soundwire: qcom: enable CPU interrupts for mmio devices Jonathan Marek
2020-06-09 9:26 ` [PATCH 0/5] soundwire: qcom: add mmio support Srinivas Kandagatla
2020-06-09 11:11 ` Jonathan Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8fddf74-9f95-9bc8-6e4f-5fb654c6a43c@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bjorn.andersson@linaro.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®