From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03880351C25 for ; Tue, 14 Jul 2026 11:33:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784028838; cv=none; b=G1RVaT96qXR6DK0LQq9uJgceFCjujhkh2V9y3P82z03Ndz0vdY4+i3addPPUOLn/u5F2yyShi7gClGtpUQjRWlQMoooAjttXbhUXWT0lgstnQwIwceJobPwsatl+xLfGEJksmGiYXdId/HyTTWbx/T+EnJRSSz1klYO9sirh/hw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784028838; c=relaxed/simple; bh=kkRfGYr7evXiSgLOaBtSyZkMM2vAxT6MtKy1j/OI5yk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IcAAea8TV5esm00650Ztgxj6RjXs2Haq8Ib53t5ZZ27ATZ4k1L1F5i6w9+603XeztLCZhZn1w+JqxMJJFxqkROKqK7DBsWEWpCfzoDZ20F92Ic+YGhYiSUqtd1H7QpRwzR+ugqcHtVqbAoUr6fKSc4kCeQPOLquVuMHaIvdCPxE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=UI5RKn69; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="UI5RKn69" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-493bc8fda98so6168385e9.0 for ; Tue, 14 Jul 2026 04:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1784028835; x=1784633635; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=V7QEmIDAdftGvf7AuLdQLq+M42NOg346d/39BJGjeh4=; b=UI5RKn695SnFfzKw7e5J3GcRMNQtpp/FpSYjoSNhF3J6gLafiEnI1NrwCuDdjlSoJ3 PznfW/IUCe66uG/VHS5P+Vr8PdAsHH2nlxxvBf5R4QL+yyScnwrRy+XSqds7a1u4EwQz eAnwKyv4XESKqdDifOCDp7hkMRI4pmSmYlMTJ1Gp3QrRtA1rXbDQyhTDlB1RU5J3zvBd wlM4is28g5H4dH8Ct7CFJrphqtn+ZYNrcnsXGArHlZI5w7oGt39ezmod8ZuPb6dwLS+9 V68fHy4QoNnCzHnmUMqDiBf3R+32HGjbH3XAT79n2gsEsuEF6jR8EF+XEj7HY1FgHsDY op4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784028835; x=1784633635; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=V7QEmIDAdftGvf7AuLdQLq+M42NOg346d/39BJGjeh4=; b=ZQZsCN+60wdjmY5PYk9qVr8Rppr4lwPbNirTiMPv7TeemhD8WyozdtSSUYZ7+VTLnf vxwYqi5Lg5feGly1gPKdeH1ZnkUmBZuX0Ixq/4Rpuw9wywz78H1clh6rxUFiF94p6N7E j8pHzl1mwyndBoC3qj92zPvr30V4f0E4KImmxc1CIG05HFMcqmf2VC+CSK2HYENTDBFa rpfTVGaBFSjOuQDM2PkryYJTnBPWsWnFKDkeJTs/914LkIdWgHXWUkVIg4OuN6ZiteqF GzGTz4XVxt37G+uwxOGiBE24m+hVYoo17yMq4Zek/ZsTO3uLY3Pc3Qk1Eq/eLZmAE/04 4X/A== X-Forwarded-Encrypted: i=1; AHgh+Rp/CWzSU3yu7sgZuHINX56yhG891Hj/GC1Q2H2TpvY6fMA/YLloPRD8KEGOw+p4tW1Fth05fonHEtJdlhk=@vger.kernel.org X-Gm-Message-State: AOJu0Ywbuf0SzI+jGaiNey638cOrCjAG9m+XmX+jw59osKN5Ko6h+VjN OZN6sTgFmJpO9CjRr0CaYAFkvY+iGbyhOCBmpKWvq1fYDvlqYTXFzWgi1nTW9lo7DDU= X-Gm-Gg: AfdE7ck/ZqmGMeMyPsD5DesIkVE9sHfgqntj2hIBdCFGC7WZPkSUNZhg+3q2t39bHyi xxUcC3T6blmSk48AryR9DcT1qwFmHPMOf3qtilLflpDBxwHqdAGtfMshRDIkWp13VPZKMQCdVpq S5AFjDE5bHemoprx2zgYcwfEoxtGCuELxaW+G+WOYwtL7Ybjp2DLV9dYneJt0c3kQzJfi1wFFQC FiMnBX7UHznm8hezHMiODjoy5KaSheOrGVmNwdiOT2xEinMca61NxsZSuNlzhrDrbql06+Gcud5 U17L6GetpdnkUFfiJpc5J1ULE+snmUGtzroXN9GoU9bkFP5t4aXNDX5u40dXLUJQVlVAlnATI4i B6lg1+++Rpl41wQTYraTnu+AtfxO006mDaE/+OwN5EPkT4shsjtIM3b2KuUWvve0vVBgedP04hD tIcHxgR9oogTskSlfx5A9LKkyTLvJw5gw/wg== X-Received: by 2002:a05:600c:4ece:b0:493:a613:56b2 with SMTP id 5b1f17b1804b1-493f87d8573mr124226635e9.8.1784028835160; Tue, 14 Jul 2026 04:33:55 -0700 (PDT) Received: from [192.168.42.79] (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49508731fcdsm60488595e9.4.2026.07.14.04.33.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2026 04:33:54 -0700 (PDT) Message-ID: Date: Tue, 14 Jul 2026 13:33:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] module: validate string table section types To: =?UTF-8?Q?Thi=C3=A9baud_Weksteen?= Cc: Aaron Tomlin , Markus Elfring , linux-modules@vger.kernel.org, Daniel Gomez , Luis Chamberlain , Sami Tolvanen , LKML , Siddharth Nayyar References: <20260708012107.1621513-1-tweek@google.com> <99301e32-b067-4d0a-a087-2c77b1fe0a90@web.de> Content-Language: en-US From: Petr Pavlu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 7/14/26 1:37 AM, Thiébaud Weksteen wrote: > On Mon, Jul 13, 2026 at 10:14 PM Aaron Tomlin wrote: >> >> On Fri, Jul 10, 2026 at 10:23:00AM +0200, Markus Elfring wrote: >>> … >>>> Validate that both string section headers are of type SHT_STRTAB before >>>> caching them. >>> >>> How do you think about to add any tags (like “Fixes” and “Cc”) accordingly? > > Thanks for the suggestion. I can't seem to find any relevant commit > for Fixes. There are > ec2a29593c83e ("module: harden ELF info handling") and potentially > 3c5700aeabd87 ("module: Factor out elf_validity_cache_secstrings") > Both of these commits already intended to harden the parsing. I don't > think there is any regression here. I agree. > As for Cc:, I can't think of anyone who should be explicitly added. If > you have any suggestions, please chime in. I'll add 'Cc: stable@vger.kernel.org' when queuing the patch. -- Thanks, Petr