From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFEB5ECAAD2 for ; Mon, 29 Aug 2022 07:41:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229708AbiH2Hlg (ORCPT ); Mon, 29 Aug 2022 03:41:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229644AbiH2Hl2 (ORCPT ); Mon, 29 Aug 2022 03:41:28 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50E314BD32 for ; Mon, 29 Aug 2022 00:41:27 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id bu22so8721690wrb.3 for ; Mon, 29 Aug 2022 00:41:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc; bh=5up3cUBmqLmN/N4JsoGSCpsquDZUxfx3SQvM9VcSSqw=; b=YuPbkZr0Ax4OGbfNlSy3XGJ1Ho31X7gBNQTXMazlCaETwKK9GDqXs3uG0+jn8EvRPP GlaxYOmBEY9SC8WAs82C9ADhKCmlxGkRAbKCoG0btJPCcrdmzxZHHZvRT5EnZlxDJY4s ic3WYpgsIDj/OS+VB3ynaAgYCvUeBZoVxXJCyHqmpXj17QPogEfJy+jXKCYh5W/U24E4 DLvW7XMoR5/2HRuSFCbeSgaiRZsEDu6hUxwytB89remwuL6kmT8yDGetlz4b9J0MgcNp ZF5JMnCVdyQWwxwUELqxwh+ZM2ASzzCdSZgznsjuSxEh/oV6BQmUdV945DjSPU7D+F/O omoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=5up3cUBmqLmN/N4JsoGSCpsquDZUxfx3SQvM9VcSSqw=; b=h+qUCugUDbfZ8HAjM7pVCx7yqrsvc36t8MReXuE6lZR0AEjbIjvefV2+chT9ECcs1T TWNrYHLKaqhMZzMJpt9qXJh2kTxvlM31N8lULzNrATbT2O18aVZl/FbD0rATrTUsm21/ yNKyt/w3SK21OuO5YHUAx6kFX5kPS+Rfu3/TunPXprFxaYIcrMd2tcD3AZw2ALdweo8C BnaTEDm1ZFVCOB1y2UKSIGB6EQBhvwXDVTFop66+pAyeRwKDRBqBmAyutIplcV8mXlad o6wvrbf76GFHSlOq/XQgbDyb+Cl6nCVJQ0EAvoellCIWcXTP++5D30IT7PYJHlrqmrch ew/A== X-Gm-Message-State: ACgBeo0+8igcq3I6imb+ghOshP1OfsejKk82cyKtVdWMvR4zdYHGJjK3 kk5+SEVyepSUKSey/Q8Q4q9nKw== X-Google-Smtp-Source: AA6agR6NLCGeE1ZIf8UdYmeZQOwbczj92cej7w+PZTtWO71lnImArQKYk0kqLF1viANjjlBGYnQ4Ew== X-Received: by 2002:a5d:6b46:0:b0:225:3510:a130 with SMTP id x6-20020a5d6b46000000b002253510a130mr5446784wrw.46.1661758885778; Mon, 29 Aug 2022 00:41:25 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:6124:6b74:2847:d37b? ([2a01:e0a:982:cbb0:6124:6b74:2847:d37b]) by smtp.gmail.com with ESMTPSA id q16-20020adff950000000b002251639bfd0sm6230191wrr.59.2022.08.29.00.41.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Aug 2022 00:41:25 -0700 (PDT) Message-ID: Date: Mon, 29 Aug 2022 09:41:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] arm64: dts: meson-s4: include meson-s4-gpio.h Content-Language: en-US To: Huqiang Qin , Krzysztof Kozlowski , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: From: Neil Armstrong Organization: Baylibre In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/08/2022 13:32, Huqiang Qin wrote: > Hi Krzysztof, > > On 2022/8/25 20:02, Krzysztof Kozlowski wrote: >> Why? We can see what you did here, but commit msg should explain why you >> do it... > > Sorry, I didn't describe this commit message clearly. > > In the future, meson-s4.dtsi will have some nodes that need > to use the meson-s4-gpio.h file. > > e.g. >     (1) Bluetooth enable pin: >         bt_en-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>; >     (2) Audio mute pin: >         spk_mute-gpios = <&gpio GPIOH_8 GPIO_ACTIVE_LOW>; >     (3) ... > > So, this patch was born. We understand, but since the Upstream linux codebase want to avoid dead code as much as possible, please defer this patch when node will actually use these gpio defines. Neil > > Best regards, > Huqiang >