From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0F4841A513 for ; Tue, 28 Jul 2026 09:29:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785230995; cv=none; b=ePKkZL1Dw2sh01Z1TnjOMgYDt81Cm2Gku5DAXuB9oph7pbgZiSUkvl+GcGl7W0BtDt3ZJbTo5BZgNLMzLP9DCRiSW9yoa7DFgKE7v7pNrCOnCXME4p2EbnxgvbvPpH3JbyiI4zS9DyhsQz2cTuWbazZmfeBqhJ+ayV8ukodVLMw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785230995; c=relaxed/simple; bh=+cJ6lA0Ry4sm9jxuVqVS+Spb1104T8rj0lLFUr9YixA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AtDEDpAwrTTZnrWX5VkIuJUPBSV4x15cmK5P2C86vieqykCydyckimRqldU7MrmbieaWP1zw39n6ElOPgxcYGYRAKwYxjOd+/8Hl52evdOwcLnTh8ib8Mh/fo2hn9mWdcsN0bAzE+Fjix173+hE2WVf+sRhYIi+AWoOcIuOYOcI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bY4mFudN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UC8VbR1C; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bY4mFudN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UC8VbR1C" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66S82BWf2358523 for ; Tue, 28 Jul 2026 09:29:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GC/ZuBK1RLJ4ibzTXEvYuoddg6a2oCrBqfBM6hC1438=; b=bY4mFudNCbDLmTw7 nT4W1b1w1tiKDSBRPCjiDIc7tdENyfJx6yQYk0dWIFO+Inbfrm1Wt61QMkt8pZbR TpQS9XdL7JGwiPPKAG+Wun1cgssUIZIbGxXtziFw/Ez00ksCRaijwzXxvBI/17Ys oIn/PFinPIrulCNeNYtAnHCmCXrgt3+40qPEVgC4ElyWIBHNZ1WaSrtH6Mzx6K9g VlIr2NYh0LrAqwG6YZGGrrUuWXjgZzrVdtxs4wxHRtJLmJFUI9v3nvbFSDaBt0mb GGdJJTbKezNB8fHxKtnGYQK8q0ayopddOmKZeT/ioGAldiJuxBFCenp1X/dtmfwT rmGvVQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fpn3y177t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Jul 2026 09:29:52 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c27616421so9565181cf.2 for ; Tue, 28 Jul 2026 02:29:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785230992; x=1785835792; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GC/ZuBK1RLJ4ibzTXEvYuoddg6a2oCrBqfBM6hC1438=; b=UC8VbR1CK8xO2QOfA+1eSoMQ/N2hH449LJ8tvuyib/v89J2/GKhv9pe/BwcNXPeTaR ve8qa7dmvBK4k/uUNgZFUdjPpxXEUmh8LTXMaYEjrpSeNBWyRZqqlUl2k4jyQqq1WVoQ naXBQUrOho1PJK/hjWs9GFtGLaiya6hw/PRbZBY3e9eY9L188dgO1Lk/UyePitEvlOlL gX2MotHzkHxW+9y48vi4qzWuyjX0DhYCW/0vbtHeGI0fdpeUVXgzWvAcMjnjQUfcO/cs 2vfV8r0IBo7SKjktZWqWbge093uTGEQjozY+eMo6Wjdz0jqr4gXDTzcF2VKVMKb1NidO 1cDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785230992; x=1785835792; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GC/ZuBK1RLJ4ibzTXEvYuoddg6a2oCrBqfBM6hC1438=; b=ipMEB2+w7E5UNpnMTuEP6k5vL3822cUAiXNnECvyO//8AuNoidsMWstligcmAQT+j2 CtUUP0kl/LccKrZHiP62go3qJuvhWpBSygjcz5LgE6hnRckYvHF5LMncgKSVPxPXVuzb SM/l2Fqu2Fgsk91sLvmiBy+lWOTm5JHYq7+54/xTQcmFE0viJpzBNlPrsq31ywmJ/3Dz FbUZdNyxIbj9XFAH72l7Reg+spleR2oE8KpgXM9JQ7i/GpwVHk0vnxW6Qdml4of1jCGM +aQd+P8LQ4LynFKVSQ/YZaw83d2KJXvt6XvNbPBp0VZt5c4EAiPNR4ad4fZM94EM7W+h 9u0w== X-Forwarded-Encrypted: i=1; AHgh+RpC+12FsMT0sceFlqcq49+c4vzJhuiZ9Q5gnhvlk8/6LjzZ8vgxPAUTMoN119+WqliQdEa29AnKj8wJla8=@vger.kernel.org X-Gm-Message-State: AOJu0YxcmvMBAzmU0qjxdRSRgeKMwtcGjU/2+tdlgMrsG5hWOJ8R0qbo Jb8bhfjGgnTN1e2DMWE7TKb8NVVdHwE/KN6B2HVby/oLaVj2ATOgKHqFh4TiL9y1b/NKfXAnSn3 OUl45P29iJ4TAmYs6H4Bo6u3eLL3TlF3qTniKRVzDvsXm/v/Oqj2dWDBmFy0u6pY1PZ0= X-Gm-Gg: AR+sD13cO7uLhbTKPcc6v40jM3Gtf+KHFCx35fbviWik0e0HwekYPzYZ57TLJfJa/uN A0+lI74xjcSNGXWvGe7gORHLkSNH6qd+8i2St/qXEU6+FsDrvRo/CjBPaqtO8vw7k/rP2a1jIur yWSVAmz6+lXouS0qvPqvhVjBZLGzyyIxIMHVake+F+tKOYySM6GnROwPBo1ql0eiVIYwrB/RDma 8g5D6jt3nqKGZh95K43rSHarADadk+h9F4psqGmCWABrxH6LapPjmV1d1LDQvFtSuPW1ZJ2IsKh eeH8F491N8W8uOOXF2Gqvr976I7SdJ3wDFT2i4t9gSqsfM9SigxP3Gqg1Ue18HuQMsniOgTJC3R OItOfjH86yKo+Pkg8AnFGKOFA X-Received: by 2002:a05:622a:15d5:b0:51b:ff78:f229 with SMTP id d75a77b69052e-529d6feaeabmr10813861cf.5.1785230992010; Tue, 28 Jul 2026 02:29:52 -0700 (PDT) X-Received: by 2002:a05:622a:15d5:b0:51b:ff78:f229 with SMTP id d75a77b69052e-529d6feaeabmr10813591cf.5.1785230991598; Tue, 28 Jul 2026 02:29:51 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69fb5543370sm3675170a12.15.2026.07.28.02.29.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jul 2026 02:29:50 -0700 (PDT) Message-ID: Date: Tue, 28 Jul 2026 11:29:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/12] clk: qcom: ipq-cmn-pll: Add NSS clock support To: Luo Jie , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com, quic_suruchia@quicinc.com References: <20260724-qcom_ipq5210_cmnpll-v1-0-a8b8679d215f@oss.qualcomm.com> <20260724-qcom_ipq5210_cmnpll-v1-4-a8b8679d215f@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260724-qcom_ipq5210_cmnpll-v1-4-a8b8679d215f@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=fbidDUQF c=1 sm=1 tr=0 ts=6a687690 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=rcriG_6vuXrZ4KVOdM0A:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI4MDA4MiBTYWx0ZWRfXzzDsoE8RhAx0 pbGwJBHO0fdDs3rT6rAkJ29TGrge/Iu6kptGjmL3tY9WmxWO//4bGoMTiZGIgjO2/NtjAwqocNV 1JPtmPO1gdoBlN1Dzj8zbPMEgYqdVFI= X-Proofpoint-ORIG-GUID: OsARm27kLVSbbakgvEQrLsZKk3oxQNhv X-Proofpoint-GUID: OsARm27kLVSbbakgvEQrLsZKk3oxQNhv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI4MDA4MiBTYWx0ZWRfX7QGdkBwvsP7c SvsXOzZlgrmDMdmp/cHk5JWYIrVMi4/5SwLwEa6nzV03xFjy/ZfcA7kHaLuiQsIUfdR6PIbAJiX CywzPbFd3CKZMrXP/r73ygkmV/oMAejDm+tGH82xTQWY10KYDMgoxsqdjfqWbvCx4ZZM7JdmxbP LsukaAmv6Swp83r5Byt3FOa30sXvtl0+yfZBAfdoEl9yAjaqdhxELUbPSs9n/5i21gz95PbykVV jHSSjTqo8OrnsspCLL20IWYDN2Mg0EQ1j4ks15ubUKwoeAhrI0xLCCt9g34a2d/ojKUkvePhOnQ qm10WettVZ8sPIfED2XrUHBtX79fMDTL2laDJx85+1ZGRmkcY2foKjqbTrgZamCbI1pvvyR07lj DKOZfVERNpH98dz3P5XX+aNbSNN/2GHXr2FT4YJFTDHuBna+M0BU6YBAxO2mf6/kjOs9jjvQs5T ByasV1q168m2MikG0LA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-28_02,2026-07-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 suspectscore=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607280082 On 7/24/26 5:00 PM, Luo Jie wrote: > The NSS (network subsystem) clock is derived from the CMN PLL output > divided by 2 and then further divided by a configurable 6-bit divider > with a valid range of 8-63. > > Signed-off-by: Luo Jie > --- This looks very similar to clk-regmap-divider.c (or at least to the generic clk-divider.c implementation). [...] > /* Register the fixed rate output clocks. */ > for (i = 0; i < num_clks; i++) { > - struct clk_parent_data pdata = { .hw = cmn_pll_hw }; > + if (fixed_clk[i].rate) { > + struct clk_parent_data pdata = { .hw = cmn_pll_hw }; > + > + hw = devm_clk_hw_register_fixed_rate_parent_data(dev, > + fixed_clk[i].name, > + &pdata, 0, > + fixed_clk[i].rate); > + } else if (!strcmp(fixed_clk[i].name, "nss")) { > + hw = ipq_cmn_pll_nss_register(pdev, cmn_pll->regmap, > + cmn_pll_hw); Huge "no", this must be a compile-time constant and not rely on some funky detection. Konrad