From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 144E33A6B8F for ; Tue, 7 Apr 2026 10:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775559572; cv=none; b=leaPeFzsgxIsdyxnqHyLd9VIuR9qprxgxA2tgLcGrzZcXr4t3bPymxSWonrbydkAATt35abSc1W4ZAkXxSZx20kEUJMTvMnmeSlGnuuuSQILCBF5elrDq4j6ky/+uLzP3gZYA3bIQg2rUp6iRCzqNnWgyv3iuKw+MSWItQqFaxA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775559572; c=relaxed/simple; bh=737W6+/2drWk5LVgPyAsBZ+48h21WwacCiZb58nIeqQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K8sSwrjauuhL90tvCKq3awE5y7bYkxve9KZjmlpyCbHfT/7Vi9xXXOmwrbjhmILbuvGHrnbzE9f2ZBnZaLpF98hEoEBINoX+Get6HAzRsHl3jqaDk2B0ZdN3KKTnB9Ir12O+A2zEBjZqRAVEQ3vrfMr/XSLK5EDB5VJtCoR/cy4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=W+LOTv13; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YZ7NkMK8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="W+LOTv13"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YZ7NkMK8" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6376qZJO4009170 for ; Tue, 7 Apr 2026 10:59:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pW18SYaewZa2ej+crJk99wLT0nXZT691qI5b/3x5qMM=; b=W+LOTv13ENjFxOAP pEXx12Pc1CtXtjBrpCSy841S9mfXxu6RcST8MTyQigyM8zPoUjZXAYEH7JLoKRYH mJ1S4Bq0nWKEP0j/4ewik69txqIU4Pv9QqCIM6t5Juuf0FbulbvxjLRtwZaFTHaw yRAPKRPc+7ZAjQrLrR/vnG5HzzBTUUS5w09VpfK2VkbO8E9+FL6m+vCSCuf2hcVh JWE+kvVYwgUsjdgdknhX7B1FLNpL5PbE+XM9ErtjO44E9BHzpijQmPFKO+GExgYd Bsf+riVeEmQaLIVr/0sflVz4W1VR3NRl/TX7h3ZbU5CLO/to+9ALI/pMxtJcBL3f CdK44g== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmrktbm4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 10:59:28 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c76b6db8bb2so2228376a12.3 for ; Tue, 07 Apr 2026 03:59:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775559567; x=1776164367; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pW18SYaewZa2ej+crJk99wLT0nXZT691qI5b/3x5qMM=; b=YZ7NkMK8llb/s4ZYWBgox6H0RYxBfoyBfATUDd0QU+2JVrKAp7V3biZE8W3Y9rZkzi nhFdYH4vQB3fQgBadj26gz/w24NS2194vxkVavz4eQtbp8/iOkw57379EuesQbSdLjna ALB+ntPshIhzKOErzbatfH9jpwlxINaGgfB3vlk4aQDQOaDEfLHLsgdweN/Vfl+lF81/ 5LdhBrIOOrSY9toNyZXDcGoqwuaAyV7AWEbCdZKbbyJkb384q9B49I/NuvzkccqqaSn/ 2w+yKcPZM4QSYiqi78u4lmfIVxUzgkqt5Ci9lIqbH9qfWPJNE6120PEUV872Oy/D9Mmo R7+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775559567; x=1776164367; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pW18SYaewZa2ej+crJk99wLT0nXZT691qI5b/3x5qMM=; b=PC1sdymXj6g4ZoeNlHaS3h1yF5WPbmvuSSOdlatfovpn3Vd+UbrHTxOu8UQpPbeP3c HPzVHknKaIWsy5ZnC3DTdpFpVL9bRErWDqn28zPzcPb504rj6NPNLH1u4VZigdTwpjdJ UODxqfNVWPVPX/a1YapqOzIb4hUvO/23M6gHGLyjmCKTR0zXgcGSeeBffipacyWpILJS G3UyMD0JSXgAJWERbct+Njvt+J2Ac2SknR5+4aDOPwRp9NhxAZc8yyfVvJJQRbUM0RxZ MFCu0F0+liNrJyi1kfEJuHpP79idKUGsz+e8cqSXZy0/VFlANN6+WOXWxYR2EikePgY+ iDww== X-Forwarded-Encrypted: i=1; AJvYcCVdqHVFoMkzb2RL3hY5Ivtf18n2RHqFolRZz5rD601Sv7H+cIryO3PKybNQRzln8ulYYTWcsdPx+GMNE10=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4azaalxiMrcqa49LdOGnUemmcukgfRkU93criF7K8EDWqRt8J 5cQxb0N+O3Be/P19E0GSw8SJ9OYTp/uno6CJZOa58+1H61HEiLMEUmQ5Ab7JBYyEVMlFAO/YSoW c3RMOvkTq47T4sgQec6Inu9KZ7IkJ1muNNGqutxxn1nOXfoz2exvPb2znfwKup0FSZjY= X-Gm-Gg: AeBDiesAIo+9H8vKIrt4GvICmqLeuOSgJr3Jyk/2dpTJhHq9j+ZoeCKCeWnanYEu5k6 /44eUh4ElsIhJnWyQUMSunOjRLSiv3hNwIkJ5Hz4K3W6RZrEh1L7bX+CoRvsj5b5sNsa7khm870 sD8W2531bRCuU1p4nXIzSuat1MLtWP7pqjg4Kfl/h2QwoJm/uv+gzo1Vt0mZqJYxFRBIYxQJ3sv pHSOn4z7qm9mgOwurmxDfKD7KQH3yXAa4Y5yjb7X/Uq+XChWrcQO1ip56UoQ1Spr1txC3XGdl6p LMY4XYq7ameH46bTgd1weNoDzIYHmb0TrreE1QWjED4mNKTDu8ekO7dwRM2OIbagd7KQDv1NOvr HIxVvUmcP2oRibcsQc8ackYBv+V32UepJqT+Ki9/ppiWFoizVZD9Lqi7u7mTllz3ZEdASmye+gW 7knV7o8TOnzA== X-Received: by 2002:a05:6a20:244d:b0:398:bda8:d8cd with SMTP id adf61e73a8af0-39f2ed0ff5dmr15779432637.7.1775559567468; Tue, 07 Apr 2026 03:59:27 -0700 (PDT) X-Received: by 2002:a05:6a20:244d:b0:398:bda8:d8cd with SMTP id adf61e73a8af0-39f2ed0ff5dmr15779398637.7.1775559566966; Tue, 07 Apr 2026 03:59:26 -0700 (PDT) Received: from [10.133.33.25] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76c6476a81sm15130467a12.7.2026.04.07.03.59.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2026 03:59:26 -0700 (PDT) Message-ID: Date: Tue, 7 Apr 2026 18:59:21 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] coresight: tpdm: fix invalid MMIO access issue To: Leo Yan Cc: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Tingwei Zhang , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260407-fix-potential-issue-in-tpdm-v1-1-42090d27c0a8@oss.qualcomm.com> <20260407081048.GJ356832@e132581.arm.com> <0a4911f4-168b-48c4-9554-3962d6e96efa@oss.qualcomm.com> <20260407103530.GL356832@e132581.arm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20260407103530.GL356832@e132581.arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Rrz16imK c=1 sm=1 tr=0 ts=69d4e390 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=7CQSdrXTAAAA:8 a=D9BDWDdkfOs3MDT8590A:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-ORIG-GUID: gXZAU3ekFtz0uDRh0kevIy9Uopa4ovJC X-Proofpoint-GUID: gXZAU3ekFtz0uDRh0kevIy9Uopa4ovJC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDEwMiBTYWx0ZWRfX6FvfbwvV9Iwu bmOEJjt+shmZtjlULT2y+a6DpTpHxrVEkwUaNRPFI/SOb7MTEffeViJafBea7Z5TktEE/EiEiRd 6BD6KPzRLgenudyNdpjVeUt/pwmtMfvmE/F+Kwc0MXmhstA8mgBzLoFIzwoQUd7zOBcav3BVIPm V8MUzY33rFf8R0iNQR/aXb1blDRdbdBPXdK1qxz9iSzZPmbmntZcR5sgj3t4IyvrMu6coTV5Ovq xYhNKK63Ki/e2JeAlBxa7HMKySrh7CFc94kWDojPm8z7nURIQFfKzvsNzrwmHBPiEZwvnWfrp4q 5N429vwyGAwjNv27pW2EssalFZk0khnWiJpe8twNVlEWSq3jJUw9WVR3NYUhZsYPpdHjuTymzVl sNU8SMnGt77yWv94f0K5oAYLdKrGr25NxERy1N4KwUg348VmhE3MUfoL5WubM43805Lpyzg3U54 Cbcmy4GfyUJcUbSXlrA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-07_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 phishscore=0 bulkscore=0 suspectscore=0 adultscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070102 Hi Leo, On 4/7/2026 6:35 PM, Leo Yan wrote: > Hi Jie, > > On Tue, Apr 07, 2026 at 04:33:22PM +0800, Jie Gan wrote: >> On 4/7/2026 4:10 PM, Leo Yan wrote: >>> On Tue, Apr 07, 2026 at 12:47:11PM +0800, Jie Gan wrote: >>>> Create the csdev_access struct only when a valid MMIO resource is >>>> available. In tpdm_probe(), base is uninitialized for static TPDM >>>> instances that lack an MMIO resource, causing csdev_access to be >>>> created with a garbage address and potentially leading to >>>> unexpected issues. >>> >>> This patch itself is fine for me. However, I am wandering if this >>> is sufficient. >>> >>> As mentioned "potentially leading to unexpected issues", can I >>> understand some code pieces access register with uninitialized base? >>> If so, you would also explictly add coresight_is_static_tpdm() to >>> prevent register access. >>> >> >> Actually, we havent MMIO access for the static TPDM device, So no issues are >> observed. The commit message here may be misleading. do I need rephrase the >> commit message? > > Yes, good to clarify a bit in commit log: > > "So far there has no register access for static instance, but this > change helps mitigate potential risks in the future." > > With this: > > Reviewed-by: Leo Yan Well noted. Thanks, Jie