From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Lucas Stach <l.stach@pengutronix.de>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: Russell King <linux+etnaviv@armlinux.org.uk>,
Maxime Ripard <mripard@kernel.org>,
Erico Nunes <ernunes@redhat.com>
Subject: Re: [PATCH 07/60] drm/etnaviv: Add support for the nomodeset kernel parameter
Date: Wed, 15 Dec 2021 10:45:05 +0100 [thread overview]
Message-ID: <a919884b-1e28-bf49-5de6-5cc2b6329969@redhat.com> (raw)
In-Reply-To: <36d2ca10-22ae-5c15-4ab1-6ff84507c0cb@suse.de>
[adding Erico Nunes to Cc list]
On 12/15/21 10:39, Thomas Zimmermann wrote:
> (cc'ing Maxime)
>
> Hi
>
> Am 15.12.21 um 10:18 schrieb Lucas Stach:
>> Hi Javier,
>>
>> Am Mittwoch, dem 15.12.2021 um 01:59 +0100 schrieb Javier Martinez Canillas:
>>> According to disable Documentation/admin-guide/kernel-parameters.txt, this
>>> parameter can be used to disable kernel modesetting.
>>>
>>> DRM drivers will not perform display-mode changes or accelerated rendering
>>> and only the systewm system framebuffer will be available if it was set-up.
>>>
>> Etnaviv is a render-only driver, so will no perform any modesetting on
>> a display device, so I'm not sure if it's sensible to cover it under
>> the nomodeset parameter. I see that it is consistent with the other
>> drivers that deal with a combined render/display device, where the
>> render device also gets disabled with the nomodeset param, but it
>> doesn't really match the description of what the parameter is supposed
>> to do.
>>
>> I'm not opposed to take this patch for consistency reasons, but I would
>> like to hear some more opinions from other DRM folks.
>
> Our assumption is that we want to disable all DRM drivers; except those
> that operate on the firmware's original framebuffer. That's why the the
> test is called drm_firmware_drivers_only().
>
Yes, we tried to document the implicit "nomodeset" semantics to make that
clear: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=b22a15a5aca34c8f59b770f858b1c21d347175e0
> We know that nomodeset is a terrible name. We only kept it because it
> was already there, widely used, and already does what we need.
>
> We had similar concerns with the v3d driver of vc4. Javier, maybe we
> should leave-out such special cases for now and discuss them separately?
>
I was discussing the same with Erico (one of the lima driver developers).
Agree that we could leave those for now. Will drop from the patch-set all
the DRM drivers that don't have the DRIVER_MODESET .driver_features flag.
> Best regards
> Thomas
>
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2021-12-15 9:45 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 0:59 [PATCH 00/60] drm: Make all drivers to honour the nomodeset parameter Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 01/60] drm/komeda: Add support for the nomodeset kernel parameter Javier Martinez Canillas
2022-01-24 17:09 ` Carsten Haitzler
2021-12-15 0:59 ` [PATCH 02/60] drm/arm/hdlcd: " Javier Martinez Canillas
2022-01-24 17:09 ` Carsten Haitzler
2021-12-15 0:59 ` [PATCH 03/60] drm/malidp: " Javier Martinez Canillas
2022-01-24 17:09 ` Carsten Haitzler
2021-12-15 0:59 ` [PATCH 04/60] drm/armada: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 05/60] drm/aspeed: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 06/60] drm/atmel-hlcdc: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 07/60] drm/etnaviv: " Javier Martinez Canillas
2021-12-15 9:18 ` Lucas Stach
2021-12-15 9:39 ` Thomas Zimmermann
2021-12-15 9:45 ` Javier Martinez Canillas [this message]
2021-12-15 0:59 ` [PATCH 08/60] drm/exynos: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 09/60] drm/fsl-dcu: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 10/60] drm/gma500: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 11/60] drm/gud: " Javier Martinez Canillas
2021-12-15 21:37 ` Noralf Trønnes
2021-12-15 21:50 ` Javier Martinez Canillas
2021-12-16 8:20 ` Thomas Zimmermann
2021-12-16 15:47 ` Noralf Trønnes
2021-12-15 0:59 ` [PATCH 12/60] drm/hisilicon/hibmc: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 13/60] drm/hisilicon/kirin: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 14/60] drm/hyperv: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 15/60] drm/i810: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 16/60] drm/imx/dcss: " Javier Martinez Canillas
2021-12-15 9:20 ` Lucas Stach
2021-12-15 0:59 ` [PATCH 17/60] drm/imx: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 18/60] drm/ingenic: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 19/60] drm/kmb: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 20/60] drm/lima: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 21/60] drm/mcde: " Javier Martinez Canillas
2021-12-15 1:02 ` Linus Walleij
2021-12-15 0:59 ` [PATCH 22/60] drm/mediatek: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 23/60] drm/meson: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 24/60] drm/mga: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 25/60] drm/msm: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 26/60] drm: mxsfb: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 27/60] drm/omap: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 28/60] drm/panel: ilitek-ili9341: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 29/60] drm/panfrost: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 30/60] drm/pl111: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 31/60] drm/r128: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 32/60] drm: rcar-du: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 33/60] drm/rockchip: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 34/60] drm/savage: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 35/60] drm/shmobile: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 36/60] drm/sis: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 37/60] drm/sprd: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 38/60] drm/sti: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 39/60] drm/stm: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 40/60] drm/sun4i: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 41/60] drm/tdfx: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 42/60] drm/tegra: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 43/60] drm/tidss: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 44/60] drm/tilcdc: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 45/60] drm/arc: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 46/60] drm/gm12u320: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 47/60] drm/hx8357d: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 48/60] drm/ili9163: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 49/60] drm/ili9225: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 50/60] drm/ili9341: " Javier Martinez Canillas
2021-12-15 0:59 ` [PATCH 51/60] drm/ili9486: " Javier Martinez Canillas
2021-12-15 1:00 ` [PATCH 52/60] drm/mi0283qt: " Javier Martinez Canillas
2021-12-16 15:48 ` Noralf Trønnes
2021-12-15 1:00 ` [PATCH 53/60] drm/repaper: " Javier Martinez Canillas
2021-12-16 15:48 ` Noralf Trønnes
2021-12-15 1:00 ` [PATCH 54/60] drm/st7586: " Javier Martinez Canillas
2021-12-15 1:00 ` [PATCH 55/60] drm/st7735r: " Javier Martinez Canillas
2021-12-15 1:00 ` [PATCH 56/60] drm/tve200: " Javier Martinez Canillas
2021-12-15 1:03 ` Linus Walleij
2021-12-15 1:00 ` [PATCH 57/60] drm/udl: " Javier Martinez Canillas
2021-12-15 1:00 ` [PATCH 58/60] drm/via: " Javier Martinez Canillas
2021-12-15 1:00 ` [PATCH 59/60] drm/xen: " Javier Martinez Canillas
2021-12-15 5:58 ` Oleksandr Andrushchenko
2021-12-15 8:14 ` Javier Martinez Canillas
2021-12-15 1:00 ` [PATCH 60/60] drm/xlnx: " Javier Martinez Canillas
2021-12-15 8:31 ` [PATCH 00/60] drm: Make all drivers to honour the nomodeset parameter Thomas Zimmermann
2021-12-15 8:50 ` Javier Martinez Canillas
2021-12-15 9:10 ` Thomas Zimmermann
2021-12-15 23:26 ` Javier Martinez Canillas
2021-12-15 9:12 ` Thomas Zimmermann
2021-12-15 9:25 ` Javier Martinez Canillas
2021-12-15 23:35 ` Laurent Pinchart
2021-12-16 0:13 ` Javier Martinez Canillas
2021-12-16 0:24 ` Laurent Pinchart
2021-12-16 0:38 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a919884b-1e28-bf49-5de6-5cc2b6329969@redhat.com \
--to=javierm@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ernunes@redhat.com \
--cc=l.stach@pengutronix.de \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®