Re: [PATCH v7 7/7] drm/msm/hdmi: use DRM HDMI Audio framework

[Abhinav Kumar <quic_abhinavk@quicinc.com>]

On 2/7/2025 4:27 PM, Dmitry Baryshkov wrote:
> In order to simplify the driver even further and to remove the
> boilerplate code, rewrite the audio interface to use the DRM HDMI Audio
> framework.
> 
> Audio InfoFames are controlled centrally via the DRM HDMI framework.
> Correct InfoFrame data is programmed at the atomic_pre_enable() time (if
> it was set before, drm_atomic_helper_connector_hdmi_update_infoframes()
> takes care of writing all InfoFrames, including the Audio one.) or
> during msm_hdmi_bridge_audio_prepare() when the new stream is started.
> 
> All audio data frame management is deferred to
> msm_hdmi_bridge_audio_prepare() and msm_hdmi_bridge_audio_shutdown().
> 
> Reviewed-by: Maxime Ripard <mripard@kernel.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>   drivers/gpu/drm/msm/hdmi/hdmi.c        | 91 ----------------------------------
>   drivers/gpu/drm/msm/hdmi/hdmi.h        | 18 +++----
>   drivers/gpu/drm/msm/hdmi/hdmi_audio.c  | 68 +++++++++++++++++++++----
>   drivers/gpu/drm/msm/hdmi/hdmi_bridge.c |  5 ++
>   4 files changed, 71 insertions(+), 111 deletions(-)
> 

Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>